From mboxrd@z Thu Jan 1 00:00:00 1970 From: "numbchild@gmail.com" Subject: Re: a patch to ob-lisp.el Date: Wed, 6 Apr 2016 18:51:23 +0800 Message-ID: References: <874mbtz0pb.fsf@gmail.com> <87oa9zxnbp.fsf@pierrot.dokosmarshall.org> <877fgbdr5p.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a114f3c72e39c21052fcebf9b Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:57185) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1anl3y-0000b2-Jj for emacs-orgmode@gnu.org; Wed, 06 Apr 2016 06:51:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1anl3x-0003zx-B3 for emacs-orgmode@gnu.org; Wed, 06 Apr 2016 06:51:54 -0400 Received: from mail-yw0-x231.google.com ([2607:f8b0:4002:c05::231]:33090) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1anl3x-0003ze-5g for emacs-orgmode@gnu.org; Wed, 06 Apr 2016 06:51:53 -0400 Received: by mail-yw0-x231.google.com with SMTP id t10so50974646ywa.0 for ; Wed, 06 Apr 2016 03:51:53 -0700 (PDT) In-Reply-To: <877fgbdr5p.fsf@nicolasgoaziou.fr> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: "numbchild@gmail.com" , "Thomas S. Dye" , Nick Dokos , Org-mode --001a114f3c72e39c21052fcebf9b Content-Type: text/plain; charset=UTF-8 Hi, Nicolas, the another email which you commented many places is outdated. That patch is modified from the version of MELPA package `org-plus-conrtib`. I cloned org-mode git repo, and created public repo branch at here: https://github.com/stardiviner/org-mode/tree/sly-support-for-ob-lisp I checked this branch's diff with your mentioned places. All checked. I followed org-mode contrib guide to create this commit. Please let me know if there is any place need to modify. [stardiviner] GPG key ID: 47C32433 IRC(freeenode): stardiviner Twitter: @numbchild Key fingerprint = 9BAA 92BC CDDD B9EF 3B36 CB99 B8C4 B8E5 47C3 2433 Blog: http://stardiviner.github.io/ On Wed, Apr 6, 2016 at 5:26 PM, Nicolas Goaziou wrote: > Hello, > > "numbchild@gmail.com" writes: > > > Ask a beside question. I cloned org-mode git repo, should I contribute my > > patch with git way? (I mean create a git branch on my own public clone, > > then paste it here to let maintainer merge it?) > > Please look at the document suggested by Thomas. In particular, please > read section "For Org contributors: preferred way of submitting > patches". > > Following advices there tremendeously helps maintainers. > > Thank you. > > Regards, > > -- > Nicolas Goaziou > --001a114f3c72e39c21052fcebf9b Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi, Nicolas, the another email which you comment= ed many places is outdated. That patch is modified from the version of MELP= A package `org-plus-conrtib`.

I cloned o= rg-mode git repo, and created public repo branch at here:
https://gi= thub.com/stardiviner/org-mode/tree/sly-support-for-ob-lisp
I checked this branch's diff with your mentioned places. All c= hecked.
I followed org-mode contrib guide to create this commit.

[stardiviner]=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 <Hack this world!>=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0 GPG key ID: 47C32433
IRC(freeenode): stardiv= iner =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Twitter:=C2=A0 @numbchild
= Key fingerprint =3D 9BAA 92BC CDDD B9EF 3B36=C2=A0 CB99 B8C4 B8E5 47C3 2433=
Blog: http:= //stardiviner.github.io/

On Wed, Apr 6, 2016 at 5:26 PM, Nicolas Goaz= iou <mail@nicolasgoaziou.fr> wrote:
Hello,

"numbchild@gmail.com" = <numbchild@gmail.com> writ= es:

> Ask a beside question. I cloned org-mode git repo, should I contribute= my
> patch with git way? (I mean create a git branch on my own public clone= ,
> then paste it here to let maintainer merge it?)

Please look at the document suggested by Thomas. In particular, plea= se
read section "For Org contributors: preferred way of submitting
patches".

Following advices there tremendeously helps maintainers.

Thank you.

Regards,

--
Nicolas Goaziou

--001a114f3c72e39c21052fcebf9b--