From mboxrd@z Thu Jan 1 00:00:00 1970 From: "numbchild@gmail.com" Subject: Re: A small patch for org.el to fix error in clojure babel src block code ref Date: Tue, 9 May 2017 16:07:58 +0800 Message-ID: References: <877f1q5y6k.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="001a113f6668666e7d054f12dc08" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:44751) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d80C7-0001Ya-9Y for emacs-orgmode@gnu.org; Tue, 09 May 2017 04:08:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d80C6-0000aO-3F for emacs-orgmode@gnu.org; Tue, 09 May 2017 04:08:31 -0400 Received: from mail-it0-x22a.google.com ([2607:f8b0:4001:c0b::22a]:35954) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d80C5-0000a5-UV for emacs-orgmode@gnu.org; Tue, 09 May 2017 04:08:30 -0400 Received: by mail-it0-x22a.google.com with SMTP id o5so748046ith.1 for ; Tue, 09 May 2017 01:08:29 -0700 (PDT) In-Reply-To: <877f1q5y6k.fsf@nicolasgoaziou.fr> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Nicolas Goaziou Cc: Org-mode --001a113f6668666e7d054f12dc08 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable =E2=80=8BIs there any other possible potential functions will have relation= with this issue?=E2=80=8B [stardiviner] GPG key ID: 47C32433 IRC(freeenode): stardiviner Twitter: @numbchild Key fingerprint =3D 9BAA 92BC CDDD B9EF 3B36 CB99 B8C4 B8E5 47C3 2433 Blog: http://stardiviner.github.io/ On Tue, May 9, 2017 at 2:41 PM, Nicolas Goaziou wrote: > Hello, > > "numbchild@gmail.com" writes: > > > Here is the original discussion we disscusses. > > https://github.com/jkitchin/org-ref/issues/433 > > > > And Here is the patch: > > > > #+BEGIN_SRC diff > > modified lisp/org.el > > @@ -9730,7 +9730,7 @@ active region." > > (setq sfuns > > (delq > > nil (mapcar (lambda (f) > > - (let (fs) (if (funcall f) (push f fs)))) > > + (let (fs) (if (and (stringp f) (funcall f)) (push f fs)))) > > (org-store-link-functions))) > > The change above doesn't make sense, does it? > > If F is a string, it cannot be funcall'ed. Since > `org-store-link-functions' only contains functions, this patch is > basically skipping the whole variable. > > Regards, > > -- > Nicolas Goaziou > --001a113f6668666e7d054f12dc08 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
=E2=80=8BIs there any other possible potential= functions will have relation with this issue?=E2=80=8B

[st= ardiviner]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 <= Hack this world!>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 GPG key ID: 47C32433
= IRC(freeenode): stardiviner =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Twitt= er:=C2=A0 @numbchild
Key fingerprint =3D 9BAA 92BC CDDD B9EF 3B36=C2=A0 = CB99 B8C4 B8E5 47C3 2433
Blog: http://stardiviner.github.io/
<= /div>

On Tue, May 9, 2017 at 2:41 PM, Nicolas Goaz= iou <mail@nicolasgoaziou.fr> wrote:
Hello,

"numbchild@gmail.com" = <numbchild@gmail.com> writ= es:

> Here is the original discussion we disscusses.
> https://github.com/jkitchin/org-ref/issues/4= 33
>
> And Here is the patch:
>
> #+BEGIN_SRC diff
> modified=C2=A0 =C2=A0lisp/org.el
> @@ -9730,7 +9730,7 @@ active region."
>=C2=A0 =C2=A0 =C2=A0 =C2=A0(setq sfuns
>=C2=A0 =C2=A0 =C2=A0(delq
>=C2=A0 =C2=A0 =C2=A0 nil (mapcar (lambda (f)
> -=C2=A0 (let (fs) (if (funcall f) (push f fs))))
> +=C2=A0 (let (fs) (if (and (stringp f) (funcall f)) (push f fs))))
>=C2=A0 =C2=A0(org-store-link-functions)))

The change above doesn't make sense, does it?

If F is a string, it cannot be funcall'ed. Since
`org-store-link-functions' only contains functions, this patch is
basically skipping the whole variable.

Regards,

--
Nicolas Goaziou

--001a113f6668666e7d054f12dc08--