From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id mKFXABvqqV+mTwAA0tVLHw (envelope-from ) for ; Tue, 10 Nov 2020 01:17:15 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id yFniNxrqqV/HIAAAB5/wlQ (envelope-from ) for ; Tue, 10 Nov 2020 01:17:14 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4D3089401BF for ; Tue, 10 Nov 2020 01:17:14 +0000 (UTC) Received: from localhost ([::1]:45666 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kcIHX-0001CB-0N for larch@yhetil.org; Mon, 09 Nov 2020 20:17:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50098) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kcIGm-0001Br-Fm for emacs-orgmode@gnu.org; Mon, 09 Nov 2020 20:16:24 -0500 Received: from mail-ua1-x944.google.com ([2607:f8b0:4864:20::944]:37242) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kcIGk-0007cv-B9 for emacs-orgmode@gnu.org; Mon, 09 Nov 2020 20:16:24 -0500 Received: by mail-ua1-x944.google.com with SMTP id x13so3284568uar.4 for ; Mon, 09 Nov 2020 17:16:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KI2FLiHU/Nzt2yRXk9gvtQnoYC+bOgPasYGMTBRGrOw=; b=FGZbz0CDGzXBCa0vsDntxR/1s91J3xRyRkG8uQUnn//YQU7UaDNeqL6+1Y3wSMhZrn 9r4qSUNzxZe7CM+mWK604LLA1BmUdvqcwSQjdXqYBxsQP/gbhTnll445PRzEi/efd7MH rWA1Cngfeh+/5lYQMV1DE3WI11IAMQxaypk8Qgzf/x50b+i/FWFt7M/8dEKdUvswG7Gg h5vhqAXIwo7GZfj5Ka9r0SZgnf3uG/DhQDt+0Mqha6K8LUqv48SEVdCEBhLfYZEj2yU0 yQzE4BCqAtfk9MWvGbRRLS5FcmIPLl2WwZdRIV7jyHBTBV2gqNomuxuct1PaM5/gh9zJ nBCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KI2FLiHU/Nzt2yRXk9gvtQnoYC+bOgPasYGMTBRGrOw=; b=dq8avNZDi7m/SPOeQuLDDDosyQxD+3GcNzdgIMbVffzDNFwh6khmgyjnrMro+jm1hK kGRJTPq6ET7KzvUDzmHMppbhaoHUq0beKDZRFfVUYH2SjM98yn1Ibx/U5fjGIwVy4mnh jQJ1ngYcVoWrC1BnzZxNMndj/0I9go8tSn3VbMEtEg0xoTQ5sdM+W+Z5frMObDQjb2Y1 k8rtPvHjjQR4WfpU5o/w8XCy2WVgkZgSItdGfy3gstzCe2GrmLCLQPPT2FE1nXZd2i/0 NMZe/1rkY4FIPBrXFZ9g24oq2W5Wcr751la8NCO3hkF5n6k8j4oI86SlCr67xx5DCv69 ybyQ== X-Gm-Message-State: AOAM531w1lYopDcgQqaHy15WcEnaDHE76MEqOOS+Cf8pmnBeBNdsnAN8 WsrK2WTjSKFnLCyCwAc3mwodXDHl2+zgO1wwlw0Mn91UWmbi X-Google-Smtp-Source: ABdhPJxqSKLmb7zRFqbkoyEj33IAll+FfJ6+jwoFNLTrdM3EMn3/lQf5Oi2yvHaI/rJAAybv+TkOauE5fn7MnIkv310= X-Received: by 2002:ab0:186a:: with SMTP id j42mr8464795uag.52.1604970980895; Mon, 09 Nov 2020 17:16:20 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: stardiviner Date: Tue, 10 Nov 2020 09:15:54 +0800 Message-ID: Subject: [UPDATED PATCH] Re: add new link type "contact:" for org-contacts.el To: Jean Louis Content-Type: multipart/mixed; boundary="00000000000031a51c05b3b66d51" Received-SPF: pass client-ip=2607:f8b0:4864:20::944; envelope-from=numbchild@gmail.com; helo=mail-ua1-x944.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: julien@danjou.info, Org-mode Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: ns3122888.ip-94-23-21.eu Authentication-Results: aspmx1.migadu.com; dkim=fail (body hash did not verify) header.d=gmail.com header.s=20161025 header.b=FGZbz0CD; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: 1.19 X-TUID: yCWhAMo7o1zE --00000000000031a51c05b3b66d51 Content-Type: multipart/alternative; boundary="00000000000031a51905b3b66d4f" --00000000000031a51905b3b66d4f Content-Type: text/plain; charset="UTF-8" You're right. Thanks for suggestion. I attached new patch now. [stardiviner] GPG key ID: 47C32433 IRC(freeenode): stardiviner Twitter: @numbchild Key fingerprint = 9BAA 92BC CDDD B9EF 3B36 CB99 B8C4 B8E5 47C3 2433 Blog: http://stardiviner.github.io/ On Mon, Nov 9, 2020 at 7:05 PM Jean Louis wrote: > * stardiviner [2020-11-09 03:25]: > > After waited some days, still no reponse, so I popup this email. > > Can some Org maintainer review my patch? Thanks. > > It does not changed org-contacts.el core logic. Just added a new link > type. > > Should be easy to review. > > If I may say, many people manage their contacts and it can be by > various ways, I am managing my contacts and by default use "contact:" > > I find it useful for people to leave "contact:" link free and not bind > it to org-contact package. > > Instead it is more pointful to make "org-contact:" link that > specificaly points to contacts for org-contact package. > > Just "org-contact:" instead of "contact:" > > --00000000000031a51905b3b66d4f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
You're right. Thanks for suggestion.<= br>
I attached new patch now.

[stardiviner]=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 <Hack this world!>=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 GPG key ID: 47C32433
IRC(freeenode): stardiviner = =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Twitter:=C2=A0 @numbchild
Key fi= ngerprint =3D 9BAA 92BC CDDD B9EF 3B36=C2=A0 CB99 B8C4 B8E5 47C3 2433
Bl= og: http://star= diviner.github.io/


On Mon, Nov 9, = 2020 at 7:05 PM Jean Louis <bugs@gnu.support> wrote:
* stardiviner <numbchild@gmail.com> [202= 0-11-09 03:25]:
> After waited some days, still no reponse, so I popup this email.
> Can some Org maintainer review my patch? Thanks.
> It does not changed org-contacts.el core logic. Just added a new link = type.
> Should be easy to review.

If I may say, many people manage their contacts and it can be by
various ways, I am managing my contacts and by default use "contact:&q= uot;

I find it useful for people to leave "contact:" link free and not= bind
it to org-contact package.

Instead it is more pointful to make "org-contact:" link that
specificaly points to contacts for org-contact package.

Just "org-contact:" instead of "contact:"

--00000000000031a51905b3b66d4f-- --00000000000031a51c05b3b66d51 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-org-contacts.el-Add-new-link-type-contact.patch" Content-Disposition: attachment; filename="0001-org-contacts.el-Add-new-link-type-contact.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_khba9dhc0 RnJvbSA3NDQ2YzBkZGE0OTU1NGRiMGFmMTg0MDE5ODRkMjBiOWI0NjBkNDA4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBzdGFyZGl2aW5lciA8bnVtYmNoaWxkQGdtYWlsLmNvbT4KRGF0 ZTogRnJpLCAzMCBPY3QgMjAyMCAxNToxMTo1MyArMDgwMApTdWJqZWN0OiBbUEFUQ0hdIG9yZy1j b250YWN0cy5lbDogQWRkIG5ldyBsaW5rIHR5cGUgImNvbnRhY3Q6IgoKKiBjb250cmliL2xpc3Av b3JnLWNvbnRhY3RzLmVsIChvcmctY29udGFjdHMtbGluay1zdG9yZSk6IFN0b3JlIGEgbGluawpv ZiBvcmctY29udGFjdHMgaW4gT3JnIGZpbGUuCgoqIGNvbnRyaWIvbGlzcC9vcmctY29udGFjdHMu ZWwgKG9yZy1jb250YWN0cy1saW5rLW9wZW4pOiBPcGVuIGNvbnRhY3Q6CmxpbmsgaW4gT3JnIGZp bGUuCgoqIGNvbnRyaWIvbGlzcC9vcmctY29udGFjdHMuZWwgKG9yZy1jb250YWN0cy1saW5rLWNv bXBsZXRlKTogSW5zZXJ0IGEKY29udGFjdDogbGluayB3aXRoIGNvbXBsZXRpb24gb2YgY29udGFj dHMuCgoqIGNvbnRyaWIvbGlzcC9vcmctY29udGFjdHMuZWwgKG9yZy1jb250YWN0cy1saW5rLWZh Y2UpOiBTZXQgZGlmZmVyZW50CmZhY2UgZm9yIGNvbnRhY3Q6IGxpbmsuCi0tLQogY29udHJpYi9s aXNwL29yZy1jb250YWN0cy5lbCB8IDc1ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKwogMSBmaWxlIGNoYW5nZWQsIDc1IGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9jb250 cmliL2xpc3Avb3JnLWNvbnRhY3RzLmVsIGIvY29udHJpYi9saXNwL29yZy1jb250YWN0cy5lbApp bmRleCA0YjM2OTNhMGUuLmQ4ZDQ5ODQyNSAxMDA2NDQKLS0tIGEvY29udHJpYi9saXNwL29yZy1j b250YWN0cy5lbAorKysgYi9jb250cmliL2xpc3Avb3JnLWNvbnRhY3RzLmVsCkBAIC0xMTQ2LDYg KzExNDYsODEgQEAgKGRlZnVuIG9yZy1jb250YWN0cy1zcGxpdC1wcm9wZXJ0eSAoc3RyaW5nICZv cHRpb25hbCBzZXBhcmF0b3JzIG9taXQtbnVsbHMpCiAgICAgICAgIChzZXRxIHByb3BsaXN0IChj b25zIGJ1ZmZlcnN0cmluZyBwcm9wbGlzdCkpKSkKICAgICAoY2RyIChyZXZlcnNlIHByb3BsaXN0 KSkpKQogCis7OzsgQWRkIGFuIE9yZyBsaW5rIHR5cGUgYG9yZy1jb250YWN0OicgZm9yIGVhc3kg anVtcCB0byBvciBzZWFyY2hpbmcgb3JnLWNvbnRhY3RzIGhlYWRsaW5lLgorOzs7IGxpbmsgc3Bl YzogW1tvcmctY29udGFjdDpxdWVyeV1bZGVzY11dCisob3JnLWxpbmstc2V0LXBhcmFtZXRlcnMg Im9yZy1jb250YWN0IgorCQkJIDpmb2xsb3cgJ29yZy1jb250YWN0cy1saW5rLW9wZW4KKwkJCSA6 Y29tcGxldGUgJ29yZy1jb250YWN0cy1saW5rLWNvbXBsZXRlCisJCQkgOnN0b3JlICdvcmctY29u dGFjdHMtbGluay1zdG9yZQorCQkJIDpmYWNlICdvcmctY29udGFjdHMtbGluay1mYWNlKQorCiso ZGVmdW4gb3JnLWNvbnRhY3RzLWxpbmstc3RvcmUgKCkKKyAgIlN0b3JlIHRoZSBjb250YWN0IGlu IGBvcmctY29udGFjdHMtZmlsZXMnIHdpdGggYSBsaW5rLiIKKyAgKHdoZW4gKGVxIG1ham9yLW1v ZGUgJ29yZy1tb2RlKQorICAgIDs7IChtZW1iZXIgKGJ1ZmZlci1maWxlLW5hbWUpIChtYXBjYXIg J2V4cGFuZC1maWxlLW5hbWUgb3JnLWNvbnRhY3RzLWZpbGVzKSkKKyAgICAobGV0ICgoaGVhZGxp bmUtc3RyIChzdWJzdHJpbmctbm8tcHJvcGVydGllcyAob3JnLWdldC1oZWFkaW5nIHQgdCB0IHQp KSkpCisgICAgICAob3JnLXN0b3JlLWxpbmstcHJvcHMKKyAgICAgICA6dHlwZSAib3JnLWNvbnRh Y3QiCisgICAgICAgOmxpbmsgaGVhZGxpbmUtc3RyCisgICAgICAgOmRlc2NyaXB0aW9uIGhlYWRs aW5lLXN0cikpKSkKKworKGRlZnVuIG9yZy1jb250YWN0cy0tYWxsLWNvbnRhY3RzICgpCisgICJS ZXR1cm4gYW4gYWxpc3QgKG5hbWUgLiAoZmlsZSAuIHBvc2l0aW9uKSkgb2YgYWxsIGNvbnRhY3Rz IGluIGBvcmctY29udGFjdHMtZmlsZXMnLiIKKyAgKGNhciAobWFwY2FyCisJKGxhbWJkYSAoZmls ZSkKKwkgICh1bmxlc3MgKGJ1ZmZlci1saXZlLXAgKGdldC1idWZmZXIgKGZpbGUtbmFtZS1ub25k aXJlY3RvcnkgZmlsZSkpKQorCSAgICAoZmluZC1maWxlIGZpbGUpKQorCSAgKHdpdGgtY3VycmVu dC1idWZmZXIgKGdldC1idWZmZXIgKGZpbGUtbmFtZS1ub25kaXJlY3RvcnkgZmlsZSkpCisJICAg IChvcmctbWFwLWVudHJpZXMKKwkgICAgIChsYW1iZGEgKCkKKwkgICAgICAgKGxldCAoKG5hbWUg KHN1YnN0cmluZy1uby1wcm9wZXJ0aWVzIChvcmctZ2V0LWhlYWRpbmcgdCB0IHQgdCkpKQorCQkg ICAgIChmaWxlIChidWZmZXItZmlsZS1uYW1lKSkKKwkJICAgICAocG9zaXRpb24gKHBvaW50KSkp CisJCSBgKDpuYW1lICxuYW1lIDpmaWxlICxmaWxlIDpwb3NpdGlvbiAscG9zaXRpb24pKSkpKSkK KwlvcmctY29udGFjdHMtZmlsZXMpKSkKKworKGRlZnVuIG9yZy1jb250YWN0cy1saW5rLW9wZW4g KHBhdGgpCisgICJPcGVuIGNvbnRhY3RzOiBsaW5rIHR5cGUgd2l0aCBqdW1waW5nIG9yIHNlYXJj aGluZy4iCisgIChsZXQgKChxdWVyeSBwYXRoKSkKKyAgICAoY29uZAorICAgICAoKHN0cmluZy1t YXRjaCAiLy4qLyIgcXVlcnkpCisgICAgICAobGV0KiAoKGYgKGNhciBvcmctY29udGFjdHMtZmls ZXMpKQorCSAgICAgKGJ1ZiAoZ2V0LWJ1ZmZlciAoZmlsZS1uYW1lLW5vbmRpcmVjdG9yeSBmKSkp KQorCSh1bmxlc3MgKGJ1ZmZlci1saXZlLXAgYnVmKSAoZmluZC1maWxlIGYpKQorCSh3aXRoLWN1 cnJlbnQtYnVmZmVyIGJ1ZgorCSAgKHN0cmluZy1tYXRjaCAiL1xcKC4qXFwpLyIgcXVlcnkpCisJ ICAob2NjdXIgKG1hdGNoLXN0cmluZyAxIHF1ZXJ5KSkpKSkKKyAgICAgKHQKKyAgICAgIChsZXQq ICgoZiAoY2FyIG9yZy1jb250YWN0cy1maWxlcykpCisJICAgICAoYnVmIChnZXQtYnVmZmVyIChm aWxlLW5hbWUtbm9uZGlyZWN0b3J5IGYpKSkpCisJKHVubGVzcyAoYnVmZmVyLWxpdmUtcCBidWYp IChmaW5kLWZpbGUgZikpCisJKHdpdGgtY3VycmVudC1idWZmZXIgYnVmCisJICAoZ290by1jaGFy IChtYXJrZXItcG9zaXRpb24gKG9yZy1maW5kLWV4YWN0LWhlYWRsaW5lLWluLWJ1ZmZlciBxdWVy eSkpKSkpCisgICAgICA7OyBGSVhNRQorICAgICAgOzsgKGxldCogKChjb250YWN0LWVudHJ5IChw bGlzdC1nZXQgKG9yZy1jb250YWN0cy0tYWxsLWNvbnRhY3RzKSBxdWVyeSkpCisgICAgICA7OyAJ ICAgICAoY29udGFjdC1uYW1lIChwbGlzdC1nZXQgY29udGFjdC1lbnRyeSA6bmFtZSkpCisgICAg ICA7OyAJICAgICAoZmlsZSAocGxpc3QtZ2V0IGNvbnRhY3QtZW50cnkgOmZpbGUpKQorICAgICAg OzsgCSAgICAgKHBvc2l0aW9uIChwbGlzdC1nZXQgY29udGFjdC1lbnRyeSA6cG9zaXRpb24pKQor ICAgICAgOzsgCSAgICAgKGJ1ZiAoZ2V0LWJ1ZmZlciAoZmlsZS1uYW1lLW5vbmRpcmVjdG9yeSBm aWxlKSkpKQorICAgICAgOzsgCSh1bmxlc3MgKGJ1ZmZlci1saXZlLXAgYnVmKSAoZmluZC1maWxl IGZpbGUpKQorICAgICAgOzsgCSh3aXRoLWN1cnJlbnQtYnVmZmVyIGJ1ZiAoZ290by1jaGFyIHBv c2l0aW9uKSkpCisgICAgICApKSkpCisKKyhkZWZ1biBvcmctY29udGFjdHMtbGluay1jb21wbGV0 ZSAoJm9wdGlvbmFsIGFyZykKKyAgIkNyZWF0ZSBhIG9yZy1jb250YWN0cyBsaW5rIHVzaW5nIGNv bXBsZXRpb24uIgorICAobGV0ICgobmFtZSAoY29tcGxldGluZy1yZWFkICJvcmctY29udGFjdCBO YW1lOiAiCisJCQkgICAgICAgKG1hcGNhcgorCQkJCShsYW1iZGEgKHBsaXN0KSAocGxpc3QtZ2V0 IHBsaXN0IDpuYW1lKSkKKwkJCQkob3JnLWNvbnRhY3RzLS1hbGwtY29udGFjdHMpKSkpKQorICAg IChjb25jYXQgIm9yZy1jb250YWN0OiIgbmFtZSkpKQorCisoZGVmdW4gb3JnLWNvbnRhY3RzLWxp bmstZmFjZSAocGF0aCkKKyAgIkRpZmZlcmVudCBmYWNlIGNvbG9yIGZvciBkaWZmZXJlbnQgb3Jn LWNvbnRhY3RzIGxpbmsgcXVlcnkuIgorICAoY29uZAorICAgKChzdHJpbmctbWF0Y2ggIi8uKi8i IHBhdGgpCisgICAgJyg6YmFja2dyb3VuZCAic2t5IGJsdWUiIDpvdmVybGluZSB0IDpzbGFudCAn aXRhbGljKSkKKyAgICh0ICcoOmJhY2tncm91bmQgImdyZWVuIHllbGxvdyIgOnVuZGVybGluZSB0 KSkpKQorCiAocHJvdmlkZSAnb3JnLWNvbnRhY3RzKQogCiA7Ozsgb3JnLWNvbnRhY3RzLmVsIGVu ZHMgaGVyZQotLSAKMi4yOS4yCgo= --00000000000031a51c05b3b66d51--