From: "numbchild@gmail.com" <numbchild@gmail.com>
To: Satoru KURASHIKI <lurdan@gmail.com>
Cc: emacs-org list <emacs-orgmode@gnu.org>
Subject: Re: Two ob-lua versions
Date: Wed, 14 Feb 2018 18:29:30 +0800 [thread overview]
Message-ID: <CAL1eYuL0P_dQtTGtb-PgM0O=qTgZv92X8=Cd0T1dpidjsptR6g@mail.gmail.com> (raw)
In-Reply-To: <CAL1eYuJvGrzhAmwhfCAJGDiTYQRJHew2zRZ=2cgV5e4srMAO1Q@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1952 bytes --]
I created a PR now https://code.orgmode.org/bzg/org-mode/pulls/4 . Really
sorry for this. @Nicolas , can you merge it now?
[stardiviner] <Hack this world!> GPG key ID: 47C32433
IRC(freeenode): stardiviner Twitter: @numbchild
Key fingerprint = 9BAA 92BC CDDD B9EF 3B36 CB99 B8C4 B8E5 47C3 2433
Blog: http://stardiviner.github.io/
On Wed, Feb 14, 2018 at 6:18 PM, numbchild@gmail.com <numbchild@gmail.com>
wrote:
> Hi, sorry for this. I have not noticed that. I will create an PR to remove
> my `ob-lua.el` as soon as fast.
>
> [stardiviner] <Hack this world!> GPG key ID: 47C32433
> IRC(freeenode): stardiviner Twitter: @numbchild
> Key fingerprint = 9BAA 92BC CDDD B9EF 3B36 CB99 B8C4 B8E5 47C3 2433
> Blog: http://stardiviner.github.io/
>
> On Wed, Feb 14, 2018 at 9:28 AM, Satoru KURASHIKI <lurdan@gmail.com>
> wrote:
>
>> hi,
>>
>> On Sun, Feb 11, 2018 at 6:22 PM, Nicolas Goaziou <mail@nicolasgoaziou.fr>
>> wrote:
>> > Hello,
>> >
>> > Thibault Marin <thibault.marin@gmx.com> writes:
>> >
>> >> I noticed that a recent change added an ob-lua.el file to
>> contrib/lisp/.
>> >> Since there is already an ob-lua.el in lisp/, I was wondering if the
>> new
>> >> version was adding functionality not supported by the one in lisp/ (it
>> >> does not seem to be the case on casual inspection) and if so, whether
>> >> they could/should be merged.
>> >
>> > I just realized that, too. It seems wrong. I'm Cc'ing stardiviner so we
>> > can have some insight about it.
>>
>> Anyway this breaks installation with package.el in org-plus-contrib case.
>> because of conflicting "ob-lua.el" filename.
>>
>> > stardiviner, would you mind explaining why you need to create an
>> > "ob-lua.el" library in "contrib/" ?
>>
>> It has to be fixed, so please revert that merge, until stardiviner will
>> notice
>> this thread and retry PR...
>>
>> regards,
>> --
>> KURASHIKI Satoru
>>
>>
>
[-- Attachment #2: Type: text/html, Size: 3701 bytes --]
prev parent reply other threads:[~2018-02-14 10:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-11 4:20 Two ob-lua versions Thibault Marin
2018-02-11 9:22 ` Nicolas Goaziou
2018-02-14 1:28 ` Satoru KURASHIKI
2018-02-14 10:18 ` numbchild
2018-02-14 10:29 ` numbchild [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL1eYuL0P_dQtTGtb-PgM0O=qTgZv92X8=Cd0T1dpidjsptR6g@mail.gmail.com' \
--to=numbchild@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=lurdan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).