From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id epHdDbj92l/6OQAA0tVLHw (envelope-from ) for ; Thu, 17 Dec 2020 06:42:00 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id GC6SCbj92l/SWgAAbx9fmQ (envelope-from ) for ; Thu, 17 Dec 2020 06:42:00 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7629F9404FD for ; Thu, 17 Dec 2020 06:41:59 +0000 (UTC) Received: from localhost ([::1]:59252 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kpmz6-00087p-PM for larch@yhetil.org; Thu, 17 Dec 2020 01:41:56 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:40280) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kpmxm-000831-8W for emacs-orgmode@gnu.org; Thu, 17 Dec 2020 01:40:38 -0500 Received: from mail-vs1-xe2b.google.com ([2607:f8b0:4864:20::e2b]:45966) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kpmxk-0005gA-0r; Thu, 17 Dec 2020 01:40:34 -0500 Received: by mail-vs1-xe2b.google.com with SMTP id e20so7651091vsr.12; Wed, 16 Dec 2020 22:40:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pR6WGEF7dQARBGgHOnzCHByucFzvbcpUuZf5BG7kZfY=; b=Jg/R8s6vvo4wUFo+n804B/VcyDoq4C6nky4rolzV8lcAyNMVLnG11Aw1hLgRoN0f5L h0MdWSWqIV/SWNoqq63hprnfuvp6i7mmBDlOSW8CVwA/K9lqmk6zSzolLQQ8F5ckxnAU CLnQ2n/DNBkTIf4bjGCaKy4Wb2dBGbUGC04pChW2F8w7FrgFCx9gJai2nDZ3A5Evk8b4 e0th/Yu4GSaZo5zGr7X+e2K2+rmRHfTz5Ij9ENd1v3nAP5n9i8oc5MZUeCDa9/2f1/l/ 1RHECb2oQSJtdvO8uqnN2WujmQNRqQB9xIXyy/oJQURM7V/WI1IyWy81V6Klyp3r5D27 SipQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pR6WGEF7dQARBGgHOnzCHByucFzvbcpUuZf5BG7kZfY=; b=VGU+cQ8pnLICCALsHNwmrH1MJ/iL0WOJ7E/UoSIa+YV+/8gaR/uK+WM41+dg9gBNmQ Q/bHS5iznq7x85WT+2K1XB9LJQODCQE13yN12cCHGZpctXVgGp+gixTJ/QGTzrRNvjyU LXJR4AJKFuennQsnMkx6htQ0mgYMBKwdoJfkJiJBU83Sji/xLQIW8cKsS479Bmi47p7u ChIMnOZw/3PBaER8m8i1i9qSa6Kyzz7eGO3qfCVefh5umIXArE5/4hawpyeU1yquSWCE ucq7rS4pruSC7rCq+/J2hhzqCWZER6EzogqucLMh5/kpUdsDTjfE91d0H5f8rMCk04rz vdUw== X-Gm-Message-State: AOAM530Wja+KInr2vawy6h8pgV9C9jmJAjtdCgmHAbfNS23QzTVBEG1o AfGmwV11WYxXornunwLdzQMMLrf+AyDbai0oiA== X-Google-Smtp-Source: ABdhPJzzX8I2oTw7h+i4384Ga5JJLQstnIgmxhLmO9nerP9ayrxRVx7okGJLow54ucYj7FP2hFDk2KVT+VBurofgTV0= X-Received: by 2002:a05:6102:4b6:: with SMTP id r22mr12707561vsa.41.1608187229868; Wed, 16 Dec 2020 22:40:29 -0800 (PST) MIME-Version: 1.0 References: <87zh2e5e7t.fsf@localhost> <87sg86uggl.fsf@gnu.org> <87sg855ct6.fsf@localhost> In-Reply-To: <87sg855ct6.fsf@localhost> From: stardiviner Date: Thu, 17 Dec 2020 14:40:03 +0800 Message-ID: Subject: Re: Bug: org-contacts.el: org-contacts-link-store breaks org-id [9.4.2 (release_9.4.2-307-g8840af @ /home/yantar92/.emacs.d/straight/build/org/)] To: Ihor Radchenko Content-Type: multipart/alternative; boundary="00000000000091984505b6a3442b" Received-SPF: pass client-ip=2607:f8b0:4864:20::e2b; envelope-from=numbchild@gmail.com; helo=mail-vs1-xe2b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bastien , Org-mode Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -3.01 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=Jg/R8s6v; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 7629F9404FD X-Spam-Score: -3.01 X-Migadu-Scanner: scn0.migadu.com X-TUID: 1hvVCqzIGYij --00000000000091984505b6a3442b Content-Type: text/plain; charset="UTF-8" Ok, I added `org-id-link-to-org-use-id` support now. Check out the latest update in Git. [stardiviner] GPG key ID: 47C32433 IRC(freeenode): stardiviner Twitter: @numbchild Key fingerprint = 9BAA 92BC CDDD B9EF 3B36 CB99 B8C4 B8E5 47C3 2433 Blog: http://stardiviner.github.io/ On Thu, Dec 17, 2020 at 11:26 AM Ihor Radchenko wrote: > > stardiviner writes: > > > Sure, I didn't expected that soon bug appears. I checked source code, I > > commented out an condition accidentally. > > Here is the patch. Tested it should work now. > > What about adding support for org-id? Is it necessary to use headline > text as a search string even when org-id is being used (and > org-id-link-to-org-use-id is set to non-nil)? > > Best, > Ihor > > --00000000000091984505b6a3442b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Ok, I added `org-id-link-to-org-use-id` support now. Check= out the latest update in Git.

[stardiviner]=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 <Hack this world!>=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 GPG key ID: 47C32433
IRC(freeenode): stardiviner =C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Twitter:=C2=A0 @numbchild
Key finge= rprint =3D 9BAA 92BC CDDD B9EF 3B36=C2=A0 CB99 B8C4 B8E5 47C3 2433
Blog:= http://stardiv= iner.github.io/


On Thu, Dec 17, 20= 20 at 11:26 AM Ihor Radchenko <yan= tar92@gmail.com> wrote:

stardiviner <nu= mbchild@gmail.com> writes:

> Sure, I didn't expected that soon bug appears. I checked source co= de, I
> commented out an condition accidentally.
> Here is the patch. Tested it should work now.

What about adding support for org-id? Is it necessary to use headline
text as a search string even when org-id is being used (and
org-id-link-to-org-use-id is set to non-nil)?

Best,
Ihor

--00000000000091984505b6a3442b--