From mboxrd@z Thu Jan 1 00:00:00 1970 From: "numbchild@gmail.com" Subject: Re: a patch to ob-lisp.el Date: Wed, 6 Apr 2016 13:54:03 +0800 Message-ID: References: <874mbtz0pb.fsf@gmail.com> <87oa9zxnbp.fsf@pierrot.dokosmarshall.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a1141eea48adf10052fca98f2 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:56073) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1angQF-0006QJ-Bo for emacs-orgmode@gnu.org; Wed, 06 Apr 2016 01:54:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1angQD-0005vH-OU for emacs-orgmode@gnu.org; Wed, 06 Apr 2016 01:54:35 -0400 Received: from mail-yw0-x22a.google.com ([2607:f8b0:4002:c05::22a]:35543) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1angQD-0005vB-I2 for emacs-orgmode@gnu.org; Wed, 06 Apr 2016 01:54:33 -0400 Received: by mail-yw0-x22a.google.com with SMTP id i84so37854189ywc.2 for ; Tue, 05 Apr 2016 22:54:33 -0700 (PDT) In-Reply-To: List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: "Thomas S. Dye" Cc: Nick Dokos , Org-mode --001a1141eea48adf10052fca98f2 Content-Type: text/plain; charset=UTF-8 My think my patch modifies less than 15 lines. Do I have to assign the copyright of FSF? I have sent one. But no response for some days. I hope Org-mode maintainer can merge this patch. [stardiviner] GPG key ID: 47C32433 IRC(freeenode): stardiviner Twitter: @numbchild Key fingerprint = 9BAA 92BC CDDD B9EF 3B36 CB99 B8C4 B8E5 47C3 2433 Blog: http://stardiviner.github.io/ On Thu, Mar 31, 2016 at 12:52 AM, Thomas S. Dye wrote: > Aloha stardiviner, > > For instructions about the FSF papers, see > http://orgmode.org/worg/org-contribute.html. > > All the best, > Tom > > numbchild@gmail.com writes: > > > I updated all comments which you point out. > > I wandering how to sign the FSF papers? Sorry about this, this is my > first time > > to contribute code in open source. > > > > > > > > [stardiviner] GPG key ID: 47C32433 > > IRC(freeenode): stardiviner Twitter: @numbchild > > Key fingerprint = 9BAA 92BC CDDD B9EF 3B36 CB99 B8C4 B8E5 47C3 2433 > > Blog: http://stardiviner.github.io/ > > > > On Mon, Mar 28, 2016 at 12:01 PM, Nick Dokos wrote: > > > > stardiviner writes: > > > > > I hope to merge this patch to Org-mode `ob-lisp.el`. > > > > > > > I have only looked at the surface of it, but I see some issues. > > > > > < ;; Copyright (C) 2016-2020 Free Software Foundation, Inc. > > > --- > > > > ;; Copyright (C) 2009-2016 Free Software Foundation, Inc. > > > > Why did you leave out the previous copyright statement? > > Where did 2020 come from? > > > > > < ;; Authors: stardiviner > > > < ;; Maintainer: stardiviner > > > < ;; Keywords: org babel lisp sly slime > > > < ;; URL: https://github.com/stardiviner/ob-lisp > > > < ;; Created: 1th March 2016 > > > < ;; Version: 0.0.1 > > > < ;; Package-Requires: ((org "8")) > > > --- > > >> ;; Authors: Joel Boehland > > >> ;; Eric Schulte > > >> ;; David T. O'Toole > > >> ;; Keywords: literate programming, reproducible research > > >> ;; Homepage: http://orgmode.org > > > > Why did you erase the previous authors? > > > > Are you volunteering to be the maintainer of ob-lisp.el or are you > > planning to keep your own repo and submit patches? Have you signed > FSF > > papers? > > > > > < ;; Requires SLY (Sylvester the Cat's Common Lisp IDE) and SLIME > > > < ;; See: > > > < ;; - https://github.com/capitaomorte/sly > > > < ;; - http://common-lisp.net/project/slime/ > > > --- > > >> ;; Requires SLIME (Superior Lisp Interaction Mode for Emacs.) > > >> ;; See http://common-lisp.net/project/slime/ > > > > Does it really require both? If so, I suggest you rework it so > > either can be used, but only one is required. If not, I suggest > > you fix the comment. > > > > -- > > Nick > > > -- > Thomas S. Dye > http://www.tsdye.com > --001a1141eea48adf10052fca98f2 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
My think my patch modifies less than 15 lines. Do I have t= o assign the copyright of FSF?
I have sent one. But no response for so= me days. I hope Org-mode maintainer can merge this patch.

=
[stardiviner]=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 <Hack this world!>=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 GPG key ID: 47C32433
IRC(freeenode): stardiviner = =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Twitter:=C2=A0 @numbchild
Key fi= ngerprint =3D 9BAA 92BC CDDD B9EF 3B36=C2=A0 CB99 B8C4 B8E5 47C3 2433
Bl= og: http://star= diviner.github.io/

On Thu, Mar 31, 2016 at 12:52 AM, Thomas S. = Dye <tsd@tsdye.com> wrote:
Alo= ha stardiviner,

For instructions about the FSF papers, see
http://orgmode.org/worg/org-contribute.html.

All the best,
Tom

numbchild@gmail.com writes:

> I updated all comments which you point out.
> I wandering how to sign the FSF papers? Sorry about this, this is my f= irst time
> to contribute code in open source.
>
>
>
> [stardiviner] <Hack this world!> GPG key ID: 47C32433
> IRC(freeenode): stardiviner=C2=A0 Twitter: @numbchild
> Key fingerprint =3D 9BAA 92BC CDDD B9EF 3B36 CB99 B8C4 B8E5 47C3 2433<= br> > Blog: http://stardiviner.github.io/
>
> On Mon, Mar 28, 2016 at 12:01 PM, Nick Dokos <ndokos@gmail.com> wrote:
>
>=C2=A0 =C2=A0 =C2=A0stardiviner <numbchild@gmail.com> writes:
>
>=C2=A0 =C2=A0 =C2=A0> I hope to merge this patch to Org-mode `ob-lis= p.el`.
>=C2=A0 =C2=A0 =C2=A0>
>
>=C2=A0 =C2=A0 =C2=A0I have only looked at the surface of it, but I see = some issues.
>
>=C2=A0 =C2=A0 =C2=A0> < ;; Copyright (C) 2016-2020 Free Software = Foundation, Inc.
>=C2=A0 =C2=A0 =C2=A0> ---
>=C2=A0 =C2=A0 =C2=A0> > ;; Copyright (C) 2009-2016 Free Software = Foundation, Inc.
>
>=C2=A0 =C2=A0 =C2=A0Why did you leave out the previous copyright statem= ent?
>=C2=A0 =C2=A0 =C2=A0Where did 2020 come from?
>
>=C2=A0 =C2=A0 =C2=A0> < ;; Authors: stardiviner <numbchild@gmail.com>
>=C2=A0 =C2=A0 =C2=A0> < ;; Maintainer: stardiviner <numbchild@gmail.com>
>=C2=A0 =C2=A0 =C2=A0> < ;; Keywords: org babel lisp sly slime
>=C2=A0 =C2=A0 =C2=A0> < ;; URL: https://github.com/s= tardiviner/ob-lisp
>=C2=A0 =C2=A0 =C2=A0> < ;; Created: 1th March 2016
>=C2=A0 =C2=A0 =C2=A0> < ;; Version: 0.0.1
>=C2=A0 =C2=A0 =C2=A0> < ;; Package-Requires: ((org "8")= )
>=C2=A0 =C2=A0 =C2=A0> ---
>=C2=A0 =C2=A0 =C2=A0>> ;; Authors: Joel Boehland
>=C2=A0 =C2=A0 =C2=A0>> ;;=C2=A0 Eric Schulte
>=C2=A0 =C2=A0 =C2=A0>> ;;=C2=A0 David T. O'Toole <dto@gnu.org>
>=C2=A0 =C2=A0 =C2=A0>> ;; Keywords: literate programming, reprodu= cible research
>=C2=A0 =C2=A0 =C2=A0>> ;; Homepage: http://orgmode.org
>
>=C2=A0 =C2=A0 =C2=A0Why did you erase the previous authors?
>
>=C2=A0 =C2=A0 =C2=A0Are you volunteering to be the maintainer of ob-lis= p.el or are you
>=C2=A0 =C2=A0 =C2=A0planning to keep your own repo and submit patches? = Have you signed FSF
>=C2=A0 =C2=A0 =C2=A0papers?
>
>=C2=A0 =C2=A0 =C2=A0> < ;; Requires SLY (Sylvester the Cat's = Common Lisp IDE) and SLIME
>=C2=A0 =C2=A0 =C2=A0> < ;; See:
>=C2=A0 =C2=A0 =C2=A0> < ;; - https://github.com/capitao= morte/sly
>=C2=A0 =C2=A0 =C2=A0> < ;; - http://common-lisp.net/p= roject/slime/
>=C2=A0 =C2=A0 =C2=A0> ---
>=C2=A0 =C2=A0 =C2=A0>> ;; Requires SLIME (Superior Lisp Interacti= on Mode for Emacs.)
>=C2=A0 =C2=A0 =C2=A0>> ;; See http://common-lisp.net/= project/slime/
>
>=C2=A0 =C2=A0 =C2=A0Does it really require both? If so, I suggest you r= ework it so
>=C2=A0 =C2=A0 =C2=A0either can be used, but only one is required. If no= t, I suggest
>=C2=A0 =C2=A0 =C2=A0you fix the comment.
>
>=C2=A0 =C2=A0 =C2=A0--
>=C2=A0 =C2=A0 =C2=A0Nick


--
Thomas S. Dye
http:= //www.tsdye.com

--001a1141eea48adf10052fca98f2--