From mboxrd@z Thu Jan 1 00:00:00 1970 From: "numbchild@gmail.com" Subject: Re: Two ob-lua versions Date: Wed, 14 Feb 2018 18:18:26 +0800 Message-ID: References: <87eflsduo9.fsf@dell-desktop.WORKGROUP> <877erjdgom.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="001a113727866092bd056529706f" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:58002) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1elu9T-0005rW-Er for emacs-orgmode@gnu.org; Wed, 14 Feb 2018 05:19:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1elu9S-0008J1-20 for emacs-orgmode@gnu.org; Wed, 14 Feb 2018 05:18:59 -0500 Received: from mail-ot0-x22d.google.com ([2607:f8b0:4003:c0f::22d]:41653) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1elu9R-0008Ho-TS for emacs-orgmode@gnu.org; Wed, 14 Feb 2018 05:18:58 -0500 Received: by mail-ot0-x22d.google.com with SMTP id w38so1871671ota.8 for ; Wed, 14 Feb 2018 02:18:57 -0800 (PST) In-Reply-To: List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Satoru KURASHIKI Cc: emacs-org list --001a113727866092bd056529706f Content-Type: text/plain; charset="UTF-8" Hi, sorry for this. I have not noticed that. I will create an PR to remove my `ob-lua.el` as soon as fast. [stardiviner] GPG key ID: 47C32433 IRC(freeenode): stardiviner Twitter: @numbchild Key fingerprint = 9BAA 92BC CDDD B9EF 3B36 CB99 B8C4 B8E5 47C3 2433 Blog: http://stardiviner.github.io/ On Wed, Feb 14, 2018 at 9:28 AM, Satoru KURASHIKI wrote: > hi, > > On Sun, Feb 11, 2018 at 6:22 PM, Nicolas Goaziou > wrote: > > Hello, > > > > Thibault Marin writes: > > > >> I noticed that a recent change added an ob-lua.el file to contrib/lisp/. > >> Since there is already an ob-lua.el in lisp/, I was wondering if the new > >> version was adding functionality not supported by the one in lisp/ (it > >> does not seem to be the case on casual inspection) and if so, whether > >> they could/should be merged. > > > > I just realized that, too. It seems wrong. I'm Cc'ing stardiviner so we > > can have some insight about it. > > Anyway this breaks installation with package.el in org-plus-contrib case. > because of conflicting "ob-lua.el" filename. > > > stardiviner, would you mind explaining why you need to create an > > "ob-lua.el" library in "contrib/" ? > > It has to be fixed, so please revert that merge, until stardiviner will > notice > this thread and retry PR... > > regards, > -- > KURASHIKI Satoru > > --001a113727866092bd056529706f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi, sorry for this. I have not noticed that. I will cr= eate an PR to remove my `ob-lua.el` as soon as fast.

[s= tardiviner]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 <= ;Hack this world!>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 GPG key ID: 47C32433IRC(freeenode): stardiviner =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Twitt= er:=C2=A0 @numbchild
Key fingerprint =3D 9BAA 92BC CDDD B9EF 3B36=C2=A0 = CB99 B8C4 B8E5 47C3 2433
Blog: http://stardiviner.github.io/
<= /div>

On Wed, Feb 14, 2018 at 9:28 AM, Satoru KURA= SHIKI <lurdan@gmail.com> wrote:
hi,

On Sun, Feb 11, 2018 at 6:22 PM, Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
> Hello,
>
> Thibault Marin <thibault.= marin@gmx.com> writes:
>
>> I noticed that a recent change added an ob-lua.el file to contrib/= lisp/.
>> Since there is already an ob-lua.el in lisp/, I was wondering if t= he new
>> version was adding functionality not supported by the one in lisp/= (it
>> does not seem to be the case on casual inspection) and if so, whet= her
>> they could/should be merged.
>
> I just realized that, too. It seems wrong. I'm Cc'ing stardivi= ner so we
> can have some insight about it.

Anyway this breaks installation with package.el in org-plus-contrib = case.
because of conflicting "ob-lua.el" filename.

> stardiviner, would you mind explaining why you need to create an
> "ob-lua.el" library in "contrib/" ?

It has to be fixed, so please revert that merge, until stardiviner w= ill notice
this thread and retry PR...

regards,
--
KURASHIKI Satoru


--001a113727866092bd056529706f--