From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id gMmKNcml2l+4BAAA0tVLHw (envelope-from ) for ; Thu, 17 Dec 2020 00:26:49 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id uLFfMcml2l8FYwAA1q6Kng (envelope-from ) for ; Thu, 17 Dec 2020 00:26:49 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1DD19940438 for ; Thu, 17 Dec 2020 00:26:49 +0000 (UTC) Received: from localhost ([::1]:57902 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kph82-0002So-NY for larch@yhetil.org; Wed, 16 Dec 2020 19:26:46 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:60952) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kph7d-0002Sh-GV for emacs-orgmode@gnu.org; Wed, 16 Dec 2020 19:26:21 -0500 Received: from mail-ua1-x92f.google.com ([2607:f8b0:4864:20::92f]:38847) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kph7b-0004ZY-Jo; Wed, 16 Dec 2020 19:26:21 -0500 Received: by mail-ua1-x92f.google.com with SMTP id y26so8611401uan.5; Wed, 16 Dec 2020 16:26:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Pfbkwk2RbsXof8gla/hcgBJrbTfDPnYg+5wqnLHbbgM=; b=ZyzQa2RFR7Wxr1M7DMkPF7NblTX2aAXqVE1n4CZjCLBBg5nzQQCPo2vDeOV9YOCvs6 sbNWQu+Teo7HaM5JplC1e9KfXvB6jo/PpMKpjq1dStTuMeYH46u4ENvI6iE9uEZtcYzY WCD5dXrnt13NLrGrrQyIz1IkP0rDAZKt0hwCwPa2o5pe1uqrIeOJPePlgE0Yw0/xBZhQ xA6tFH0PAZePxQwbhtN25rHGIEYuLjz10w5TfBYkMRjJ56Qbxv4FhqOkTk/EywrkfLVY 3GNOj/hCNtt/cwiDVDupz4E9K37ZG2n0KQL6j6drFCxb2Fy3c01SmRROE37gI/yh/L7j 8ItQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Pfbkwk2RbsXof8gla/hcgBJrbTfDPnYg+5wqnLHbbgM=; b=bGbAowBQ0br/g3tTZxbhOTD7/K2A4Uvw8x/IEFsyyAujJHHpYGn0wp6lMz19vng+yi 4Pi2RFh9WjdHpGj5tYfULslHGPnB9GH+FwNupEVGwtUfwHP2wLww3w0ConkTyvX7TOHF S68DvRChWvyGpjP7B9feI9YRf7tg0iv16kD+PToqmpVijmg7IQwd/i3nLQW3MdquNJcx 8gLDBRuK4BJF1EBEiqx2rOGRSgvaTzsR5nxXdjSRtRz00jsbB92JiS4Y2lXK1lNZu5UO F2nToxEVfr493mF1y5E7iVvhD8eydylQ/9qkvQQYunP7JvbJZa1nbKXYpQCqXXIycVc5 p62w== X-Gm-Message-State: AOAM533WonQAFQmRjz/QkmsDf60PKPAa17/ElqrMz5jYDIZb/58Bmt3y 398rrvzA1JN7XOJbB3JFAt37oDJQOQhpoxe4VQof24zj5w== X-Google-Smtp-Source: ABdhPJw2dF7Jj2wrVqSKGqfiPA88UVTL5prx3yMQOU4usHnE9cRcw/IbTlkZn4yauk3Xd1FQJjKczD3IxPLAf37zUcw= X-Received: by 2002:ab0:32cb:: with SMTP id f11mr33434380uao.109.1608164777725; Wed, 16 Dec 2020 16:26:17 -0800 (PST) MIME-Version: 1.0 References: <87zh2e5e7t.fsf@localhost> <87sg86uggl.fsf@gnu.org> In-Reply-To: <87sg86uggl.fsf@gnu.org> From: stardiviner Date: Thu, 17 Dec 2020 08:25:50 +0800 Message-ID: Subject: Re: Bug: org-contacts.el: org-contacts-link-store breaks org-id [9.4.2 (release_9.4.2-307-g8840af @ /home/yantar92/.emacs.d/straight/build/org/)] To: Bastien Content-Type: multipart/mixed; boundary="00000000000051345a05b69e0a96" Received-SPF: pass client-ip=2607:f8b0:4864:20::92f; envelope-from=numbchild@gmail.com; helo=mail-ua1-x92f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Org-mode , Ihor Radchenko Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -0.11 Authentication-Results: aspmx1.migadu.com; dkim=fail (body hash did not verify) header.d=gmail.com header.s=20161025 header.b=ZyzQa2RF; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 1DD19940438 X-Spam-Score: -0.11 X-Migadu-Scanner: scn0.migadu.com X-TUID: VDHAyG9JFRv/ --00000000000051345a05b69e0a96 Content-Type: multipart/alternative; boundary="00000000000051345705b69e0a94" --00000000000051345705b69e0a94 Content-Type: text/plain; charset="UTF-8" Sure, I didn't expected that soon bug appears. I checked source code, I commented out an condition accidentally. Here is the patch. Tested it should work now. [stardiviner] GPG key ID: 47C32433 IRC(freeenode): stardiviner Twitter: @numbchild Key fingerprint = 9BAA 92BC CDDD B9EF 3B36 CB99 B8C4 B8E5 47C3 2433 Blog: http://stardiviner.github.io/ On Wed, Dec 16, 2020 at 7:40 PM Bastien wrote: > Hi, > > Ihor Radchenko writes: > > > When using org-contacts and org-id simultaneously, org-contacts > > unconditionally makes org-store-link use file:name.org:*Headline link > > style instead of id:UUID link style expected when using org-id. The > > problem does not only appears when storing links to contact.org > > headlines, but for any headlines. > > > > Probably, org-contacts should be integrated with org-id or at least not > > interfere with links to ordinary headlines. > > Agreed. Stardiviner, can you have a look? > > Thanks, > > -- > Bastien > --00000000000051345705b69e0a94 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Sure, I didn't expected that soon bug appears. I check= ed source code, I commented out an condition accidentally.
Here is th= e patch. Tested it should work now.

<= div dir=3D"ltr" class=3D"gmail_signature" data-smartmail=3D"gmail_signature= ">
[stardiviner]=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 <Hack this world!>=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 GPG key ID: 47C32433
IRC(freeenode): stardiviner = =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Twitter:=C2=A0 @numbchild
Key fi= ngerprint =3D 9BAA 92BC CDDD B9EF 3B36=C2=A0 CB99 B8C4 B8E5 47C3 2433
Bl= og: http://star= diviner.github.io/


On Wed, Dec 16,= 2020 at 7:40 PM Bastien <bzg@gnu.org= > wrote:
Hi,<= br>
Ihor Radchenko <= yantar92@gmail.com> writes:

> When using org-contacts and org-id simultaneously, org-contacts
> unconditionally makes org-store-link use file:name.org:*Headline link<= br> > style instead of id:UUID link style expected when using org-id. The > problem does not only appears when storing links to contact.org
> headlines, but for any headlines.
>
> Probably, org-contacts should be integrated with org-id or at least no= t
> interfere with links to ordinary headlines.

Agreed.=C2=A0 Stardiviner, can you have a look?

Thanks,

--
=C2=A0Bastien
--00000000000051345705b69e0a94-- --00000000000051345a05b69e0a96 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-org-contacts-Fix-org-store-link-error-caused-by-org-.patch" Content-Disposition: attachment; filename="0001-org-contacts-Fix-org-store-link-error-caused-by-org-.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kis3ro4w0 RnJvbSBkYjMzOTI0Yjk0MzlhNWE3ODdiMzBlOTg1Y2YwMDViYTExMzQ3NjQyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBzdGFyZGl2aW5lciA8bnVtYmNoaWxkQGdtYWlsLmNvbT4KRGF0 ZTogVGh1LCAxNyBEZWMgMjAyMCAwODoxOTozNSArMDgwMApTdWJqZWN0OiBbUEFUQ0hdIG9yZy1j b250YWN0czogRml4IG9yZy1zdG9yZS1saW5rIGVycm9yIGNhdXNlZCBieQogb3JnLWNvbnRhY3Rz LWxpbmstc3RvcmUKCiogY29udHJpYi9saXNwL29yZy1jb250YWN0cy5lbCAob3JnLWNvbnRhY3Rz LWxpbmstc3RvcmUpOiBGaXggT3JnIHN0b3JlCmxpbmsgYnkgYWRkaW5nIG1pc3NpbmcgY29uZGl0 aW9uIGZvciBvcmctY29udGFjdHMuCi0tLQogY29udHJpYi9saXNwL29yZy1jb250YWN0cy5lbCB8 IDQgKystLQogMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkK CmRpZmYgLS1naXQgYS9jb250cmliL2xpc3Avb3JnLWNvbnRhY3RzLmVsIGIvY29udHJpYi9saXNw L29yZy1jb250YWN0cy5lbAppbmRleCAzMTAxNjZkNTMuLjQ0YmE0NTVjNCAxMDA2NDQKLS0tIGEv Y29udHJpYi9saXNwL29yZy1jb250YWN0cy5lbAorKysgYi9jb250cmliL2xpc3Avb3JnLWNvbnRh Y3RzLmVsCkBAIC0xMTU3LDggKzExNTcsOCBAQCAob3JnLWxpbmstc2V0LXBhcmFtZXRlcnMgIm9y Zy1jb250YWN0IgogCiAoZGVmdW4gb3JnLWNvbnRhY3RzLWxpbmstc3RvcmUgKCkKICAgIlN0b3Jl IHRoZSBjb250YWN0IGluIGBvcmctY29udGFjdHMtZmlsZXMnIHdpdGggYSBsaW5rLiIKLSAgKHdo ZW4gKGVxIG1ham9yLW1vZGUgJ29yZy1tb2RlKQotICAgIDs7IChtZW1iZXIgKGJ1ZmZlci1maWxl LW5hbWUpIChtYXBjYXIgJ2V4cGFuZC1maWxlLW5hbWUgb3JnLWNvbnRhY3RzLWZpbGVzKSkKKyAg KHdoZW4gKGFuZCAoZXEgbWFqb3ItbW9kZSAnb3JnLW1vZGUpCisJICAgICAobWVtYmVyIChidWZm ZXItZmlsZS1uYW1lKSAobWFwY2FyICdleHBhbmQtZmlsZS1uYW1lIG9yZy1jb250YWN0cy1maWxl cykpKQogICAgIChsZXQgKChoZWFkbGluZS1zdHIgKHN1YnN0cmluZy1uby1wcm9wZXJ0aWVzIChv cmctZ2V0LWhlYWRpbmcgdCB0IHQgdCkpKSkKICAgICAgIChvcmctc3RvcmUtbGluay1wcm9wcwog ICAgICAgIDp0eXBlICJvcmctY29udGFjdCIKLS0gCjIuMjkuMgoK --00000000000051345a05b69e0a96--