From mboxrd@z Thu Jan 1 00:00:00 1970 From: "numbchild@gmail.com" Subject: add some babel supports (PHP, Lua, Redis) Date: Tue, 10 May 2016 16:07:22 +0800 Message-ID: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a113d4946f48ba20532786b8e Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:42562) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b02hv-00048p-Dh for emacs-orgmode@gnu.org; Tue, 10 May 2016 04:07:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b02hs-0005DU-Un for emacs-orgmode@gnu.org; Tue, 10 May 2016 04:07:54 -0400 Received: from mail-yw0-x233.google.com ([2607:f8b0:4002:c05::233]:34202) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b02hs-0005D3-QJ for emacs-orgmode@gnu.org; Tue, 10 May 2016 04:07:52 -0400 Received: by mail-yw0-x233.google.com with SMTP id j74so4528475ywg.1 for ; Tue, 10 May 2016 01:07:52 -0700 (PDT) List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Org-mode --001a113d4946f48ba20532786b8e Content-Type: text/plain; charset=UTF-8 I created three branches on my personal public org-mode repo on GitHub. - ob-lua - ob-php - ob-redis https://github.com/stardiviner/org-mode Hope maintainer can merge those branches. [stardiviner] GPG key ID: 47C32433 IRC(freeenode): stardiviner Twitter: @numbchild Key fingerprint = 9BAA 92BC CDDD B9EF 3B36 CB99 B8C4 B8E5 47C3 2433 Blog: http://stardiviner.github.io/ --001a113d4946f48ba20532786b8e Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
I created three branches on my personal public o= rg-mode repo on GitHub.

- ob-lua
- ob-php
- ob-redis


Hope maintainer can merge those branches.

[stardiviner]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 <Hack this world!>=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 GPG key ID: 47C32433
IRC(freeenode): stardiviner =C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Twitter:=C2=A0 @numbchild
Key fingerprint= =3D 9BAA 92BC CDDD B9EF 3B36=C2=A0 CB99 B8C4 B8E5 47C3 2433
Blog: http://stardiviner.g= ithub.io/
--001a113d4946f48ba20532786b8e-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rasmus Subject: Re: add some babel supports (PHP, Lua, Redis) Date: Tue, 10 May 2016 11:42:06 +0200 Message-ID: <87mvnydzbl.fsf@gmx.us> References: Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:40249) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b04BT-0003s4-QM for emacs-orgmode@gnu.org; Tue, 10 May 2016 05:42:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b04BN-0003Z4-GX for emacs-orgmode@gnu.org; Tue, 10 May 2016 05:42:30 -0400 Received: from plane.gmane.org ([80.91.229.3]:49007) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b04BN-0003YX-5R for emacs-orgmode@gnu.org; Tue, 10 May 2016 05:42:25 -0400 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1b04BL-0003pa-KQ for emacs-orgmode@gnu.org; Tue, 10 May 2016 11:42:23 +0200 Received: from 46.189.28.86 ([46.189.28.86]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 10 May 2016 11:42:23 +0200 Received: from rasmus by 46.189.28.86 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 10 May 2016 11:42:23 +0200 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: emacs-orgmode@gnu.org Hi, Thanks for your patches. Some comments follow. "numbchild@gmail.com" writes: > - ob-lua > - ob-php > - ob-redis > > https://github.com/stardiviner/org-mode > > Hope maintainer can merge those branches. First, do you have copyright assignment to the FSF or would you be willing to? This is necessary to merge the patches. Please refer to, http://orgmode.org/worg/org-contribute.html Second, could you send your work as patches? I.e. use git format-patch. Note the format of the commit message should be in the ChangeLog format (refer to the link above). Thanks, Rasmus -- History is what should never happen again From mboxrd@z Thu Jan 1 00:00:00 1970 From: "numbchild@gmail.com" Subject: Re: add some babel supports (PHP, Lua, Redis) Date: Tue, 10 May 2016 23:23:50 +0800 Message-ID: References: <87mvnydzbl.fsf@gmx.us> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=001a113dd1fee4b88405327e840c Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:41929) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b09WJ-0007Vz-Li for emacs-orgmode@gnu.org; Tue, 10 May 2016 11:24:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b09WH-0001bm-JM for emacs-orgmode@gnu.org; Tue, 10 May 2016 11:24:23 -0400 Received: from mail-yw0-x241.google.com ([2607:f8b0:4002:c05::241]:33154) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b09WH-0001bT-DE for emacs-orgmode@gnu.org; Tue, 10 May 2016 11:24:21 -0400 Received: by mail-yw0-x241.google.com with SMTP id y6so1322325ywe.0 for ; Tue, 10 May 2016 08:24:21 -0700 (PDT) In-Reply-To: <87mvnydzbl.fsf@gmx.us> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Rasmus Cc: Org-mode --001a113dd1fee4b88405327e840c Content-Type: multipart/alternative; boundary=001a113dd1fee4b87d05327e840a --001a113dd1fee4b87d05327e840a Content-Type: text/plain; charset=UTF-8 I tried to sign the FSF copyright assignment before, but it is very difficult for me. So I give up. Is there other ways to merge this patches without signing the assignment? (I can give up this right) Second: I updated branch commit messages in the ChangeLog format. [stardiviner] GPG key ID: 47C32433 IRC(freeenode): stardiviner Twitter: @numbchild Key fingerprint = 9BAA 92BC CDDD B9EF 3B36 CB99 B8C4 B8E5 47C3 2433 Blog: http://stardiviner.github.io/ On Tue, May 10, 2016 at 5:42 PM, Rasmus wrote: > Hi, > > Thanks for your patches. > > Some comments follow. > > "numbchild@gmail.com" writes: > > > - ob-lua > > - ob-php > > - ob-redis > > > > https://github.com/stardiviner/org-mode > > > > Hope maintainer can merge those branches. > > First, do you have copyright assignment to the FSF or would you be willing > to? This is necessary to merge the patches. Please refer to, > > http://orgmode.org/worg/org-contribute.html > > Second, could you send your work as patches? I.e. use git format-patch. > Note the format of the commit message should be in the ChangeLog format > (refer to the link above). > > Thanks, > Rasmus > > -- > History is what should never happen again > > > --001a113dd1fee4b87d05327e840a Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
I tried to sign the FSF copyright assignment before, but i= t is very difficult for me. So I give up. Is there other ways to merge this= patches without signing the assignment? (I can give up this right)
Second: I updated branch commit messages in the ChangeLog format.

[stardiviner]=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 <Hack this world!= >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 GPG key ID: 47C32433
IRC(freeenode): = stardiviner =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Twitter:=C2=A0 @numbchi= ld
Key fingerprint =3D 9BAA 92BC CDDD B9EF 3B36=C2=A0 CB99 B8C4 B8E5 47C= 3 2433
Blog: http://stardiviner.github.io/

On Tue, May 10, 2016 at 5:42 PM, Rasmus <rasmus= @gmx.us> wrote:
Hi,

Thanks for your patches.

Some comments follow.

"numbchild@gmail.com" = <numbchild@gmail.com> writ= es:

> - ob-lua
> - ob-php
> - ob-redis
>
> https://github.com/stardiviner/org-mode
>
> Hope maintainer can merge those branches.

First, do you have copyright assignment to the FSF or would you be w= illing
to?=C2=A0 This is necessary to merge the patches.=C2=A0 Please refer to,
=C2=A0 =C2=A0 =C2=A0 http://orgmode.org/worg/org-contribu= te.html

Second, could you send your work as patches?=C2=A0 I.e. use git format-patc= h.
Note the format of the commit message should be in the ChangeLog format
(refer to the link above).

Thanks,
Rasmus

--
History is what should never happen again



--001a113dd1fee4b87d05327e840a-- --001a113dd1fee4b88405327e840c Content-Type: text/x-patch; charset=US-ASCII; name="0001-ob-lua.el-add-Lua-src-block-executing-support.patch" Content-Disposition: attachment; filename="0001-ob-lua.el-add-Lua-src-block-executing-support.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_io1lpzgc0 RnJvbSAyNTg5ZDRlN2QyODAxNmZiNTE1ZDIxMzFjYmQ5ZmY1Mjc5N2U1MGViIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBzdGFyZGl2aW5lciA8bnVtYmNoaWxkQGdtYWlsLmNvbT4KRGF0 ZTogVHVlLCAxMCBNYXkgMjAxNiAxNjowMzozMiArMDgwMApTdWJqZWN0OiBbUEFUQ0hdIG9iLWx1 YS5lbDogYWRkIEx1YSBzcmMgYmxvY2sgZXhlY3V0aW5nIHN1cHBvcnQKCiogY29udHJpYi9saXNw L29iLWx1YS5lbCAob3JnLWJhYmVsLWV4ZWN1dGU6bHVhKTogc3VwcG9ydCBleGVjdXRpbmcgTHVh IHNyYyBibG9jay4KLS0tCiBjb250cmliL2xpc3Avb2ItbHVhLmVsIHwgNDUgKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCiAxIGZpbGUgY2hhbmdlZCwgNDUgaW5z ZXJ0aW9ucygrKQogY3JlYXRlIG1vZGUgMTAwNjQ0IGNvbnRyaWIvbGlzcC9vYi1sdWEuZWwKCmRp ZmYgLS1naXQgYS9jb250cmliL2xpc3Avb2ItbHVhLmVsIGIvY29udHJpYi9saXNwL29iLWx1YS5l bApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi5mMzMwOTBlCi0tLSAvZGV2L251 bGwKKysrIGIvY29udHJpYi9saXNwL29iLWx1YS5lbApAQCAtMCwwICsxLDQ1IEBACis7Ozsgb2It bHVhLmVsIC0tLSBFeGVjdXRlIEx1YSBjb2RlIHdpdGhpbiBvcmctbW9kZSBibG9ja3MuCis7OyBD b3B5cmlnaHQgMjAxNiBzdGFyZGl2aW5lcgorCis7OyBBdXRob3I6IHN0YXJkaXZpbmVyIDxudW1i Y2hpbGRAZ21haWwuY29tPgorOzsgTWFpbnRhaW5lcjogc3RhcmRpdmluZXIgPG51bWJjaGlsZEBn bWFpbC5jb20+Cis7OyBLZXl3b3Jkczogb3JnIGJhYmVsIGx1YQorOzsgVVJMOiBodHRwczovL2dp dGh1Yi5jb20vc3RhcmRpdmluZXIvb2ItbHVhCis7OyBDcmVhdGVkOiAxMnRoIEFwcmlsIDIwMTYK Kzs7IFZlcnNpb246IDAuMC4xCis7OyBQYWNrYWdlLVJlcXVpcmVzOiAoKG9yZyAiOCIpKQorCis7 OzsgQ29tbWVudGFyeToKKzs7Cis7OyBFeGVjdXRlIEx1YSBjb2RlIHdpdGhpbiBvcmctbW9kZSBi bG9ja3MuCisKKzs7OyBDb2RlOgorKHJlcXVpcmUgJ29yZykKKyhyZXF1aXJlICdvYikKKworKGRl Zmdyb3VwIG9iLWx1YSBuaWwKKyAgIm9yZy1tb2RlIGJsb2NrcyBmb3IgTHVhLiIKKyAgOmdyb3Vw ICdvcmcpCisKKyhkZWZjdXN0b20gb2ItbHVhOmRlZmF1bHQtc2Vzc2lvbiAiKmx1YSoiCisgICJE ZWZhdWx0IEx1YSBzZXNzaW9uLgorCitJdCBpcyBsdWEgaW5mZXJpb3IgcHJvY2VzcyBmcm9tIGBy dW4tbHVhJy4iCisgIDpncm91cCAnb2ItbHVhCisgIDp0eXBlICdzdHJpbmcpCisKKzs7OyMjI2F1 dG9sb2FkCisoZGVmdW4gb3JnLWJhYmVsLWV4ZWN1dGU6bHVhIChib2R5IHBhcmFtcykKKyAgIm9y Zy1iYWJlbCBsdWEgaG9vay4iCisgIChsZXQqICgoc2Vzc2lvbiAob3IgKGNkciAoYXNzb2MgOnNl c3Npb24gcGFyYW1zKSkKKyAgICAgICAgICAgICAgICAgICAgICBvYi1sdWE6ZGVmYXVsdC1zZXNz aW9uKSkKKyAgICAgICAgIChjbWQgKG1hcGNvbmNhdCAnaWRlbnRpdHkgKGxpc3QgImx1YSAtIikg IiAiKSkpCisgICAgKG9yZy1iYWJlbC1ldmFsIGNtZCBib2R5KSkpCisKKzs7OyMjI2F1dG9sb2Fk CisoZXZhbC1hZnRlci1sb2FkICJvcmciCisgICcoYWRkLXRvLWxpc3QgJ29yZy1zcmMtbGFuZy1t b2RlcyAnKCJsdWEiIC4gbHVhKSkpCisKKyhwcm92aWRlICdvYi1sdWEpCisKKzs7OyBvYi1sdWEu ZWwgZW5kcyBoZXJlCi0tIAoyLjguMgoK --001a113dd1fee4b88405327e840c Content-Type: text/x-patch; charset=US-ASCII; name="0001-ob-php.el-Add-PHP-src-block-executing-support.patch" Content-Disposition: attachment; filename="0001-ob-php.el-Add-PHP-src-block-executing-support.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_io1lqmh71 RnJvbSBkMmU3MjAyOTMwZmNmMjRlN2M5MDgyNmU2OWJiNzY4MDk0NDYzYTBjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBzdGFyZGl2aW5lciA8bnVtYmNoaWxkQGdtYWlsLmNvbT4KRGF0 ZTogVHVlLCAxMCBNYXkgMjAxNiAxNjowNTozOCArMDgwMApTdWJqZWN0OiBbUEFUQ0hdIG9iLXBo cC5lbDogQWRkIFBIUCBzcmMgYmxvY2sgZXhlY3V0aW5nIHN1cHBvcnQKCiogY29udHJpYi9saXNw L29iLXBocC5lbCAob3JnLWJhYmVsLWV4ZWN1dGU6cGhwKTogc3VwcG9ydCBleGVjdXRpbmcgUEhQ CiAgc3JjIGJsb2NrLgotLS0KIGNvbnRyaWIvbGlzcC9vYi1waHAuZWwgfCA0NCArKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwogMSBmaWxlIGNoYW5nZWQsIDQ0IGlu c2VydGlvbnMoKykKIGNyZWF0ZSBtb2RlIDEwMDY0NCBjb250cmliL2xpc3Avb2ItcGhwLmVsCgpk aWZmIC0tZ2l0IGEvY29udHJpYi9saXNwL29iLXBocC5lbCBiL2NvbnRyaWIvbGlzcC9vYi1waHAu ZWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uMzE5NjBhNQotLS0gL2Rldi9u dWxsCisrKyBiL2NvbnRyaWIvbGlzcC9vYi1waHAuZWwKQEAgLTAsMCArMSw0NCBAQAorOzs7IG9i LXBocC5lbCAtLS0gRXhlY3V0ZSBQSFAgd2l0aGluIG9yZy1tb2RlIGJsb2Nrcy4KKzs7IENvcHly aWdodCAyMDE2IHN0YXJkaXZpbmVyCisKKzs7IEF1dGhvcjogc3RhcmRpdmluZXIgPG51bWJjaGls ZEBnbWFpbC5jb20+Cis7OyBNYWludGFpbmVyOiBzdGFyZGl2aW5lciA8bnVtYmNoaWxkQGdtYWls LmNvbT4KKzs7IEtleXdvcmRzOiBvcmcgYmFiZWwgcGhwCis7OyBVUkw6IGh0dHBzOi8vZ2l0aHVi LmNvbS9zdGFyZGl2aW5lci9vYi1waHAKKzs7IENyZWF0ZWQ6IDA0dGggTWF5IDIwMTYKKzs7IFZl cnNpb246IDAuMC4xCis7OyBQYWNrYWdlLVJlcXVpcmVzOiAoKG9yZyAiOCIpKQorCis7OzsgQ29t bWVudGFyeToKKzs7Cis7OyBFeGVjdXRlIFBIUCB3aXRoaW4gb3JnLW1vZGUgYmxvY2tzLgorCis7 OzsgQ29kZToKKyhyZXF1aXJlICdvcmcpCisocmVxdWlyZSAnb2IpCisKKyhkZWZncm91cCBvYi1w aHAgbmlsCisgICJvcmctbW9kZSBibG9ja3MgZm9yIFBIUC4iCisgIDpncm91cCAnb3JnKQorCis7 OyB0b2RvCisoZGVmY3VzdG9tIG9iLXBocDppbmYtcGhwLWJ1ZmZlciAiKnBocCoiCisgICJEZWZh dWx0IFBIUCBpbmZlcmlvciBidWZmZXIuIgorICA6Z3JvdXAgJ29iLXBocAorICA6dHlwZSAnc3Ry aW5nKQorCis7OzsjIyNhdXRvbG9hZAorKGRlZnVuIG9yZy1iYWJlbC1leGVjdXRlOnBocCAoYm9k eSBwYXJhbXMpCisgICJvcmctYmFiZWwgUEhQIGhvb2suIgorICA7OyB0b2RvCisgIChsZXQqICgo Y21kIChtYXBjb25jYXQgJ2lkZW50aXR5IChsaXN0ICJwaHAiKSAiIC1yICIpKSkKKyAgICAob3Jn LWJhYmVsLWV2YWwgY21kIGJvZHkpCisgICAgKSkKKworOzs7IyMjYXV0b2xvYWQKKyhldmFsLWFm dGVyLWxvYWQgIm9yZyIKKyAgJyhhZGQtdG8tbGlzdCAnb3JnLXNyYy1sYW5nLW1vZGVzICcoInBo cCIgLiBwaHApKSkKKworKHByb3ZpZGUgJ29iLXBocCkKKworOzs7IG9iLXBocC5lbCBlbmRzIGhl cmUKLS0gCjIuOC4yCgo= --001a113dd1fee4b88405327e840c Content-Type: text/x-patch; charset=US-ASCII; name="0001-ob-redis.el-Add-Redis-src-block-executing-support.patch" Content-Disposition: attachment; filename="0001-ob-redis.el-Add-Redis-src-block-executing-support.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_io1lr68r2 RnJvbSBlYjNjMGNiMTQ2NzQxNmQxNDFhNjMzYzQ5ZTFjOTA1MDMxMWQ5MmFiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBzdGFyZGl2aW5lciA8bnVtYmNoaWxkQGdtYWlsLmNvbT4KRGF0 ZTogVHVlLCAxMCBNYXkgMjAxNiAxNjowNjoxOSArMDgwMApTdWJqZWN0OiBbUEFUQ0hdIG9iLXJl ZGlzLmVsOiBBZGQgUmVkaXMgc3JjIGJsb2NrIGV4ZWN1dGluZyBzdXBwb3J0CgoqIGNvbnRyaWIv bGlzcC9vYi1yZWRpcy5lbCAob3JnLWJhYmVsLWV4ZWN1dGU6cmVkaXMpOiBzdXBwb3J0IGZvcgog IGV4ZWN1dGluZyByZWRpcyBzcmMgYmxvY2suCi0tLQogY29udHJpYi9saXNwL29iLXJlZGlzLmVs IHwgNDQgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysKIDEgZmls ZSBjaGFuZ2VkLCA0NCBpbnNlcnRpb25zKCspCiBjcmVhdGUgbW9kZSAxMDA2NDQgY29udHJpYi9s aXNwL29iLXJlZGlzLmVsCgpkaWZmIC0tZ2l0IGEvY29udHJpYi9saXNwL29iLXJlZGlzLmVsIGIv Y29udHJpYi9saXNwL29iLXJlZGlzLmVsCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAw MDAuLjM0MGIwNTAKLS0tIC9kZXYvbnVsbAorKysgYi9jb250cmliL2xpc3Avb2ItcmVkaXMuZWwK QEAgLTAsMCArMSw0NCBAQAorOzs7IG9iLXJlZGlzLmVsIC0tLSBFeGVjdXRlIFJlZGlzIHF1ZXJp ZXMgd2l0aGluIG9yZy1tb2RlIGJsb2Nrcy4KKzs7IENvcHlyaWdodCAyMDE2IHN0YXJkaXZpbmVy CisKKzs7IEF1dGhvcjogc3RhcmRpdmluZXIgPG51bWJjaGlsZEBnbWFpbC5jb20+Cis7OyBNYWlu dGFpbmVyOiBzdGFyZGl2aW5lciA8bnVtYmNoaWxkQGdtYWlsLmNvbT4KKzs7IEtleXdvcmRzOiBv cmcgYmFiZWwgcmVkaXMKKzs7IFVSTDogaHR0cHM6Ly9naXRodWIuY29tL3N0YXJkaXZpbmVyL29i LXJlZGlzCis7OyBDcmVhdGVkOiAyOHRoIEZlYiAyMDE2Cis7OyBWZXJzaW9uOiAwLjAuMQorOzsg UGFja2FnZS1SZXF1aXJlczogKChvcmcgIjgiKSkKKworOzs7IENvbW1lbnRhcnk6Cis7OworOzsg RXhlY3V0ZSBSZWRpcyBxdWVyaWVzIHdpdGhpbiBvcmctbW9kZSBibG9ja3MuCisKKzs7OyBDb2Rl OgorKHJlcXVpcmUgJ29yZykKKyhyZXF1aXJlICdvYikKKworKGRlZmdyb3VwIG9iLXJlZGlzIG5p bAorICAib3JnLW1vZGUgYmxvY2tzIGZvciBSZWRpcy4iCisgIDpncm91cCAnb3JnKQorCisoZGVm Y3VzdG9tIG9iLXJlZGlzOmRlZmF1bHQtZGIgIjEyNy4wLjAuMTo2Mzc5IgorICAiRGVmYXVsdCBS ZWRpcyBkYXRhYmFzZS4iCisgIDpncm91cCAnb2ItcmVkaXMKKyAgOnR5cGUgJ3N0cmluZykKKwor Ozs7IyMjYXV0b2xvYWQKKyhkZWZ1biBvcmctYmFiZWwtZXhlY3V0ZTpyZWRpcyAoYm9keSBwYXJh bXMpCisgICJvcmctYmFiZWwgcmVkaXMgaG9vay4iCisgIChsZXQqICgoZGIgKG9yIChjZHIgKGFz c29jIDpkYiBwYXJhbXMpKQorICAgICAgICAgICAgICAgICBvYi1yZWRpczpkZWZhdWx0LWRiKSkK KyAgICAgICAgIChjbWQgKG1hcGNvbmNhdCAnaWRlbnRpdHkgKGxpc3QgInJlZGlzLWNsaSIpICIg IikpKQorICAgIChvcmctYmFiZWwtZXZhbCBjbWQgYm9keSkKKyAgICApKQorCis7OzsjIyNhdXRv bG9hZAorKGV2YWwtYWZ0ZXItbG9hZCAib3JnIgorICAnKGFkZC10by1saXN0ICdvcmctc3JjLWxh bmctbW9kZXMgJygicmVkaXMiIC4gcmVkaXMpKSkKKworKHByb3ZpZGUgJ29iLXJlZGlzKQorCis7 Ozsgb2ItcmVkaXMuZWwgZW5kcyBoZXJlCi0tIAoyLjguMgoK --001a113dd1fee4b88405327e840c-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rasmus Subject: Re: add some babel supports (PHP, Lua, Redis) Date: Tue, 10 May 2016 17:44:28 +0200 Message-ID: <87zirx534z.fsf@gmx.us> References: <87mvnydzbl.fsf@gmx.us> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:48686) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b09pu-0006GS-Bl for emacs-orgmode@gnu.org; Tue, 10 May 2016 11:44:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b09pp-0007aS-Ua for emacs-orgmode@gnu.org; Tue, 10 May 2016 11:44:38 -0400 Received: from mout.gmx.net ([212.227.15.15]:49250) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b09pp-0007Zk-3w for emacs-orgmode@gnu.org; Tue, 10 May 2016 11:44:33 -0400 In-Reply-To: (numbchild@gmail.com's message of "Tue, 10 May 2016 23:23:50 +0800") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: numbchild@gmail.com Cc: emacs-orgmode@gnu.org "numbchild@gmail.com" writes: > I tried to sign the FSF copyright assignment before, but it is very > difficult for me. So I give up. Is there other ways to merge this patches > without signing the assignment? (I can give up this right) Normally you "only" need to sign a piece of paper and send it by snail mail to the FSF office in the US of A. But you may be referring to the terms of the assignment. Depending on the issues you faced, it might be best to discuss them with assign@gnu.org, who will have the legal knowledge to give you proper advice. Meanwhile, your files could be added to contrib, which does not require you to do the paperwork. Contrib files are not part of Emacs and would not come as part of the default Org package. To me, Contrib is more convenient than MELPA, but I=E2=80=99m not sure everyone would agree. > Second: I updated branch commit messages in the ChangeLog format. Thanks.=20 Rasmus --=20 However beautiful the theory, one should occasionally look at the evidence From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ken Mankoff Subject: Re: add some babel supports (PHP, Lua, Redis) Date: Tue, 10 May 2016 11:47:14 -0400 Message-ID: References: <87mvnydzbl.fsf@gmx.us> <87zirx534z.fsf@gmx.us> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:49885) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b09sa-0002Am-Ig for emacs-orgmode@gnu.org; Tue, 10 May 2016 11:47:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b09sW-00005a-21 for emacs-orgmode@gnu.org; Tue, 10 May 2016 11:47:23 -0400 Received: from mail-qg0-x233.google.com ([2607:f8b0:400d:c04::233]:35285) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b09sV-00005L-Ni for emacs-orgmode@gnu.org; Tue, 10 May 2016 11:47:19 -0400 Received: by mail-qg0-x233.google.com with SMTP id f74so8666153qge.2 for ; Tue, 10 May 2016 08:47:19 -0700 (PDT) In-reply-to: <87zirx534z.fsf@gmx.us> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Rasmus Cc: emacs-orgmode@gnu.org On 2016-05-10 at 11:44, Rasmus wrote: > "numbchild@gmail.com" writes: > > Normally you "only" need to sign a piece of paper and send it by snail > mail to the FSF office in the US of A. It is easier than this - it can be done via email. Print sign and scan (photograph w/ phone), or don't even print and just sign digitally. -k. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rasmus Subject: Re: add some babel supports (PHP, Lua, Redis) Date: Tue, 10 May 2016 17:58:13 +0200 Message-ID: <87r3d952i2.fsf@gmx.us> References: <87mvnydzbl.fsf@gmx.us> <87zirx534z.fsf@gmx.us> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:57708) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b0A51-0000yf-VH for emacs-orgmode@gnu.org; Tue, 10 May 2016 12:00:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b0A4v-0005gK-9L for emacs-orgmode@gnu.org; Tue, 10 May 2016 12:00:14 -0400 Received: from plane.gmane.org ([80.91.229.3]:46367) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b0A4v-0005f0-1G for emacs-orgmode@gnu.org; Tue, 10 May 2016 12:00:09 -0400 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1b0A4q-0001Ul-9n for emacs-orgmode@gnu.org; Tue, 10 May 2016 18:00:04 +0200 Received: from 46.189.28.86 ([46.189.28.86]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 10 May 2016 18:00:04 +0200 Received: from rasmus by 46.189.28.86 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 10 May 2016 18:00:04 +0200 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: emacs-orgmode@gnu.org Ken Mankoff writes: > On 2016-05-10 at 11:44, Rasmus wrote: >> "numbchild@gmail.com" writes: >> >> Normally you "only" need to sign a piece of paper and send it by snail >> mail to the FSF office in the US of A. > > It is easier than this - it can be done via email. Print sign and scan > (photograph w/ phone), or don't even print and just sign digitally. Isn’t this only available to residents of the USA? Maybe not. It would be cool if it’s generally available now. Rasmus -- And when I’m finished thinking, I have to die a lot From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ken Mankoff Subject: Re: add some babel supports (PHP, Lua, Redis) Date: Tue, 10 May 2016 12:12:56 -0400 Message-ID: References: <87mvnydzbl.fsf@gmx.us> <87zirx534z.fsf@gmx.us> <87r3d952i2.fsf@gmx.us> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:34342) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b0AHQ-0004Y1-HT for emacs-orgmode@gnu.org; Tue, 10 May 2016 12:13:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b0AHM-0001IQ-65 for emacs-orgmode@gnu.org; Tue, 10 May 2016 12:13:03 -0400 Received: from mail-qk0-x230.google.com ([2607:f8b0:400d:c09::230]:36363) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b0AHM-0001IF-1P for emacs-orgmode@gnu.org; Tue, 10 May 2016 12:13:00 -0400 Received: by mail-qk0-x230.google.com with SMTP id x7so9510546qkd.3 for ; Tue, 10 May 2016 09:13:00 -0700 (PDT) In-reply-to: <87r3d952i2.fsf@gmx.us> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Rasmus Cc: emacs-orgmode@gnu.org On 2016-05-10 at 11:58, Rasmus wrote: > Ken Mankoff writes: > >> On 2016-05-10 at 11:44, Rasmus wrote: >>> "numbchild@gmail.com" writes: >>> >>> Normally you "only" need to sign a piece of paper and send it by >>> snail mail to the FSF office in the US of A. >> >> It is easier than this - it can be done via email. Print sign and >> scan (photograph w/ phone), or don't even print and just sign >> digitally. > > Isn’t this only available to residents of the USA? Maybe not. It would > be cool if it’s generally available now. Hm. I don't know. It didn't occur to me that the signature process was different based on where someone lives, but that may be the case. -k. From mboxrd@z Thu Jan 1 00:00:00 1970 From: "numbchild@gmail.com" Subject: Re: add some babel supports (PHP, Lua, Redis) Date: Wed, 11 May 2016 09:42:11 +0800 Message-ID: References: <87mvnydzbl.fsf@gmx.us> <87zirx534z.fsf@gmx.us> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a113d49463ac4bf053287288e Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:55524) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b0JAi-0003e6-1v for emacs-orgmode@gnu.org; Tue, 10 May 2016 21:42:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b0JAf-0001DQ-99 for emacs-orgmode@gnu.org; Tue, 10 May 2016 21:42:42 -0400 Received: from mail-yw0-x231.google.com ([2607:f8b0:4002:c05::231]:36526) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b0JAf-0001DM-2U for emacs-orgmode@gnu.org; Tue, 10 May 2016 21:42:41 -0400 Received: by mail-yw0-x231.google.com with SMTP id o66so33147407ywc.3 for ; Tue, 10 May 2016 18:42:40 -0700 (PDT) In-Reply-To: <87zirx534z.fsf@gmx.us> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Rasmus Cc: Org-mode --001a113d49463ac4bf053287288e Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable I moved files to contrib/lisp/. I live in China, hope FSF can assign the copyright assignment digitally. [stardiviner] GPG key ID: 47C32433 IRC(freeenode): stardiviner Twitter: @numbchild Key fingerprint =3D 9BAA 92BC CDDD B9EF 3B36 CB99 B8C4 B8E5 47C3 2433 Blog: http://stardiviner.github.io/ On Tue, May 10, 2016 at 11:44 PM, Rasmus wrote: > "numbchild@gmail.com" writes: > > > I tried to sign the FSF copyright assignment before, but it is very > > difficult for me. So I give up. Is there other ways to merge this patch= es > > without signing the assignment? (I can give up this right) > > Normally you "only" need to sign a piece of paper and send it by snail > mail to the FSF office in the US of A. But you may be referring to the > terms of the assignment. > > Depending on the issues you faced, it might be best to discuss them with > assign@gnu.org, who will have the legal knowledge to give you proper > advice. > > Meanwhile, your files could be added to contrib, which does not require > you to do the paperwork. Contrib files are not part of Emacs and would > not come as part of the default Org package. To me, Contrib is more > convenient than MELPA, but I=E2=80=99m not sure everyone would agree. > > > Second: I updated branch commit messages in the ChangeLog format. > > Thanks. > > Rasmus > -- > However beautiful the theory, one should occasionally look at the evidenc= e > --001a113d49463ac4bf053287288e Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
I moved files to contrib/lisp/. I live in China, hope FSF = can assign the copyright assignment digitally.

[stardiviner]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0 <Hack this world!>=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 GPG key ID: 47C32433
IRC(freeenode): stardiviner =C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0 Twitter:=C2=A0 @numbchild
Key fingerprint = =3D 9BAA 92BC CDDD B9EF 3B36=C2=A0 CB99 B8C4 B8E5 47C3 2433
Blog: http://stardiviner.gi= thub.io/

On Tue, May 10, 2016 at 11:44 PM, Rasmus <rasmu= s@gmx.us> wrote:
"numbchild@gmail.com" <numbchild@gmail.com= > writes:

> I tried to sign the FSF copyright assignment before, but it is very > difficult for me. So I give up. Is there other ways to merge this patc= hes
> without signing the assignment? (I can give up this right)

Normally you "only" need to sign a piece of paper and send= it by snail
mail to the FSF office in the US of A.=C2=A0 But you may be referring to th= e
terms of the assignment.

Depending on the issues you faced, it might be best to discuss them with assign@gnu.org, who will have the leg= al knowledge to give you proper
advice.

Meanwhile, your files could be added to contrib, which does not require
you to do the paperwork.=C2=A0 Contrib files are not part of Emacs and woul= d
not come as part of the default Org package.=C2=A0 To me, Contrib is more convenient than MELPA, but I=E2=80=99m not sure everyone would agree.

> Second: I updated branch commit messages in the ChangeLog format.

Thanks.

Rasmus
--
However beautiful the theory, one should occasionally look at the evidence<= br>

--001a113d49463ac4bf053287288e-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rasmus Subject: Re: add some babel supports (PHP, Lua, Redis) Date: Sun, 22 May 2016 19:20:13 +0200 Message-ID: <87ziri9fhu.fsf@gmx.us> References: <87mvnydzbl.fsf@gmx.us> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:36250) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b4X3L-0005q5-TK for emacs-orgmode@gnu.org; Sun, 22 May 2016 13:20:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b4X3F-0001UK-Pd for emacs-orgmode@gnu.org; Sun, 22 May 2016 13:20:34 -0400 Received: from plane.gmane.org ([80.91.229.3]:42717) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b4X3F-0001UG-El for emacs-orgmode@gnu.org; Sun, 22 May 2016 13:20:29 -0400 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1b4X3B-0004yM-4D for emacs-orgmode@gnu.org; Sun, 22 May 2016 19:20:25 +0200 Received: from ip-178-203-232-158.hsi10.unitymediagroup.de ([178.203.232.158]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 22 May 2016 19:20:25 +0200 Received: from rasmus by ip-178-203-232-158.hsi10.unitymediagroup.de with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 22 May 2016 19:20:25 +0200 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: emacs-orgmode@gnu.org Hi, Thanks for your patches. Sorry about the delay. I was hoping that someone with more ob knowledge would step in. Please find some comments below. I think some more work is needed before your libraries are "numbchild@gmail.com" writes: > From 2589d4e7d28016fb515d2131cbd9ff52797e50eb Mon Sep 17 00:00:00 2001 > From: stardiviner > Date: Tue, 10 May 2016 16:03:32 +0800 > Subject: [PATCH] ob-lua.el: add Lua src block executing support > > * contrib/lisp/ob-lua.el (org-babel-execute:lua): support executing Lua > src block. Please capitalize after the colon. > --- > +;;; ob-lua.el --- Execute Lua code within org-mode blocks. > +;; Copyright 2016 stardiviner > +;; Author: stardiviner > +;; Maintainer: stardiviner > +;; Keywords: org babel lua For whatever reason this seems to be ;; Keywords: literate programming, reproducible research In most ob files. > +;; URL: https://github.com/stardiviner/ob-lua > +;; Created: 12th April 2016 This header is unnecessary, but if you like it, it’s fine. > +;; Version: 0.0.1 > +;; Package-Requires: ((org "8")) > +;;; Commentary: > +;; > +;; Execute Lua code within org-mode blocks. Maybe, The file provides Org-Babel support for evaluating Lua code. > +;;; Code: > +(require 'org) This is unnecessary. Ob implies Org. > +(require 'ob) > + > +(defgroup ob-lua nil > + "org-mode blocks for Lua." > + :group 'org) It seems that ob languages do not typically define new groups. Also, ob is the filename. Variables are org-babel. > +(defcustom ob-lua:default-session "*lua*" > + "Default Lua session. > + > +It is lua inferior process from `run-lua'." > + :group 'ob-lua > + :type 'string) I don’t think this is necessary to have as a defcustom. There’s already :session. Also, you are missing :type. Per above, group is org-babel. > +;;;###autoload This is normally not autoloaded. Babel languages are loaded via org-babel-do-load-languages. > +(defun org-babel-execute:lua (body params) > + "org-babel lua hook." Please capitalize sentences. > + (let* ((session (or (cdr (assoc :session params)) > + ob-lua:default-session)) > + (cmd (mapconcat 'identity (list "lua -") " "))) Is something missing here? AFAIK cmd → "lua -" always. Also, what if my lua is not in my PATH? I got a felling that you might make a more robust mode by hooking into lua-mode https://immerrr.github.io/lua-mode/ > + (org-babel-eval cmd body))) How are various return values handled? E.g. will a table be correctly interpreted as such? (It’s a while since I coded in lua). > +;;;###Autoload > +(eval-after-load "org" > + '(add-to-list 'org-src-lang-modes '("lua" . lua))) This should be unnecessary as the lua-mode is presumably lua-mode. Also, I think your code depends on lua-mode in order to be able to edit it. You need to declare that as a dependency. > +(provide 'ob-lua) > + > +;;; ob-lua.el ends here > -- > 2.8.2 > > > From d2e7202930fcf24e7c90826e69bb768094463a0c Mon Sep 17 00:00:00 2001 > From: stardiviner > Date: Tue, 10 May 2016 16:05:38 +0800 > Subject: [PATCH] ob-php.el: Add PHP src block executing support > > * contrib/lisp/ob-php.el (org-babel-execute:php): support executing PHP > src block. Capitalize. > --- > contrib/lisp/ob-php.el | 44 ++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 44 insertions(+) > create mode 100644 contrib/lisp/ob-php.el > > diff --git a/contrib/lisp/ob-php.el b/contrib/lisp/ob-php.el > new file mode 100644 > index 0000000..31960a5 > --- /dev/null > +++ b/contrib/lisp/ob-php.el > @@ -0,0 +1,44 @@ > +;;; ob-php.el --- Execute PHP within org-mode blocks. > +;; Copyright 2016 stardiviner > + > +;; Author: stardiviner > +;; Maintainer: stardiviner > +;; Keywords: org babel php > +;; URL: https://github.com/stardiviner/ob-php > +;; Created: 04th May 2016 > +;; Version: 0.0.1 > +;; Package-Requires: ((org "8")) > + > +;;; Commentary: > +;; > +;; Execute PHP within org-mode blocks. > + > +;;; Code: > +(require 'org) > +(require 'ob) > + > +(defgroup ob-php nil > + "org-mode blocks for PHP." > + :group 'org) See comments above. > +;; Todo Remove. > +(defcustom ob-php:inf-php-buffer "*php*" > + "Default PHP inferior buffer." > + :group 'ob-php > + :type 'string) :Type is missing and this buffer should not be a defcustom. > +;;;###Autoload Remove. > +(defun org-babel-execute:php (body params) > + "org-babel PHP hook." > + ;; Todo Remove. > + (let* ((cmd (mapconcat 'identity (list "php") " -r "))) > + (org-babel-eval cmd body) > + )) See comments above re docstring, and robustness. What sort of return values can I expect from this? I don’t know php, but I assume it’s mainly "log messages". > +;;;###autoload > +(eval-after-load "org" > + '(add-to-list 'org-src-lang-modes '("php" . php))) Unnecessary. Also, it seems there’s an undeclared decency on some sort of php mode. > + > +(provide 'ob-php) > From eb3c0cb1467416d141a633c49e1c9050311d92ab Mon Sep 17 00:00:00 2001 > From: stardiviner > Date: Tue, 10 May 2016 16:06:19 +0800 > Subject: [PATCH] ob-redis.el: Add Redis src block executing support > > * contrib/lisp/ob-redis.el (org-babel-execute:redis): support for > executing redis src block. Capitalize > --- > contrib/lisp/ob-redis.el | 44 ++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 44 insertions(+) > create mode 100644 contrib/lisp/ob-redis.el > > diff --git a/contrib/lisp/ob-redis.el b/contrib/lisp/ob-redis.el > new file mode 100644 > index 0000000..340b050 > --- /dev/null > +++ b/contrib/lisp/ob-redis.el > @@ -0,0 +1,44 @@ > +;;; ob-redis.el --- Execute Redis queries within org-mode blocks. > +;; Copyright 2016 stardiviner > + > +;; Author: stardiviner > +;; Maintainer: stardiviner > +;; Keywords: org babel redis > +;; URL: https://github.com/stardiviner/ob-redis > +;; Created: 28th Feb 2016 > +;; Version: 0.0.1 > +;; Package-Requires: ((org "8")) > + > +;;; Commentary: > +;; > +;; Execute Redis queries within org-mode blocks. > + > +;;; Code: > +(require 'org) > +(require 'ob) > + > +(defgroup ob-redis nil > + "org-mode blocks for Redis." > + :group 'org) As above. > +(defcustom ob-redis:default-db "127.0.0.1:6379" > + "Default Redis database." > + :group 'ob-redis > + :type 'string) Does redis support login and different ports and all that jazz? If so, please compare the configurability to the needs of ob-sql. Is it possible to extend ob-sql with another engine? (I don’t know anything about redis). Or are these "NoSQL" databases similar enough that it would be possible to have "unite" them in a single library. Does ob have support for any "NoSQL" databases ATM? I’m not implying that this is necessarily the right way to go. I’m just trying to understand the nature of this. > +;;;###Autoload Remove. > +(defun org-babel-execute:redis (body params) > + "org-babel redis hook." > + (let* ((db (or (cdr (assoc :db params)) > + ob-redis:default-db)) > + (cmd (mapconcat 'identity (list "redis-cli") " "))) > + (org-babel-eval cmd body) > + )) My guess is that connectivity support is not comprehensive enough. > +;;;###autoload > +(eval-after-load "org" > + '(add-to-list 'org-src-lang-modes '("redis" . redis))) Remove. > +(provide 'ob-redis) > + > +;;; ob-redis.el ends here Thanks, Rasmus -- Vote for proprietary math! From mboxrd@z Thu Jan 1 00:00:00 1970 From: "numbchild@gmail.com" Subject: Re: add some babel supports (PHP, Lua, Redis) Date: Mon, 23 May 2016 11:09:29 +0800 Message-ID: References: <87mvnydzbl.fsf@gmx.us> <87ziri9fhu.fsf@gmx.us> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=94eb2c06c10089eb96053379c6ae Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:57177) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b4gFn-00046I-16 for emacs-orgmode@gnu.org; Sun, 22 May 2016 23:10:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b4gFj-00052y-BQ for emacs-orgmode@gnu.org; Sun, 22 May 2016 23:10:01 -0400 Received: from mail-yw0-x231.google.com ([2607:f8b0:4002:c05::231]:34611) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b4gFj-00052Y-35 for emacs-orgmode@gnu.org; Sun, 22 May 2016 23:09:59 -0400 Received: by mail-yw0-x231.google.com with SMTP id c127so42269608ywb.1 for ; Sun, 22 May 2016 20:09:58 -0700 (PDT) In-Reply-To: <87ziri9fhu.fsf@gmx.us> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Rasmus Cc: Org-mode --94eb2c06c10089eb96053379c6ae Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable I modified most part of my files. - There are some places I can't improve because I'm not good at elisp. (maybe other people can improve it later) Like ob-redis.el implement ob-sql style configuration. and ob-lua.el make use of lua-mode's running process. - I guess ob-php.el is the only one branch can be merged. - Anyway, check out my updates, if no one can be merged, I will still keep my github repositories. Thanks for your detail reviews. [stardiviner] GPG key ID: 47C32433 IRC(freeenode): stardiviner Twitter: @numbchild Key fingerprint =3D 9BAA 92BC CDDD B9EF 3B36 CB99 B8C4 B8E5 47C3 2433 Blog: http://stardiviner.github.io/ On Mon, May 23, 2016 at 1:20 AM, Rasmus wrote: > Hi, > > Thanks for your patches. Sorry about the delay. I was hoping that > someone with more ob knowledge would step in. > > Please find some comments below. I think some more work is needed before > your libraries are > > "numbchild@gmail.com" writes: > > > From 2589d4e7d28016fb515d2131cbd9ff52797e50eb Mon Sep 17 00:00:00 2001 > > From: stardiviner > > Date: Tue, 10 May 2016 16:03:32 +0800 > > Subject: [PATCH] ob-lua.el: add Lua src block executing support > > > > * contrib/lisp/ob-lua.el (org-babel-execute:lua): support executing Lua > > src block. > > Please capitalize after the colon. > > > --- > > +;;; ob-lua.el --- Execute Lua code within org-mode blocks. > > +;; Copyright 2016 stardiviner > > > +;; Author: stardiviner > > +;; Maintainer: stardiviner > > > > > +;; Keywords: org babel lua > > For whatever reason this seems to be > > ;; Keywords: literate programming, reproducible research > > In most ob files. > > > +;; URL: https://github.com/stardiviner/ob-lua > > > > +;; Created: 12th April 2016 > > This header is unnecessary, but if you like it, it=E2=80=99s fine. > > > +;; Version: 0.0.1 > > +;; Package-Requires: ((org "8")) > > > +;;; Commentary: > > +;; > > +;; Execute Lua code within org-mode blocks. > > > Maybe, > > The file provides Org-Babel support for evaluating Lua code. > > > > > +;;; Code: > > +(require 'org) > > This is unnecessary. Ob implies Org. > > > +(require 'ob) > > + > > +(defgroup ob-lua nil > > + "org-mode blocks for Lua." > > + :group 'org) > > It seems that ob languages do not typically define new groups. > > Also, ob is the filename. Variables are org-babel. > > > +(defcustom ob-lua:default-session "*lua*" > > + "Default Lua session. > > + > > +It is lua inferior process from `run-lua'." > > + :group 'ob-lua > > + :type 'string) > > I don=E2=80=99t think this is necessary to have as a defcustom. There=E2= =80=99s already > :session. Also, you are missing :type. Per above, group is org-babel. > > > +;;;###autoload > This is normally not autoloaded. Babel languages are loaded via > org-babel-do-load-languages. > > > +(defun org-babel-execute:lua (body params) > > + "org-babel lua hook." > > Please capitalize sentences. > > > + (let* ((session (or (cdr (assoc :session params)) > > + ob-lua:default-session)) > > + (cmd (mapconcat 'identity (list "lua -") " "))) > > Is something missing here? AFAIK cmd =E2=86=92 "lua -" always. > > Also, what if my lua is not in my PATH? I got a felling that you might > make a more robust mode by hooking into lua-mode > > https://immerrr.github.io/lua-mode/ > > > + (org-babel-eval cmd body))) > > How are various return values handled? E.g. will a table be correctly > interpreted as such? (It=E2=80=99s a while since I coded in lua). > > > +;;;###Autoload > > +(eval-after-load "org" > > + '(add-to-list 'org-src-lang-modes '("lua" . lua))) > > > This should be unnecessary as the lua-mode is presumably lua-mode. Also, > I think your code depends on lua-mode in order to be able to edit it. Yo= u > need to declare that as a dependency. > > > +(provide 'ob-lua) > > + > > +;;; ob-lua.el ends here > > -- > > 2.8.2 > > > > > > From d2e7202930fcf24e7c90826e69bb768094463a0c Mon Sep 17 00:00:00 2001 > > From: stardiviner > > Date: Tue, 10 May 2016 16:05:38 +0800 > > Subject: [PATCH] ob-php.el: Add PHP src block executing support > > > > * contrib/lisp/ob-php.el (org-babel-execute:php): support executing PHP > > src block. > > Capitalize. > > > --- > > contrib/lisp/ob-php.el | 44 ++++++++++++++++++++++++++++++++++++++++++= ++ > > 1 file changed, 44 insertions(+) > > create mode 100644 contrib/lisp/ob-php.el > > > > diff --git a/contrib/lisp/ob-php.el b/contrib/lisp/ob-php.el > > new file mode 100644 > > index 0000000..31960a5 > > --- /dev/null > > +++ b/contrib/lisp/ob-php.el > > @@ -0,0 +1,44 @@ > > +;;; ob-php.el --- Execute PHP within org-mode blocks. > > +;; Copyright 2016 stardiviner > > + > > +;; Author: stardiviner > > +;; Maintainer: stardiviner > > +;; Keywords: org babel php > > +;; URL: https://github.com/stardiviner/ob-php > > +;; Created: 04th May 2016 > > +;; Version: 0.0.1 > > +;; Package-Requires: ((org "8")) > > + > > +;;; Commentary: > > +;; > > +;; Execute PHP within org-mode blocks. > > + > > +;;; Code: > > +(require 'org) > > +(require 'ob) > > + > > +(defgroup ob-php nil > > + "org-mode blocks for PHP." > > + :group 'org) > > > See comments above. > > > +;; Todo > > Remove. > > > +(defcustom ob-php:inf-php-buffer "*php*" > > + "Default PHP inferior buffer." > > + :group 'ob-php > > + :type 'string) > > :Type is missing and this buffer should not be a defcustom. > > > +;;;###Autoload > > Remove. > > > +(defun org-babel-execute:php (body params) > > + "org-babel PHP hook." > > + ;; Todo > > Remove. > > > + (let* ((cmd (mapconcat 'identity (list "php") " -r "))) > > + (org-babel-eval cmd body) > > + )) > > See comments above re docstring, and robustness. > > What sort of return values can I expect from this? I don=E2=80=99t know = php, but > I assume it=E2=80=99s mainly "log messages". > > > +;;;###autoload > > +(eval-after-load "org" > > + '(add-to-list 'org-src-lang-modes '("php" . php))) > > Unnecessary. Also, it seems there=E2=80=99s an undeclared decency on som= e sort of > php mode. > > > + > > +(provide 'ob-php) > > > From eb3c0cb1467416d141a633c49e1c9050311d92ab Mon Sep 17 00:00:00 2001 > > From: stardiviner > > Date: Tue, 10 May 2016 16:06:19 +0800 > > Subject: [PATCH] ob-redis.el: Add Redis src block executing support > > > > * contrib/lisp/ob-redis.el (org-babel-execute:redis): support for > > executing redis src block. > > Capitalize > > > > --- > > contrib/lisp/ob-redis.el | 44 > ++++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 44 insertions(+) > > create mode 100644 contrib/lisp/ob-redis.el > > > > diff --git a/contrib/lisp/ob-redis.el b/contrib/lisp/ob-redis.el > > new file mode 100644 > > index 0000000..340b050 > > --- /dev/null > > +++ b/contrib/lisp/ob-redis.el > > @@ -0,0 +1,44 @@ > > +;;; ob-redis.el --- Execute Redis queries within org-mode blocks. > > +;; Copyright 2016 stardiviner > > + > > +;; Author: stardiviner > > +;; Maintainer: stardiviner > > +;; Keywords: org babel redis > > +;; URL: https://github.com/stardiviner/ob-redis > > +;; Created: 28th Feb 2016 > > +;; Version: 0.0.1 > > +;; Package-Requires: ((org "8")) > > + > > +;;; Commentary: > > +;; > > +;; Execute Redis queries within org-mode blocks. > > + > > +;;; Code: > > +(require 'org) > > +(require 'ob) > > + > > +(defgroup ob-redis nil > > + "org-mode blocks for Redis." > > + :group 'org) > > As above. > > > +(defcustom ob-redis:default-db "127.0.0.1:6379" > > + "Default Redis database." > > + :group 'ob-redis > > + :type 'string) > > Does redis support login and different ports and all that jazz? > If so, please compare the configurability to the needs of ob-sql. > > Is it possible to extend ob-sql with another engine? (I don=E2=80=99t kn= ow > anything about redis). > > Or are these "NoSQL" databases similar enough that it would be possible t= o > have "unite" them in a single library. Does ob have support for any > "NoSQL" databases ATM? > > I=E2=80=99m not implying that this is necessarily the right way to go. I= =E2=80=99m just > trying to understand the nature of this. > > > +;;;###Autoload > > Remove. > > > +(defun org-babel-execute:redis (body params) > > + "org-babel redis hook." > > + (let* ((db (or (cdr (assoc :db params)) > > + ob-redis:default-db)) > > + (cmd (mapconcat 'identity (list "redis-cli") " "))) > > + (org-babel-eval cmd body) > > + )) > > > My guess is that connectivity support is not comprehensive enough. > > > +;;;###autoload > > +(eval-after-load "org" > > + '(add-to-list 'org-src-lang-modes '("redis" . redis))) > > Remove. > > > +(provide 'ob-redis) > > + > > +;;; ob-redis.el ends here > > Thanks, > Rasmus > > -- > Vote for proprietary math! > > > > --94eb2c06c10089eb96053379c6ae Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
I modified most part of my files.

- There a= re some places I can't improve because I'm not good at elisp. (mayb= e other =C2=A0 =C2=A0 =C2=A0people can improve it later) Like ob-redis.el i= mplement ob-sql style configuration. and ob-lua.el make use of lua-mode'= ;s running process.

- I guess ob-php.el is the only one bran= ch can be merged.
- Anyway, check out my updates, if no one can be mer= ged, I will still keep my github repositories.

Thanks for yo= ur detail reviews.


[stardiviner]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 <Hack this world!>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 GPG key ID= : 47C32433
IRC(freeenode): stardiviner =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 Twitter:=C2=A0 @numbchild
Key fingerprint =3D 9BAA 92BC CDDD B9EF= 3B36=C2=A0 CB99 B8C4 B8E5 47C3 2433
Blog: http://stardiviner.github.io/
<= /div>

On Mon, May 23, 2016 at 1:20 AM, Rasmus <rasmus= @gmx.us> wrote:
Hi,

Thanks for your patches.=C2=A0 Sorry about the delay.=C2=A0 I was hoping th= at
someone with more ob knowledge would step in.

Please find some comments below.=C2=A0 I think some more work is needed bef= ore
your libraries are

"numbchild@gmail.com" = <numbchild@gmail.com> writ= es:

> From 2589d4e7d28016fb515d2131cbd9ff52797e50eb Mon Sep 17 00:00:00 2001=
> From: stardiviner <numbchild= @gmail.com>
> Date: Tue, 10 May 2016 16:03:32 +0800
> Subject: [PATCH] ob-lua.el: add Lua src block executing support
>
> * contrib/lisp/ob-lua.el (org-babel-execute:lua): support executing Lu= a
> src block.

Please capitalize after the colon.

> ---
> +;;; ob-lua.el --- Execute Lua code within org-mode blocks.
> +;; Copyright 2016 stardiviner

> +;; Author: stardiviner <num= bchild@gmail.com>
> +;; Maintainer: stardiviner <numbchild@gmail.com>



> +;; Keywords: org babel lua

For whatever reason this seems to be

=C2=A0 =C2=A0 ;; Keywords: literate programming, reproducible research

In most ob files.

> +;; URL: https://github.com/stardiviner/ob-lua


> +;; Created: 12th April 2016

This header is unnecessary, but if you like it, it=E2=80=99s fine.

> +;; Version: 0.0.1
> +;; Package-Requires: ((org "8"))

> +;;; Commentary:
> +;;
> +;; Execute Lua code within org-mode blocks.


Maybe,

=C2=A0 =C2=A0 =C2=A0 =C2=A0 The file provides Org-Babel support for evaluat= ing Lua code.



> +;;; Code:
> +(require 'org)

This is unnecessary.=C2=A0 Ob implies Org.

> +(require 'ob)
> +
> +(defgroup ob-lua nil
> +=C2=A0 "org-mode blocks for Lua."
> +=C2=A0 :group 'org)

It seems that ob languages do not typically define new groups.

Also, ob is the filename.=C2=A0 Variables are org-babel.

> +(defcustom ob-lua:default-session "*lua*"
> +=C2=A0 "Default Lua session.
> +
> +It is lua inferior process from `run-lua'."
> +=C2=A0 :group 'ob-lua
> +=C2=A0 :type 'string)

I don=E2=80=99t think this is necessary to have as a defcustom.=C2=A0 There= =E2=80=99s already
:session.=C2=A0 Also, you are missing :type.=C2=A0 Per above, group is org-= babel.

> +;;;###autoload
This is normally not autoloaded.=C2=A0 Babel languages are loaded via
org-babel-do-load-languages.

> +(defun org-babel-execute:lua (body params)
> +=C2=A0 "org-babel lua hook."

Please capitalize sentences.

> +=C2=A0 (let* ((session (or (cdr (assoc :session params))
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 ob-lua:default-session))
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(cmd (mapconcat 'identity (list= "lua -") " ")))

Is something missing here?=C2=A0 AFAIK cmd =E2=86=92 "lua -" alwa= ys.

Also, what if my lua is not in my PATH?=C2=A0 I got a felling that you migh= t
make a more robust mode by hooking into lua-mode

=C2=A0 =C2=A0 =C2=A0https://immerrr.github.io/lua-mode/

> +=C2=A0 =C2=A0 (org-babel-eval cmd body)))

How are various return values handled?=C2=A0 E.g. will a table be correctly=
interpreted as such?=C2=A0 (It=E2=80=99s a while since I coded in lua).

> +;;;###Autoload
> +(eval-after-load "org"
> +=C2=A0 '(add-to-list 'org-src-lang-modes '("lua"= ; . lua)))


This should be unnecessary as the lua-mode is presumably lua-mode.=C2=A0 Al= so,
I think your code depends on lua-mode in order to be able to edit it.=C2=A0= You
need to declare that as a dependency.

> +(provide 'ob-lua)
> +
> +;;; ob-lua.el ends here
> --
> 2.8.2
>
>
> From d2e7202930fcf24e7c90826e69bb768094463a0c Mon Sep 17 00:00:00 2001=
> From: stardiviner <numbchild= @gmail.com>
> Date: Tue, 10 May 2016 16:05:38 +0800
> Subject: [PATCH] ob-php.el: Add PHP src block executing support
>
> * contrib/lisp/ob-php.el (org-babel-execute:php): support executing PH= P
>=C2=A0 =C2=A0src block.

Capitalize.

> ---
>=C2=A0 contrib/lisp/ob-php.el | 44 ++++++++++++++++++++++++++++++++++++= ++++++++
>=C2=A0 1 file changed, 44 insertions(+)
>=C2=A0 create mode 100644 contrib/lisp/ob-php.el
>
> diff --git a/contrib/lisp/ob-php.el b/contrib/lisp/ob-php.el
> new file mode 100644
> index 0000000..31960a5
> --- /dev/null
> +++ b/contrib/lisp/ob-php.el
> @@ -0,0 +1,44 @@
> +;;; ob-php.el --- Execute PHP within org-mode blocks.
> +;; Copyright 2016 stardiviner
> +
> +;; Author: stardiviner <num= bchild@gmail.com>
> +;; Maintainer: stardiviner <numbchild@gmail.com>
> +;; Keywords: org babel php
> +;; URL: https://github.com/stardiviner/ob-php
> +;; Created: 04th May 2016
> +;; Version: 0.0.1
> +;; Package-Requires: ((org "8"))
> +
> +;;; Commentary:
> +;;
> +;; Execute PHP within org-mode blocks.
> +
> +;;; Code:
> +(require 'org)
> +(require 'ob)
> +
> +(defgroup ob-php nil
> +=C2=A0 "org-mode blocks for PHP."
> +=C2=A0 :group 'org)


See comments above.

> +;; Todo

Remove.

> +(defcustom ob-php:inf-php-buffer "*php*"
> +=C2=A0 "Default PHP inferior buffer."
> +=C2=A0 :group 'ob-php
> +=C2=A0 :type 'string)

:Type is missing and this buffer should not be a defcustom.

> +;;;###Autoload

Remove.

> +(defun org-babel-execute:php (body params)
> +=C2=A0 "org-babel PHP hook."
> +=C2=A0 ;; Todo

Remove.

> +=C2=A0 (let* ((cmd (mapconcat 'identity (list "php") &q= uot; -r ")))
> +=C2=A0 =C2=A0 (org-babel-eval cmd body)
> +=C2=A0 =C2=A0 ))

See comments above re docstring, and robustness.

What sort of return values can I expect from this?=C2=A0 I don=E2=80=99t kn= ow php, but
I assume it=E2=80=99s mainly "log messages".

> +;;;###autoload
> +(eval-after-load "org"
> +=C2=A0 '(add-to-list 'org-src-lang-modes '("php"= ; . php)))

Unnecessary.=C2=A0 Also, it seems there=E2=80=99s an undeclared decency on = some sort of
php mode.

> +
> +(provide 'ob-php)

> From eb3c0cb1467416d141a633c49e1c9050311d92ab Mon Sep 17 00:00:00 2001=
> From: stardiviner <numbchild= @gmail.com>
> Date: Tue, 10 May 2016 16:06:19 +0800
> Subject: [PATCH] ob-redis.el: Add Redis src block executing support >
> * contrib/lisp/ob-redis.el (org-babel-execute:redis): support for
>=C2=A0 =C2=A0executing redis src block.

Capitalize


> ---
>=C2=A0 contrib/lisp/ob-redis.el | 44 ++++++++++++++++++++++++++++++++++= ++++++++++
>=C2=A0 1 file changed, 44 insertions(+)
>=C2=A0 create mode 100644 contrib/lisp/ob-redis.el
>
> diff --git a/contrib/lisp/ob-redis.el b/contrib/lisp/ob-redis.el
> new file mode 100644
> index 0000000..340b050
> --- /dev/null
> +++ b/contrib/lisp/ob-redis.el
> @@ -0,0 +1,44 @@
> +;;; ob-redis.el --- Execute Redis queries within org-mode blocks.
> +;; Copyright 2016 stardiviner
> +
> +;; Author: stardiviner <num= bchild@gmail.com>
> +;; Maintainer: stardiviner <numbchild@gmail.com>
> +;; Keywords: org babel redis
> +;; URL: https://github.com/stardiviner/ob-redis
> +;; Created: 28th Feb 2016
> +;; Version: 0.0.1
> +;; Package-Requires: ((org "8"))
> +
> +;;; Commentary:
> +;;
> +;; Execute Redis queries within org-mode blocks.
> +
> +;;; Code:
> +(require 'org)
> +(require 'ob)
> +
> +(defgroup ob-redis nil
> +=C2=A0 "org-mode blocks for Redis."
> +=C2=A0 :group 'org)

As above.

> +(defcustom ob-redis:default-db "127.0.0.1:6379"
> +=C2=A0 "Default Redis database."
> +=C2=A0 :group 'ob-redis
> +=C2=A0 :type 'string)

Does redis support login and different ports and all that jazz?
If so, please compare the configurability to the needs of ob-sql.

Is it possible to extend ob-sql with another engine?=C2=A0 (I don=E2=80=99t= know
anything about redis).

Or are these "NoSQL" databases similar enough that it would be po= ssible to
have "unite" them in a single library.=C2=A0 Does ob have support= for any
"NoSQL" databases ATM?

I=E2=80=99m not implying that this is necessarily the right way to go.=C2= =A0 I=E2=80=99m just
trying to understand the nature of this.

> +;;;###Autoload

Remove.

> +(defun org-babel-execute:redis (body params)
> +=C2=A0 "org-babel redis hook."
> +=C2=A0 (let* ((db (or (cdr (assoc :db params))
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0ob-redi= s:default-db))
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(cmd (mapconcat 'identity (list= "redis-cli") " ")))
> +=C2=A0 =C2=A0 (org-babel-eval cmd body)
> +=C2=A0 =C2=A0 ))


My guess is that connectivity support is not comprehensive enough.

> +;;;###autoload
> +(eval-after-load "org"
> +=C2=A0 '(add-to-list 'org-src-lang-modes '("redis&qu= ot; . redis)))

Remove.

> +(provide 'ob-redis)
> +
> +;;; ob-redis.el ends here

Thanks,
Rasmus

--
Vote for proprietary math!




--94eb2c06c10089eb96053379c6ae-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rasmus Subject: Re: add some babel supports (PHP, Lua, Redis) Date: Fri, 27 May 2016 18:52:01 +0200 Message-ID: <87d1o7v3ym.fsf@gmx.us> References: <87mvnydzbl.fsf@gmx.us> <87ziri9fhu.fsf@gmx.us> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:50766) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b6Kzf-0005tH-CF for emacs-orgmode@gnu.org; Fri, 27 May 2016 12:52:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b6KzZ-0007RB-M1 for emacs-orgmode@gnu.org; Fri, 27 May 2016 12:52:14 -0400 Received: from plane.gmane.org ([80.91.229.3]:59050) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b6KzZ-0007R4-EP for emacs-orgmode@gnu.org; Fri, 27 May 2016 12:52:09 -0400 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1b6KzY-0008PP-4w for emacs-orgmode@gnu.org; Fri, 27 May 2016 18:52:08 +0200 Received: from tsn109-201-154-160.dyn.nltelcom.net ([109.201.154.160]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 27 May 2016 18:52:08 +0200 Received: from rasmus by tsn109-201-154-160.dyn.nltelcom.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 27 May 2016 18:52:08 +0200 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: emacs-orgmode@gnu.org Hi, "numbchild@gmail.com" writes: > I modified most part of my files. Thanks. > - There are some places I can't improve because I'm not good at elisp. > (maybe other people can improve it later) Like ob-redis.el implement > ob-sql style configuration. and ob-lua.el make use of lua-mode's running > process. OK. > - I guess ob-php.el is the only one branch can be merged. Maybe we should wait until it is a bit less bare-bone or there’s a copyright assignment in place. BTW there’s also this ob-php, https://github.com/steckerhalter/ob-php > - Anyway, check out my updates, if no one can be merged, I will still keep > my github repositories. Note that there was already one ob-lua.el that was never commiteed for some reason... https://lists.gnu.org/archive/html/emacs-orgmode/2014-05/msg01149.html Rasmus -- Slowly unravels in a ball of yarn and the devil collects it From mboxrd@z Thu Jan 1 00:00:00 1970 From: "numbchild@gmail.com" Subject: Re: add some babel supports (PHP, Lua, Redis) Date: Sat, 28 May 2016 08:50:12 +0800 Message-ID: References: <87mvnydzbl.fsf@gmx.us> <87ziri9fhu.fsf@gmx.us> <87d1o7v3ym.fsf@gmx.us> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a114bb56ca49b300533dc6931 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:40109) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b6SSh-0000VW-WF for emacs-orgmode@gnu.org; Fri, 27 May 2016 20:50:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b6SSg-0003t7-Oq for emacs-orgmode@gnu.org; Fri, 27 May 2016 20:50:43 -0400 Received: from mail-yw0-x242.google.com ([2607:f8b0:4002:c05::242]:36578) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b6SSg-0003t3-IE for emacs-orgmode@gnu.org; Fri, 27 May 2016 20:50:42 -0400 Received: by mail-yw0-x242.google.com with SMTP id l126so8351153ywe.3 for ; Fri, 27 May 2016 17:50:42 -0700 (PDT) In-Reply-To: <87d1o7v3ym.fsf@gmx.us> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Rasmus Cc: Org-mode --001a114bb56ca49b300533dc6931 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable I see, I will check out them, and merge them if possible. I will PR after they are good enough. [stardiviner] GPG key ID: 47C32433 IRC(freeenode): stardiviner Twitter: @numbchild Key fingerprint =3D 9BAA 92BC CDDD B9EF 3B36 CB99 B8C4 B8E5 47C3 2433 Blog: http://stardiviner.github.io/ On Sat, May 28, 2016 at 12:52 AM, Rasmus wrote: > Hi, > > > "numbchild@gmail.com" writes: > > > I modified most part of my files. > > Thanks. > > > - There are some places I can't improve because I'm not good at elisp. > > (maybe other people can improve it later) Like ob-redis.el impleme= nt > > ob-sql style configuration. and ob-lua.el make use of lua-mode's runnin= g > > process. > > OK. > > > - I guess ob-php.el is the only one branch can be merged. > > Maybe we should wait until it is a bit less bare-bone or there=E2=80=99s = a > copyright assignment in place. > > BTW there=E2=80=99s also this ob-php, > > https://github.com/steckerhalter/ob-php > > > - Anyway, check out my updates, if no one can be merged, I will still > keep > > my github repositories. > > Note that there was already one ob-lua.el that was never commiteed for > some reason... > > > https://lists.gnu.org/archive/html/emacs-orgmode/2014-05/msg01149.html > > Rasmus > > -- > Slowly unravels in a ball of yarn and the devil collects it > > > --001a114bb56ca49b300533dc6931 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
I see, I will check out them, and merge them if possible.<= /div>
I will PR after they are good enough.

[stardiviner]= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 <Hack this = world!>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 GPG key ID: 47C32433
IRC(freeen= ode): stardiviner =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Twitter:=C2=A0 @n= umbchild
Key fingerprint =3D 9BAA 92BC CDDD B9EF 3B36=C2=A0 CB99 B8C4 B8= E5 47C3 2433
Blog: http://stardiviner.github.io/

On Sat, May 28, 2016 at 12:52 AM, Rasmus <rasmu= s@gmx.us> wrote:
Hi,


"numbchild@gmail.com" = <numbchild@gmail.com> writ= es:

> I modified most part of my files.

Thanks.

> - There are some places I can't improve because I'm not good a= t elisp.
> (maybe other=C2=A0 =C2=A0 =C2=A0 people can improve it later) Like ob-= redis.el implement
> ob-sql style configuration. and ob-lua.el make use of lua-mode's r= unning
> process.

OK.

> - I guess ob-php.el is the only one branch can be merged.

Maybe we should wait until it is a bit less bare-bone or there=E2=80= =99s a
copyright assignment in place.

BTW there=E2=80=99s also this ob-php,

=C2=A0 https://github.com/steckerhalter/ob-php

> - Anyway, check out my updates, if no one can be merged, I will still = keep
> my github repositories.

Note that there was already one ob-lua.el that was never commiteed f= or
some reason...

=C2=A0 =C2=A0 =C2=A0https://li= sts.gnu.org/archive/html/emacs-orgmode/2014-05/msg01149.html

Rasmus

--
Slowly unravels in a ball of yarn and the devil collects it



--001a114bb56ca49b300533dc6931--