From mboxrd@z Thu Jan 1 00:00:00 1970 From: "numbchild@gmail.com" Subject: Re: [PATCH] Fix ob-python.el initiate session error with py-shell Date: Wed, 19 Feb 2020 15:38:46 +0800 Message-ID: References: <877e0kjbqq.fsf@gmail.com> <874kvnako5.fsf@gmail.com> <871rqrak5y.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000796206059ee8e28a" Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:49905) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j4Jx0-0003WD-VH for emacs-orgmode@gnu.org; Wed, 19 Feb 2020 02:39:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j4Jwz-0006Av-Og for emacs-orgmode@gnu.org; Wed, 19 Feb 2020 02:39:18 -0500 Received: from mail-ua1-x943.google.com ([2607:f8b0:4864:20::943]:35507) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j4Jwz-000672-Jx for emacs-orgmode@gnu.org; Wed, 19 Feb 2020 02:39:17 -0500 Received: by mail-ua1-x943.google.com with SMTP id y23so8497912ual.2 for ; Tue, 18 Feb 2020 23:39:13 -0800 (PST) In-Reply-To: <871rqrak5y.fsf@gmail.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org Sender: "Emacs-orgmode" To: Jack Kamm Cc: Org Mode --000000000000796206059ee8e28a Content-Type: text/plain; charset="UTF-8" Yes, Jack, as Bastien said, you can format my commit, because my home network is broken, I'm using Mobile Phone's 4G network to get online. Can't get update immediately. And thanks for tips about `python-mode' is deprecated. I didn't know that. I will migrate to `python.el'. [stardiviner] GPG key ID: 47C32433 IRC(freeenode): stardiviner Twitter: @numbchild Key fingerprint = 9BAA 92BC CDDD B9EF 3B36 CB99 B8C4 B8E5 47C3 2433 Blog: http://stardiviner.github.io/ On Wed, Feb 19, 2020 at 1:18 AM Jack Kamm wrote: > Hi stardiviner, > > Sorry for the noise, I have some additional comments below: > > When I run "make compile", I get the following message: > > In org-babel-python-initiate-session-by-key: > ob-python.el:211:12:Warning: py-shell called with 9 arguments, but accepts > only 0-1 > > I think this is because the "(declare-function py-shell)" no longer > matches the signature of the upstream py-shell function you're using. > > Also, I now see that the commit does have a changelog entry, but not a > commit message. Unless it is standard to take the subject line as the > commit message? I am still a little new to merging patches from email, > and might not have all the proper tooling setup for it. > > When you update the patch, please mention that this is specifically for > python-mode.el in the commit message and changelog entry. > --000000000000796206059ee8e28a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Yes, Jack, as Bastien said, you can format my commit, beca= use my home network is broken, I'm using Mobile Phone's 4G network = to get online. Can't get update immediately.
And thanks for tips a= bout `python-mode' is deprecated. I didn't know that. I will migrat= e to `python.el'.

[stardiviner]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0 <Hack this world!>=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 GPG key ID: 47C32433
IRC(freeenode): stardiviner =C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0 Twitter:=C2=A0 @numbchild
Key fingerprint = =3D 9BAA 92BC CDDD B9EF 3B36=C2=A0 CB99 B8C4 B8E5 47C3 2433
Blog: http://stardiviner.gi= thub.io/


On Wed, Feb 19, 2020 at 1= :18 AM Jack Kamm <jackkamm@gmail.c= om> wrote: