From: Henning Weiss <hdweiss@gmail.com>
To: Bastien <bzg@altern.org>
Cc: emacs-orgmode@gnu.org, Richard Moreland <rlm@ncogni.to>
Subject: Re: [PATCH] org-mobile agenda title
Date: Sat, 28 Jan 2012 21:05:08 +0100 [thread overview]
Message-ID: <CAKq33ueNv8T8QUYcmGV+x=AdQZjCpuaFXMeFsZnYRaviQ3owmw@mail.gmail.com> (raw)
In-Reply-To: <87r4yjzy7w.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 2221 bytes --]
On Sat, Jan 28, 2012 at 3:41 PM, Bastien <bzg@altern.org> wrote:
> Hi Henning,
>
> Henning Weiss <hdweiss@gmail.com> writes:
>
> > I have been working on a patch for mobileorg-android that improves
> > the displaying of the generated agendas.org file. The problem I'm
> > having is that TITLE: fields of all entries are generated
> > by concatenating the name and the matching criterion of an entry. The
> > issue is discussed in further details here.
> >
> > I have tried to create a patch that removes the match criterions from
> > the generated title entry and attached it below. This could
> > potentially break other org-mobile clients and might not be the best
> > way to solve this.
> >
> > What would it take to include this in orgmode?
>
> The patch looks okay to me (I read the discussion you pointed to.)
>
> Richard, would this patch break anything on your side?
>
> Thanks,
>
> --
> Bastien
>
Hi again,
I have a little revision to the patch to remove the matching criterion from
"normal" (ie. non-block) agendas as well. See below.
best regards,
Henning Weiss
--- a/lisp/org-mobile.el
+++ b/lisp/org-mobile.el
@@ -574,7 +574,7 @@ The table of checksums is written to the file
mobile-checksums."
(concat "<after>KEYS=" key " TITLE: "
(if (and (stringp desc) (> (length desc)
0))
desc (symbol-name type))
- " " match "</after>"))
+ "</after>"))
settings))
(push (list type match settings) new))
((or (functionp (nth 2 e)) (symbolp (nth 2 e)))
@@ -592,7 +592,7 @@ The table of checksums is written to the file
mobile-checksums."
(cons (list 'org-agenda-title-append
(concat "<after>KEYS=" gkey "#"
(number-to-string
(setq cnt (1+ cnt)))
- " TITLE: " gdesc " " match "</after>"))
+ " TITLE: " gdesc "</after>"))
settings))
(push (list type match settings) new)))))
(and new (list "X" "SUMO" (reverse new)
[-- Attachment #2: Type: text/html, Size: 3276 bytes --]
next prev parent reply other threads:[~2012-01-28 20:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-25 21:21 [PATCH] org-mobile agenda title Henning Weiss
2012-01-28 14:41 ` Bastien
2012-01-28 20:05 ` Henning Weiss [this message]
2012-03-20 15:30 ` Bastien
2012-12-05 13:10 ` Henning Weiss
2012-12-30 8:55 ` Bastien
2013-01-04 15:29 ` Henning Weiss
2013-01-04 16:22 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKq33ueNv8T8QUYcmGV+x=AdQZjCpuaFXMeFsZnYRaviQ3owmw@mail.gmail.com' \
--to=hdweiss@gmail.com \
--cc=bzg@altern.org \
--cc=emacs-orgmode@gnu.org \
--cc=rlm@ncogni.to \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).