From: Nafiz Islam <nafiz.islam1001@gmail.com>
To: Ihor Radchenko <yantar92@posteo.net>
Cc: emacs-orgmode@gnu.org
Subject: Re: [FR] Support headline as a function for file+headline target for org-capture-templates
Date: Fri, 3 May 2024 20:10:37 -0400 [thread overview]
Message-ID: <CAKjtFcQJ49hKGix7wvG_0VVR=tBhc7-aYsrpQgptqGJm7b9cJQ@mail.gmail.com> (raw)
In-Reply-To: <87ttjftany.fsf@localhost>
[-- Attachment #1: Type: text/plain, Size: 2566 bytes --]
So far I have written this code...
(defun org-capture-expand-headline (headline)
"Expand functions, symbols and strings for HEADLINE.
When HEADLINE is a function, call it. When it is a form, evaluate
it. When it is a variable, return its value. When it is a string,
treat it as a headline title. When it is `t', select existing headline
title or enter a new one. In any other case, raise an error."
(let* ((headlines (org-map-entries (lambda ()
(org-element-property :title
(org-element-at-point)))))
(final-headline (cond ((stringp headline) headline)
((functionp headline) (funcall headline
headlines))
((eq headline t) (completing-read "Enter
headline: " headlines nil 'confirm))
((and (symbolp headline) (boundp headline))
(symbol-value headline))
(t nil))))
(or (org-string-nw-p final-headline)
(error "Invalid headline: %S" headline))))
and I updated `org-capture-set-target-location' to use that function when
handling with target `file+headline'
What I am concerned about is the amount of tests I might have to write or
update for `org-capture'.
testing/lisp/test-org-capture.el
125: `(("t" "Todo" entry (file+headline ,file "A") "** H1 %?"))))
144: `(("t" "Todo" entry (file+headline ,file2 "A")
175: `(("t" "Todo" entry (file+headline ,file "A") "** H1 %?"))))
221: `(("t" "Todo" entry (file+headline ,file "A") "** H1 %?"))))
233: `(("t" "Test" entry (file+headline ,file "A") "** H\nFoo"
243: `(("t" "Test" entry (file+headline ,file "A") "** "
279: `(("t" "Item" item (file+headline ,file "A") "- X"))))
312: `(("t" "Item" item (file+headline ,file "A") "- X"))))
323: `(("t" "Item" item (file+headline ,file "A") "- X"
337: `(("t" "Item" item (file+headline ,file "A") "- X"
358: `(("t" "Item" item (file+headline ,file "A") "- X"
371: `(("t" "Item" item (file+headline ,file "A") "- X"))))
538: `(("t" "Table" table-line (file+headline ,file "Inbox")
552: `(("t" "Table" table-line (file+headline ,file "Inbox")
723: `(("t" "Text" plain (file+headline ,file "A") "Foo"
733: `(("t" "Text" plain (file+headline ,file "A") "Foo"
How do you think it should be tested if the headline can be 4 different
types?
Apology in advance if the formatting is off.
[-- Attachment #2: Type: text/html, Size: 7446 bytes --]
next prev parent reply other threads:[~2024-05-04 0:11 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-28 14:58 [FR] Support headline as a function for file+headline target for org-capture-templates Nafiz Islam
2024-04-28 15:48 ` Nafiz Islam
2024-04-28 21:27 ` Nafiz Islam
2024-04-30 12:32 ` Ihor Radchenko
2024-04-30 19:45 ` Nafiz Islam
2024-05-01 11:11 ` Ihor Radchenko
2024-05-01 12:02 ` Nafiz Islam
2024-05-01 13:50 ` Ihor Radchenko
2024-05-01 23:03 ` Nafiz Islam
2024-05-02 12:34 ` Ihor Radchenko
[not found] ` <CAKjtFcT0B_CiZ=Gm4WL1Qj-TkzQ1qg+ebcVqdu-4_kzu_OEFcA@mail.gmail.com>
2024-05-02 20:57 ` Nafiz Islam
2024-05-03 11:08 ` Ihor Radchenko
2024-05-04 0:10 ` Nafiz Islam [this message]
2024-05-04 12:08 ` Ihor Radchenko
2024-05-11 16:02 ` Nafiz Islam
2024-05-11 17:41 ` Ihor Radchenko
2024-04-30 12:33 ` Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKjtFcQJ49hKGix7wvG_0VVR=tBhc7-aYsrpQgptqGJm7b9cJQ@mail.gmail.com' \
--to=nafiz.islam1001@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=yantar92@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).