From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id QJ8YMHvN9GJHAgEAbAwnHQ (envelope-from ) for ; Thu, 11 Aug 2022 11:35:55 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id EC3ZL3vN9GIMdAAAauVa8A (envelope-from ) for ; Thu, 11 Aug 2022 11:35:55 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7EBFA3B2D9 for ; Thu, 11 Aug 2022 11:35:54 +0200 (CEST) Received: from localhost ([::1]:58264 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oM4bY-0007aF-Sz for larch@yhetil.org; Thu, 11 Aug 2022 05:35:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57700) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oM4XQ-0005c6-VZ for emacs-orgmode@gnu.org; Thu, 11 Aug 2022 05:31:38 -0400 Received: from mail-oa1-x2d.google.com ([2001:4860:4864:20::2d]:38534) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oM4XP-00076h-7q for emacs-orgmode@gnu.org; Thu, 11 Aug 2022 05:31:36 -0400 Received: by mail-oa1-x2d.google.com with SMTP id 586e51a60fabf-10ee900cce0so20910059fac.5 for ; Thu, 11 Aug 2022 02:31:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:mime-version:from:to:cc; bh=2OMrzHKk5FBo1c059HdBVUqrKA7cs/QuNWKiEOwpFJ8=; b=cm5GqTyC8jG/e+sk5rGepLDHPQatwonYKjAv5nYprHavxpuks+CxqbjZOin5ywqbF1 ci7yh/VP273NlUz4gj0hNWuwR+4pheV5yyZubrPKqb9rYDCqwOzrwSWPWq18l+YII9J9 3ZBjBsH+y6dgABXayUG0fFeFdbyPfaLZH7F3Ub6kiafh0c2m1L64mXZX4OvHm4Tq9p/x fFyiajXnppgpKL08jysSv4a6DKUkKaRJUHr9aj5HipWMurZsmsPkq+WFVUrJ61JKVc2V A0/Z54voEBbkbTeVXPhNMtg8phMi5PSkXNnJn/xvcRe0OLQw0rhrjHJ4bvWqvinstTUI jREQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc; bh=2OMrzHKk5FBo1c059HdBVUqrKA7cs/QuNWKiEOwpFJ8=; b=PLxwS/2hD7Tx0GUE74Jun+Med+MZo7nWSBhbKODYDAXJGXRbz3nmEWoyAr54Ol/29H cBLXWl3ug3Z0VYVtw7/WrkJ16tG45lR8bg3zHxRy6O3YxOCxd/dP8Yk1FeWsURKAxuFq +ylzCvMCHVBEe1A97rC6t5l08WpBTyRtd6D6RZHpBYFDyzx4ao7wifH3wawNelALIkj5 FLk7wGuVBjkGVFJVrjQIWPAjsn0S8P8uy5NjrccrilV1WG6XGsyd9NY4JliWv2TenVoH mEn5vK9O/iLir05zJfUhLr85iCsGsT87hwN0VK20/C9aq+TN9iiJvAtsooSEX3Z94PB0 hI9w== X-Gm-Message-State: ACgBeo3U5eApZeua4aQ+LUG3pVPv/DXJbKpfOhrtva21hdRJ/+eheZQK F6She6Y/PVZDNtE7byIHL1V30mOjOBrdBWtm0dBriOVmZiM= X-Google-Smtp-Source: AA6agR6N9RM7MruhqCT3JrVslaTadxqs8QrsCBeLdJDB2S7dZPHT3ctgEGjBdggSBwSnuVvhBRCWE3+R3AvO34BuwMQ= X-Received: by 2002:a05:6870:f69d:b0:10d:81ea:3540 with SMTP id el29-20020a056870f69d00b0010d81ea3540mr3427282oab.257.1660210292784; Thu, 11 Aug 2022 02:31:32 -0700 (PDT) MIME-Version: 1.0 From: Anders Johansson Date: Thu, 11 Aug 2022 11:31:21 +0200 Message-ID: Subject: [BUG] org-get-buffer-tags no longer strips text properties To: org-mode-email Content-Type: multipart/alternative; boundary="000000000000c1035f05e5f3d407" Received-SPF: pass client-ip=2001:4860:4864:20::2d; envelope-from=mejlaandersj@gmail.com; helo=mail-oa1-x2d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1660210554; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=2OMrzHKk5FBo1c059HdBVUqrKA7cs/QuNWKiEOwpFJ8=; b=YjlflOhS8Q70a+YHnA0ruT4M3wpS4tLi1NnZ1sZl9bDNJyWafE2cIwg12MSezhfQGSghIH fiqMa3Zl9CyeCVF98Ypgac/kOlLQCQ6xMsjA+SHlCGqTaFcdlZBgifNjfLlzN/Yg5bfUqz d9j/57N1932O8Rz/VWdswj2KG/YWmLayZSWa3B6vgxucNhWQVH2I/YFIhG34sU6mX2X5Uz M6xan1iGyslvSZ4q+i586KAXdQlfQfjUh9izI1d67tbg1FaoVJTOjMbZLWjyRUCfjI67BJ pWnzOia7eX4YlBeLQJChbEOPqEr5eQsRevJGXIj2w2NWdnxgJpgE/hzCE9o3XA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1660210554; a=rsa-sha256; cv=none; b=TpzcCycBWEKS/zBB9L3Vq61K/dRHHxSDxW9NTtkLd2Ai+H8/UiuUZsds7i18mb65I135M+ gfuYYfTc8w+K/uDdEA5Mbr+HG/gsOiCmqMK+DVpNzi2X3+lHBv7vkKN36XaI3lTvZaKCeL JJbZXXZqeuXChCzGKtE9ALSxjvSc1o3lKuHriG/0mNaOxeRfTePCqqibND42NnNSEsAqpc hlEIhiOsErRqhIP8OOuA7rMrMQOjvqOuZ0Hh4Z3CkEP2ZplISA9/n7AqFr60tbQT3rYqXG uu+Nfu9y0UfwFfRMvISfVVE8HLXlZKebR2w2sXAlfaJEnvWDrsVzBdI8l2rPNA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=cm5GqTyC; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.38 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=cm5GqTyC; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 7EBFA3B2D9 X-Spam-Score: -2.38 X-Migadu-Scanner: scn1.migadu.com X-TUID: QaKAxZr62wGH --000000000000c1035f05e5f3d407 Content-Type: text/plain; charset="UTF-8" Hi, Commit 819409 introduced a change where the text-properties of tags collected from a buffer are no longer stripped, which means tags may be fontified in unwanted ways in completing-read (this became especially ugly using org-modern and code for right aligning tags with display properties). Something like this would fix it: @@ -11974,7 +11974,7 @@ (defun org-get-buffer-tags () (org-element-cache-map (lambda (el) (dolist (tag (org-element-property :tags el)) - (puthash (list tag) t hashed)))) + (puthash (list (substring-no-properties tag)) t hashed)))) Best, Anders Johansson --000000000000c1035f05e5f3d407 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,
Commit 819409 introduced a change w= here the text-properties of tags collected from a buffer are no longer stri= pped, which means tags may be fontified in unwanted ways in completing-read= (this became especially ugly using org-modern and code for right aligning = tags with display properties).

Something like = this would fix it:
@@ -11974,7 +11974,7 @@ (defun org-get-buf= fer-tags ()
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(org-element-cache-map
= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (lambda (el)
=C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 (dolist (tag (org-element-property :tags el))
- =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (puthash (list tag) t hashed))))
+ = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (puthash (list (substring-no-prop= erties tag)) t hashed))))

Best,
Ande= rs Johansson
--000000000000c1035f05e5f3d407--