From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id WM0uJN8+EWF6GgEAgWs5BA (envelope-from ) for ; Mon, 09 Aug 2021 16:42:39 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id oO0VIN8+EWEtDAAA1q6Kng (envelope-from ) for ; Mon, 09 Aug 2021 14:42:39 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D53451EA82 for ; Mon, 9 Aug 2021 16:42:38 +0200 (CEST) Received: from localhost ([::1]:59162 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mD6U8-0004fZ-Md for larch@yhetil.org; Mon, 09 Aug 2021 10:42:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53190) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mD6TQ-0004eJ-Eh for emacs-orgmode@gnu.org; Mon, 09 Aug 2021 10:41:52 -0400 Received: from mail-lf1-x12e.google.com ([2a00:1450:4864:20::12e]:40651) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mD6TO-0007xO-NW for emacs-orgmode@gnu.org; Mon, 09 Aug 2021 10:41:52 -0400 Received: by mail-lf1-x12e.google.com with SMTP id w20so7798958lfu.7 for ; Mon, 09 Aug 2021 07:41:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to :content-transfer-encoding; bh=RvpB1A80jYf/TunkDvDN5bWP6PQHvmW66URPl6GD7Ik=; b=fhUliU+QQtY4LdXLnbxDCn0KdBaZZU4o7HoyxpfzUH0tfNbo0L1FNN+sIWJYi05fGo G6XivDTXBVz8W6K8H8lt+EkaTi5hvu3tWR3Lo1icpPlfIjaW+GQpgrnE4s5xQNr5VAeP AL01Zkx3vck289RvmVfV/f3KN30aCHMuF/3AE1VO0DM0Xt7kmZDjQ9i1PHhEIR+53DCR PzRePOniz5+DN9x+XoUwYqrHBnCjjGhQU9GU5d3Dj9buzHAGiuUWTneqOXxMjqTTKU1A 3a0wP/fgLdFzLjSrjt0qxAFSVecG5bT3ADQ37pnQWOUpwuqj6RrmMYZYe5wirzR6xJTP +Dgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to :content-transfer-encoding; bh=RvpB1A80jYf/TunkDvDN5bWP6PQHvmW66URPl6GD7Ik=; b=af6XmVnFL93Qyc7FcIpk6EEoLmtcZjNleoKyKO4ahvNswq+qMTIK7US1heX67yxyIC VbPV9nq2QF94CJm8r/rWkUJgBkDDYxlxmI/y8rUO+fR+ZV8Qe3hi0/52U9eeeOOFaWda u5dUzRyjifi80KsVuFsgG1m05KtxZcjIPY4ILXi/ax+Xqni6VDObqwnsqQUkZgef+aVx wwQxA054JlmzgwdUU+pB1R56ZHMOtKk8bszajaFyxbkvQbkqPNub2Wg4sH5d4UBRH2RS vmxVnZ7sb63yTmxXhMKBTDR9HAUBQaBwRXPV9d4kH2MThraojQ1YBBkrbXK4DwjSqaA5 qqHw== X-Gm-Message-State: AOAM532GG56QHwY8uA5//Jw9ejczj9x2ttlwcHGGHJmGWWYzSQRDLp5c iaBVUYqkdu9Tl3cFeRCwMVXxh87iVbe9F5itP4PJO44FQQQ= X-Google-Smtp-Source: ABdhPJxvoz0gec+J4OK9UIprW4T81Z78d1AH/hCTEYbFcFWfXZZGPi9vjhS9gsGis+axKxQpg8zjVgRsg/C7OAf2+uE= X-Received: by 2002:ac2:5a45:: with SMTP id r5mr17447935lfn.124.1628520108355; Mon, 09 Aug 2021 07:41:48 -0700 (PDT) MIME-Version: 1.0 From: Anders Johansson Date: Mon, 9 Aug 2021 16:41:37 +0200 Message-ID: Subject: [PATCH] Fix bug assuming canonical duration units in org-agenda-format-items To: org-mode-email Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::12e; envelope-from=mejlaandersj@gmail.com; helo=mail-lf1-x12e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1628520159; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=RvpB1A80jYf/TunkDvDN5bWP6PQHvmW66URPl6GD7Ik=; b=FAbWGg9AjN43rJ3dHvhV6/4tIrHVDRsWSy+gObJKmrZzYf0bGqCUFNO6CBl740yoXaUoEY 7AQ/50qnOkfbWQNZMTOv4E3j0baz+IcaP/fBu3aGg2++6HmpqDdiDsgCyEGzSdkERtsBf5 XpIijOfLkkO5FOmKejmuEYyIxm9TS739StUEMWKPg4oj1aFYvToyssc8p01Nm7MTFC/IN3 Xy81Y9Wlj6D5P0F9fwZYhFUgeXVmuRzFndHp5VQAUiiaHubSG1B65eijxURh64o40Y5XHe /7VcuXwNajp3nvqgYgS7iSL6sMvCp0aigi3l5aGH6OnG6YVoHdB9Dqh9DqGrhQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1628520159; a=rsa-sha256; cv=none; b=MDmds/9FyMP/mgwZEpZigIXsJaxkm3GXDyoA7vPVMzVkW28e252td0sCcy/rfDXFbluKtl pm9GipsWqGR9kK83MJGkmkoJ4KS5uvL0TBtoJG7GxLCknSKMwYqHY7zFLQSPwcgOPrY9Dq hlR8wnWbU63dHYd/bHsD2b+Is0qnmD4IjerqO4ztAbynqjM884PGdWX/gsIdEfEXRnXCT2 M2I0aOsST4A74kc7b2btEW9i50uxdJx1zB/4IlSfgYaTwNFGIuNEA3P3Xq/kAV04LLZzbx aJDJg9KLva8HqdSrKL1lpjde6bdwpnb7tBLZ/3fqDxMRhdxsAxZjRFWPAg4x/g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=fhUliU+Q; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -3.11 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=fhUliU+Q; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: D53451EA82 X-Spam-Score: -3.11 X-Migadu-Scanner: scn0.migadu.com X-TUID: fnArbp1DbwTb org-duration-from-minutes was called with canonical =3D t, but without providing a corresponding format only using the canonical units. This broke if the user=E2=80=99s org-duration-format used other than the canonic= al units. --- lisp/org-agenda.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el index b4e5547d7..e78ab6b72 100644 --- a/lisp/org-agenda.el +++ b/lisp/org-agenda.el @@ -6749,7 +6749,7 @@ (defun org-agenda-format-item (extra txt &optional with-level with-category tags (org-duration-from-minutes (+ (org-duration-to-minutes s1 t) org-agenda-default-appointment-duration) - nil t))) + '(("d" (special . h:mm))) t))) ;; Compute the duration (when s2 (setq duration (- (org-duration-to-minutes s2) -- 2.32.0