From mboxrd@z Thu Jan 1 00:00:00 1970 From: aditya siram Subject: Re: Jumping from source block to Org block ... Date: Sat, 14 Sep 2013 11:56:39 -0500 Message-ID: References: <87y56zqubi.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=047d7bdc1870324ba704e65add56 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:56086) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VKt9u-0007gk-AU for emacs-orgmode@gnu.org; Sat, 14 Sep 2013 12:57:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VKt9s-0004mH-Cx for emacs-orgmode@gnu.org; Sat, 14 Sep 2013 12:57:22 -0400 Received: from mail-ie0-x235.google.com ([2607:f8b0:4001:c03::235]:61400) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VKt9r-0004ki-Uz for emacs-orgmode@gnu.org; Sat, 14 Sep 2013 12:57:20 -0400 Received: by mail-ie0-f181.google.com with SMTP id tp5so4577678ieb.26 for ; Sat, 14 Sep 2013 09:57:19 -0700 (PDT) In-Reply-To: List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Eric Schulte Cc: emacs-orgmode@gnu.org --047d7bdc1870324ba704e65add56 Content-Type: multipart/alternative; boundary=047d7bdc1870324ba304e65add54 --047d7bdc1870324ba304e65add54 Content-Type: text/plain; charset=ISO-8859-1 I've included new versions of both patches with most of the changes you suggested. I guess you'll apply the longer one when you've been notified by the FSF? Is this a one-time deal that covers future patches or do I have to do this with every patch that's over 15 lines long? Thanks! -deech On Sat, Sep 14, 2013 at 10:53 AM, aditya siram wrote: > Thanks for your feedback and your work on org-babel! > > Oops, the maintain-point was a hold-over and isn't actually used in the > code. I'll remove it. > > I will incorporate your suggestions. > > However, regarding the cascading if statements, how would I use `cond` > when the predicates are `and`ed and when I need different behavior in the > else cases? > > > On Sat, Sep 14, 2013 at 10:44 AM, Eric Schulte wrote: > >> aditya siram writes: >> >> > Attached is a patch that fixes a bug with jumping from source block >> back to >> > the Org file. The problem is that the current detangling behavior does >> not >> > take the :padlline flag into account. This stopped. >> > >> > Hopefully this is helpful to others ... >> > -deech >> > >> >> Hi deech, >> >> Please see the Org-mode contribution instructions at [1]. A patch of >> this length would require that you fill out the FSF copyright assignment >> paperwork before the patch could be applied. >> >> As for the content of the patch, my only question is why do you add an >> optional maintain-point argument to `org-babel-tangle-jump-to-org'? Is >> there ever a case when you would not want to maintain the point? >> >> Of much less importance I have a couple of stylistic notes about the >> code which are largely unrelated to its functionality and are included >> to make future changes easier to read and because I'm a cranky old lisp >> programmer. >> >> - you should indent the code s.t. no lines are longer than 79 characters >> - comments which float after code (e.g., ";; end of first delimiter") >> should only use 1 ; character >> - the series of if statements (if should-be-padded... if >> possibly-padded... if actually-padded...) would be more legible if >> written as a single `cond' form. >> >> Thanks for this change. It appears to pass all tests, so after the >> above have been addressed I'd be very happy to apply it. >> >> Thanks for contributing, this is much appreciated! >> >> If you have the time and inclination to include a test which fails >> without this patch applied that would be icing on the cake. >> >> Best, >> >> Footnotes: >> [1] http://orgmode.org/worg/org-contribute.html >> >> -- >> Eric Schulte >> https://cs.unm.edu/~eschulte >> PGP: 0x614CA05D >> > > --047d7bdc1870324ba304e65add54 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
I've included new versions of both patches with m= ost of the changes you suggested. I guess you'll apply the longer one w= hen you've been notified by the FSF?

Is this a one-time de= al that covers future patches or do I have to do this with every patch that= 's over 15 lines long?

Thanks!
-deech


On Sat, Sep 14, 2013 at 10:53 AM, aditya siram <ad= itya.siram@gmail.com> wrote:
Thanks for your feedba= ck and your work on org-babel!

Oops, the maintain-point w= as a hold-over and isn't actually used in the code. I'll remove it.=

I will incorporate your suggestions.

However, regarding the cascading if statements, how wo= uld I use `cond` when the predicates are `and`ed and when I need different = behavior in the else cases?


On Sat, Sep 14, 2013 at 10:44 AM, Eric Schulte <schulte.eric@gmail.co= m> wrote:
aditya siram <aditya.siram@gmail.com> writes:

> Attached is a patch that fixes a bug with jumping from source block ba= ck to
> the Org file. The problem is that the current detangling behavior does= not
> take the :padlline flag into account. This stopped.
>
> Hopefully this is helpful to others ...
> -deech
>

Hi deech,

Please see the Org-mode contribution instructions at [1]. =A0A patch of
this length would require that you fill out the FSF copyright assignment paperwork before the patch could be applied.

As for the content of the patch, my only question is why do you add an
optional maintain-point argument to `org-babel-tangle-jump-to-org'? =A0= Is
there ever a case when you would not want to maintain the point?

Of much less importance I have a couple of stylistic notes about the
code which are largely unrelated to its functionality and are included
to make future changes easier to read and because I'm a cranky old lisp=
programmer.

- you should indent the code s.t. no lines are longer than 79 characters - comments which float after code (e.g., ";; end of first delimiter&qu= ot;)
=A0 should only use 1 ; character
- the series of if statements (if should-be-padded... if
=A0 possibly-padded... if actually-padded...) would be more legible if
=A0 written as a single `cond' form.

Thanks for this change. =A0It appears to pass all tests, so after the
above have been addressed I'd be very happy to apply it.

Thanks for contributing, this is much appreciated!

If you have the time and inclination to include a test which fails
without this patch applied that would be icing on the cake.

Best,

Footnotes:
[1] =A0http://orgmode.org/worg/org-contribute.html

--
Eric Schulte
https://cs.unm= .edu/~eschulte
PGP: 0x614CA05D


--047d7bdc1870324ba304e65add54-- --047d7bdc1870324ba704e65add56 Content-Type: text/plain; charset=US-ASCII; name="src_block_jump_fix.patch.txt" Content-Disposition: attachment; filename="src_block_jump_fix.patch.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hll2ttmc0 RnJvbSA3OTFhNDFhOWNiOTdhZTlhMjM3Yjc0YzgzOWExZmMyYzBmNDk3MGRiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBZGl0eWEgU2lyYW0gPGFkaXR5YSBzaXJhbSBhdCBnbWFpbCBk b3QgY29tPgpEYXRlOiBTYXQsIDE0IFNlcCAyMDEzIDExOjQ3OjE3IC0wNTAwClN1YmplY3Q6IFtQ QVRDSCAyLzJdIERldGFuZ2xpbmcgYW5kIGp1bXBpbmcgYmFjayBub3cgY29ycmVjdGx5IGNvbXBl bnNhdGUgZm9yCiBwYWRkZWQgY2h1bmtzCgotLS0KIGxpc3Avb2ItdGFuZ2xlLmVsIHwgMTAyICsr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0tLQogMSBm aWxlIGNoYW5nZWQsIDk3IGluc2VydGlvbnMoKyksIDUgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0 IGEvbGlzcC9vYi10YW5nbGUuZWwgYi9saXNwL29iLXRhbmdsZS5lbAppbmRleCA4MTQxOTQzLi40 MmZhMzFjIDEwMDY0NAotLS0gYS9saXNwL29iLXRhbmdsZS5lbAorKysgYi9saXNwL29iLXRhbmds ZS5lbApAQCAtNTA2LDggKzUwNiw4IEBAIHdoaWNoIGVuYWJsZSB0aGUgb3JpZ2luYWwgY29kZSBi bG9ja3MgdG8gYmUgZm91bmQuIgogICAiSnVtcCBmcm9tIGEgdGFuZ2xlZCBjb2RlIGZpbGUgdG8g dGhlIHJlbGF0ZWQgT3JnLW1vZGUgZmlsZS4iCiAgIChpbnRlcmFjdGl2ZSkKICAgKGxldCAoKG1p ZCAocG9pbnQpKQotCXN0YXJ0IGJvZHktc3RhcnQgZW5kIGRvbmUKLSAgICAgICAgdGFyZ2V0LWJ1 ZmZlciB0YXJnZXQtY2hhciBsaW5rIHBhdGggYmxvY2stbmFtZSBib2R5KQorCXN0YXJ0IGJvZHkt c3RhcnQgZW5kIGRvbmUgZGVwYWRkZWQtYm9keQorICAgICAgICB0YXJnZXQtYnVmZmVyIG9mZnNl dCB0YXJnZXQtY2hhciBsaW5rIHBhdGggYmxvY2stbmFtZSBib2R5KQogICAgIChzYXZlLXdpbmRv dy1leGN1cnNpb24KICAgICAgIChzYXZlLWV4Y3Vyc2lvbgogCSh3aGlsZSAoYW5kIChyZS1zZWFy Y2gtYmFja3dhcmQgb3JnLWJyYWNrZXQtbGluay1hbmFseXRpYy1yZWdleHAgbmlsIHQpCkBAIC01 MjYsNyArNTI2LDcgQEAgd2hpY2ggZW5hYmxlIHRoZSBvcmlnaW5hbCBjb2RlIGJsb2NrcyB0byBi ZSBmb3VuZC4iCiAJCQkgICAgICAoc2V0cSBlbmQgKHBvaW50LWF0LWJvbCkpKSkpKSkpCiAJKHVu bGVzcyAoYW5kIHN0YXJ0ICg8IHN0YXJ0IG1pZCkgKDwgbWlkIGVuZCkpCiAJICAoZXJyb3IgIk5v dCBpbiB0YW5nbGVkIGNvZGUiKSkKLSAgICAgICAgKHNldHEgYm9keSAob3JnLWJhYmVsLXRyaW0g KGJ1ZmZlci1zdWJzdHJpbmcgc3RhcnQgZW5kKSkpKQorICAgICAgICAoc2V0cSBib2R5IChidWZm ZXItc3Vic3RyaW5nIHN0YXJ0IGVuZCkpKQogICAgICAgKHdoZW4gKHN0cmluZy1tYXRjaCAiOjoi IHBhdGgpCiAgICAgICAgIChzZXRxIHBhdGggKHN1YnN0cmluZyBwYXRoIDAgKG1hdGNoLWJlZ2lu bmluZyAwKSkpKQogICAgICAgKGZpbmQtZmlsZSBwYXRoKSAoc2V0cSB0YXJnZXQtYnVmZmVyIChj dXJyZW50LWJ1ZmZlcikpCkBAIC01MzcsMTIgKzUzNywxOCBAQCB3aGljaCBlbmFibGUgdGhlIG9y aWdpbmFsIGNvZGUgYmxvY2tzIHRvIGJlIGZvdW5kLiIKICAgICAgICAgKG9yZy1iYWJlbC1nb3Rv LW5hbWVkLXNyYy1ibG9jayBibG9jay1uYW1lKSkKICAgICAgIDs7IHBvc2l0aW9uIGF0IHRoZSBi ZWdpbm5pbmcgb2YgdGhlIGNvZGUgYmxvY2sgYm9keQogICAgICAgKGdvdG8tY2hhciAob3JnLWJh YmVsLXdoZXJlLWlzLXNyYy1ibG9jay1oZWFkKSkKKyAgICAgIChsZXQqICgocGFkLWFkanVzdGVk LXZhbHVlcworCSAgICAgIChvcmctYmFiZWwtZGV0YW5nbGUtYWRqdXN0LWZvci1wYWRsaW5lcyBz dGFydCBtaWQgYm9keSkpCisJICAgICAoZGVwYWRkZWQtYm9keSAoY2FyIHBhZC1hZGp1c3RlZC12 YWx1ZXMpKQorCSAgICAgKGRlcGFkZGVkLXBvaW50IChjZHIgcGFkLWFkanVzdGVkLXZhbHVlcykp KQorCShwcm9nbgorCSAgKHNldHEgb2Zmc2V0IGRlcGFkZGVkLXBvaW50KQorCSAgKHNldHEgYm9k eSBkZXBhZGRlZC1ib2R5KSkpCiAgICAgICAoZm9yd2FyZC1saW5lIDEpCi0gICAgICA7OyBVc2Ug b3JnLWVkaXQtc3BlY2lhbCB0byBpc29sYXRlIHRoZSBjb2RlLgogICAgICAgKG9yZy1lZGl0LXNw ZWNpYWwpCiAgICAgICA7OyBUaGVuIG1vdmUgZm9yd2FyZCB0aGUgY29ycmVjdCBudW1iZXIgb2Yg Y2hhcmFjdGVycyBpbiB0aGUKICAgICAgIDs7IGNvZGUgYnVmZmVyLgotICAgICAgKGZvcndhcmQt Y2hhciAoLSBtaWQgYm9keS1zdGFydCkpCisgICAgICAoZm9yd2FyZC1jaGFyIG9mZnNldCkKICAg ICAgIDs7IEFuZCByZXR1cm4gdG8gdGhlIE9yZy1tb2RlIGJ1ZmZlciB3aXRoIHRoZSBwb2ludCBp biB0aGUgcmlnaHQKICAgICAgIDs7IHBsYWNlLgogICAgICAgKG9yZy1lZGl0LXNyYy1leGl0KQpA QCAtNTUwLDYgKzU1Niw5MiBAQCB3aGljaCBlbmFibGUgdGhlIG9yaWdpbmFsIGNvZGUgYmxvY2tz IHRvIGJlIGZvdW5kLiIKICAgICAob3JnLXNyYy1zd2l0Y2gtdG8tYnVmZmVyIHRhcmdldC1idWZm ZXIgdCkKICAgICAocHJvZzEgYm9keSAoZ290by1jaGFyIHRhcmdldC1jaGFyKSkpKQogCisoZGVm dW4gb3JnLWJhYmVsLWRldGFuZ2xlLWFkanVzdC1mb3ItcGFkbGluZXMgKGNodW5rLXN0YXJ0IGRl c2lyZWQtcG9pbnQgY2h1bmstYm9keSkKKyAgIkNoZWNrIGlmIDpwYWRsaW5lIHdhcyBlbmFibGVk IGZvciB0aGlzIGNodW5rIGFuZCB0aGVuCithZGp1c3QgcG9pbnQgYW5kIGJvZHkgYWNjb3JkaW5n bHkuIEFsc28gYWNjb3VudCBmb3IgdGhlIHVzZXIKK2VkaXRpbmcgdGhlIHRhbmdsZWQgZmlsZSBh bmQgcmVtb3ZpbmcgdGhlIHBhZGRlZCBsaW5lcy4KKworUmV0dXJucyBhIHR1cGxlIChib2R5IC4g b2Zmc2V0KSB3aGVyZSBib2R5IGlzIGFuIGFkanVzdGVkIHNvdXJjZSBjaHVuaword2l0aCBwYWRk ZWQgbmV3bGluZXMgcG9zc2libHkgcmVtb3ZlZCBhbmQgb2Zmc2V0IGlzIGhvdyBmYXIgaW50bwor dGhhdCBjaHVuayBwb2ludCBpcy4gSWYgcG9pbnQgd2FzIG9uIGVpdGhlciBvZiB0aGUgcGFkbGlu ZXMsIHBvaW50CitpcyBzZXQgdG8gdGhlIGZpcnN0IG9yIGxhc3QgY2hhcmFjdGVyIG9mIHRoZSBj aHVuayBkZXBlbmRpbmcgb24gd2hhdCdzCitjbG9zZXIuIgorICAoc2F2ZS1leGN1cnNpb24KKyAg ICAobGV0KiAoKG9yZy1ibG9jayAob3JnLWJhYmVsLWdldC1zcmMtYmxvY2staW5mbykpCisJICAg KHBhcmFtcyAobnRoIDIgb3JnLWJsb2NrKSkKKwkgICAob3JnLWJvZHkgKG50aCAxIG9yZy1ibG9j aykpCisJICAgKHNob3VsZC1iZS1wYWRkZWQgKG5vdCAoc3RyaW5nPSAibm8iIChjZHIgKGFzc29j IDpwYWRsaW5lIHBhcmFtcykpKSkpCisJICAgKG1pbmltYWwtcGFkZGVkLWNodW5rLWxlbmd0aCAo KyAxIDsgZW5kIG9mIGZpcnN0IGRlbGltaXRlcgorCQkJCQkgICAxIDsgbmV3bGluZSBmcm9tIGZp cnN0IHBhZGxpbmUKKwkJCQkJICAgMSA7IG5ld2xpbmUgZnJvbSBzZWNvbmQgcGFkbGluZQorCQkJ CQkgICAxIDsgc3RhcnQgb2Ygc2Vjb25kIGRlbGltaXRlcgorCQkJCQkgICApKQorCSAgIChwb3Nz aWJseS1wYWRkZWQgKD49IChsZW5ndGggY2h1bmstYm9keSkgbWluaW1hbC1wYWRkZWQtY2h1bmst bGVuZ3RoKSkKKwkgICAoY2hhci1hdCAobGFtYmRhIChwb3Mgc3RyKSAoc3Vic3RyaW5nIHN0ciBw b3MgKCsgcG9zIDEpKSkpCisJICAgKGFjdHVhbGx5LXBhZGRlZCAgKGFuZCAobm90ICg9ICAobGVu Z3RoIGNodW5rLWJvZHkpIDApKQorCQkJCSAgKHN0cmluZz0gIlxuIiAoZnVuY2FsbCBjaGFyLWF0 CisJCQkJCQkJIDEKKwkJCQkJCQkgY2h1bmstYm9keSkpCisJCQkJICAoc3RyaW5nPSAiXG4iIChm dW5jYWxsIGNoYXItYXQKKwkJCQkJCQkgKC0gKGxlbmd0aCBjaHVuay1ib2R5KQorCQkJCQkJCSAg ICAxIDsgc3RhcnQgb2Ygc2Vjb25kIGRlbGltaXRlcgorCQkJCQkJCSAgICAxIDsgbmV3bGluZSBm cm9tIHNlY29uZCBwYWRsaW5lCisJCQkJCQkJICAgICkKKwkJCQkJCQkgY2h1bmstYm9keSkpKSkp CisgICAgICAoaWYgc2hvdWxkLWJlLXBhZGRlZAorCSAgKGlmIHBvc3NpYmx5LXBhZGRlZAorCSAg ICAgIChpZiBhY3R1YWxseS1wYWRkZWQKKwkJICAobGV0KiAoKHN0YXJ0LW9mZnNldCAoKyAxIDsg ZW5kIG9mIGZpcnN0IGRlbGltaXRlcgorCQkJCQkgIDEgOyBuZXdsaW5lIGZyb20gZmlyc3QgcGFk bGluZQorCQkJCQkgIDEgOyBmaXJzdCBjaGFyYWN0ZXIgb2YgYm9keQorCQkJCQkgICkpCisJCQkg KGVuZC1vZmZzZXQgKCsgMSA7IG5ld2xpbmUgZnJvbSBzZWNvbmQgcGFkbGluZQorCQkJCQkxIDsg ZW9sIGNoYXJhY3RlciBhZnRlciBsYXN0IGNoYXJhY3RlciBvZiBib2R5CisJCQkJCSkpCisJCQkg KHN0YXJ0LWluZGV4ICgtIHN0YXJ0LW9mZnNldCAxKSkKKwkJCSAoZW5kLWluZGV4ICgtIChsZW5n dGggY2h1bmstYm9keSkgZW5kLW9mZnNldCkpCisJCQkgKGRlcGFkZGVkLWJvZHkgKHN1YnN0cmlu ZyBjaHVuay1ib2R5CisJCQkJCQkgICBzdGFydC1pbmRleAorCQkJCQkJICAgZW5kLWluZGV4KSkK KwkJCSAoZGlzdGFuY2UtZnJvbS1zdGFydCAoLSBkZXNpcmVkLXBvaW50IGNodW5rLXN0YXJ0KSkK KwkJCSAob24tZmlyc3QtcGFkbGluZSAoPSBkaXN0YW5jZS1mcm9tLXN0YXJ0IDEpKQorCQkJIChv bi1sYXN0LXBhZGxpbmUgKD0gZGlzdGFuY2UtZnJvbS1zdGFydAorCQkJCQkgICAgICgtIChsZW5n dGggY2h1bmstYm9keSkgMSkpKQorCQkJIChhZGp1c3RlZC1kaXN0YW5jZQorCQkJICAoY29uZCAo b24tZmlyc3QtcGFkbGluZSAwKQorCQkJCShvbi1sYXN0LXBhZGxpbmUgKGxlbmd0aCBkZXBhZGRl ZC1ib2R5KSkKKwkJCQkodCAoLSBkaXN0YW5jZS1mcm9tLXN0YXJ0CisJCQkJICAgICAgKC0gc3Rh cnQtb2Zmc2V0CisJCQkJCSAxIDsgY29tcGVuc2F0ZSBmb3IgdGhlIGZhY3QgdGhhdAorCQkJCQkg ICA7IHN0YXJ0LW9mZnNldCBpbmNsdWRlcyB0aGUgZmlyc3QKKwkJCQkJICAgOyBjaGFyYWN0ZXIK KwkJCQkJICkpKSkpCisJCQkgKGRpc3RhbmNlLXdpdGhpbi1vcmctYm9keSAoPCBhZGp1c3RlZC1k aXN0YW5jZQorCQkJCQkJICAgICAgKC0gKGxlbmd0aCBvcmctYm9keSkgMSkpKSkKKwkJICAgIDs7 IElmIHRoaXMgY2h1bmsgYW5kIHRoZSBvcmcgc291cmNlIGNodW5rIG1hdGNoCisJCSAgICA7OyBz ZW5kIHRoaXMgY2h1bmsgYmFjayBhbmQgcHJlc2VydmUgdGhlIGRlc2lyZWQgcG9pbnQKKwkJICAg IChpZiAoc3RyaW5nPSBvcmctYm9keSBkZXBhZGRlZC1ib2R5KQorCQkJYCgsZGVwYWRkZWQtYm9k eSAuICxhZGp1c3RlZC1kaXN0YW5jZSkKKwkJICAgICAgOzsgaWYgdGhlIGNodW5rcyBtYXRjaCBi ZWZvcmUgdGhlIGRlc2lyZWQgcG9pbnQKKwkJICAgICAgOzsgd2UgY2FuIHN0aWxsIHByZXNlcnZl IHRoZSBwb2ludAorCQkgICAgICAoaWYgKGFuZCBkaXN0YW5jZS13aXRoaW4tb3JnLWJvZHkKKwkJ CSAgICAgICAoc3RyaW5nPSAoc3Vic3RyaW5nIG9yZy1ib2R5CisJCQkJCQkgICAwCisJCQkJCQkg ICBhZGp1c3RlZC1kaXN0YW5jZSkKKwkJCQkJKHN1YnN0cmluZyBkZXBhZGRlZC1ib2R5CisJCQkJ CQkgICAwCisJCQkJCQkgICBhZGp1c3RlZC1kaXN0YW5jZSkpKQorCQkJICBgKCxkZXBhZGRlZC1i b2R5IC4gLGFkanVzdGVkLWRpc3RhbmNlKQorCQkJOzsgb3RoZXJ3aXNlIHdlIGNhbid0IHByZXNl cnZlIHRoZSBwb2ludAorCQkJYCgsZGVwYWRkZWQtYm9keSAuIDApKQorCQkgICAgICBgKCxkZXBh ZGRlZC1ib2R5IC4gMCkpKQorCQk7OyBUaGUgdXNlciBkaWRuJ3QgcmVzcGVjdCB0aGUgcGFkbGlu ZXMKKwkJOzsgc28gdGhlIHdob2xlIGJvZHkgZ29lcyBiYWNrIHVuY2hhbmdlZAorCQlgKCxjaHVu ay1ib2R5IC4gMCkpCisJICAgIGAoLGNodW5rLWJvZHkgLiAwKSkKKwk7OyBObyBhZGp1c3RtZW50 IG5lZWRlZAorCWAoLGNodW5rLWJvZHkgLiAsZGVzaXJlZC1wb2ludCkpKSkpCisKIChwcm92aWRl ICdvYi10YW5nbGUpCiAKIDs7IExvY2FsIHZhcmlhYmxlczoKLS0gCjEuOC4xLjIKCg== --047d7bdc1870324ba704e65add56 Content-Type: text/plain; charset=US-ASCII; name="src_regexp_fix.patch.txt" Content-Disposition: attachment; filename="src_regexp_fix.patch.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hll2tyu11 RnJvbSBjY2UwY2Y5NjgyYzAxYzhmZjRkMzZkMGJmMDZkZjIyM2I3YzdjYjZlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBZGl0eWEgU2lyYW0gPGFkaXR5YSBzaXJhbSBhdCBnbWFpbCBk b3QgY29tPgpEYXRlOiBGcmksIDEzIFNlcCAyMDEzIDA5OjU3OjI1IC0wNTAwClN1YmplY3Q6IFtQ QVRDSCAxLzJdIG9yZy1iYWJlbC1zcmMtYmxvY2stcmVnZXhwIGlnbm9yZXMgZW1wdHkgYm9keQoK IG9yZy1iYWJlbC1zcmMtYmxvY2sgZ29iYmxlZCB1cCBldmVyeXRoaW5nIHVudGlsIHRoZSBlbmRp bmcgZGVsaW1pdGVyCiBvZiB0aGUgbmV4dCBjb2RlIGJsb2NrLiBGaXhlZCB0aGlzIGJ5IG1ha2lu ZyB0aGUgYm9keSByZWdleHAgbm9uLWdyZWVkeS4KCiBsaXNwL29iLWNvcmUuZWwgfCAyICsKIDEg ZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigtKQotLS0KIGxpc3Avb2It Y29yZS5lbCB8IDIgKy0KIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlv bigtKQoKZGlmZiAtLWdpdCBhL2xpc3Avb2ItY29yZS5lbCBiL2xpc3Avb2ItY29yZS5lbAppbmRl eCBkNTc4MDZiLi5lOGYxNmEwIDEwMDY0NAotLS0gYS9saXNwL29iLWNvcmUuZWwKKysrIGIvbGlz cC9vYi1jb3JlLmVsCkBAIC0xODgsNyArMTg4LDcgQEAgVGhpcyBzdHJpbmcgbXVzdCBpbmNsdWRl IGEgXCIlc1wiIHdoaWNoIHdpbGwgYmUgcmVwbGFjZWQgYnkgdGhlIHJlc3VsdHMuIgogICAgOzsg KDQpIGhlYWRlciBhcmd1bWVudHMKICAgICJcXChbXlxuXSpcXClcbiIKICAgIDs7ICg1KSBib2R5 Ci0gICAiXFwoW15cMDAwXSo/XG5cXCk/WyBcdF0qI1xcK2VuZF9zcmMiKQorICAgIlxcKFteXDAw MF0qP1xuXFwpPz9bIFx0XSojXFwrZW5kX3NyYyIpCiAgICJSZWdleHAgdXNlZCB0byBpZGVudGlm eSBjb2RlIGJsb2Nrcy4iKQogCiAoZGVmdmFyIG9yZy1iYWJlbC1pbmxpbmUtc3JjLWJsb2NrLXJl Z2V4cAotLSAKMS44LjEuMgoK --047d7bdc1870324ba704e65add56--