From mboxrd@z Thu Jan 1 00:00:00 1970 From: aditya siram Subject: Re: Jumping from source block to Org block ... Date: Sat, 14 Sep 2013 10:53:25 -0500 Message-ID: References: <87y56zqubi.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=047d7bdca5040fedc204e659fba9 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:49192) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VKsAh-0005pm-QR for emacs-orgmode@gnu.org; Sat, 14 Sep 2013 11:54:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VKsAg-0005rp-Ff for emacs-orgmode@gnu.org; Sat, 14 Sep 2013 11:54:07 -0400 Received: from mail-ie0-x234.google.com ([2607:f8b0:4001:c03::234]:56317) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VKsAg-0005rl-85 for emacs-orgmode@gnu.org; Sat, 14 Sep 2013 11:54:06 -0400 Received: by mail-ie0-f180.google.com with SMTP id u16so4821669iet.11 for ; Sat, 14 Sep 2013 08:54:05 -0700 (PDT) In-Reply-To: <87y56zqubi.fsf@gmail.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Eric Schulte Cc: emacs-orgmode@gnu.org --047d7bdca5040fedc204e659fba9 Content-Type: text/plain; charset=ISO-8859-1 Thanks for your feedback and your work on org-babel! Oops, the maintain-point was a hold-over and isn't actually used in the code. I'll remove it. I will incorporate your suggestions. However, regarding the cascading if statements, how would I use `cond` when the predicates are `and`ed and when I need different behavior in the else cases? On Sat, Sep 14, 2013 at 10:44 AM, Eric Schulte wrote: > aditya siram writes: > > > Attached is a patch that fixes a bug with jumping from source block back > to > > the Org file. The problem is that the current detangling behavior does > not > > take the :padlline flag into account. This stopped. > > > > Hopefully this is helpful to others ... > > -deech > > > > Hi deech, > > Please see the Org-mode contribution instructions at [1]. A patch of > this length would require that you fill out the FSF copyright assignment > paperwork before the patch could be applied. > > As for the content of the patch, my only question is why do you add an > optional maintain-point argument to `org-babel-tangle-jump-to-org'? Is > there ever a case when you would not want to maintain the point? > > Of much less importance I have a couple of stylistic notes about the > code which are largely unrelated to its functionality and are included > to make future changes easier to read and because I'm a cranky old lisp > programmer. > > - you should indent the code s.t. no lines are longer than 79 characters > - comments which float after code (e.g., ";; end of first delimiter") > should only use 1 ; character > - the series of if statements (if should-be-padded... if > possibly-padded... if actually-padded...) would be more legible if > written as a single `cond' form. > > Thanks for this change. It appears to pass all tests, so after the > above have been addressed I'd be very happy to apply it. > > Thanks for contributing, this is much appreciated! > > If you have the time and inclination to include a test which fails > without this patch applied that would be icing on the cake. > > Best, > > Footnotes: > [1] http://orgmode.org/worg/org-contribute.html > > -- > Eric Schulte > https://cs.unm.edu/~eschulte > PGP: 0x614CA05D > --047d7bdca5040fedc204e659fba9 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
Thanks for your feedback and your work on org-babel!<= br>
Oops, the maintain-point was a hold-over and isn't ac= tually used in the code. I'll remove it.

I will incorporate your= suggestions.

However, regarding the cascading if statements, how wo= uld I use `cond` when the predicates are `and`ed and when I need different = behavior in the else cases?


On Sat, Sep 14, 2013 at 10:44 AM, Eric Schulte <schulte.eric@gmail.co= m> wrote:
aditya siram <aditya.siram@gmail.com> writes:

> Attached is a patch that fixes a bug with jumping from source block ba= ck to
> the Org file. The problem is that the current detangling behavior does= not
> take the :padlline flag into account. This stopped.
>
> Hopefully this is helpful to others ...
> -deech
>

Hi deech,

Please see the Org-mode contribution instructions at [1]. =A0A patch of
this length would require that you fill out the FSF copyright assignment paperwork before the patch could be applied.

As for the content of the patch, my only question is why do you add an
optional maintain-point argument to `org-babel-tangle-jump-to-org'? =A0= Is
there ever a case when you would not want to maintain the point?

Of much less importance I have a couple of stylistic notes about the
code which are largely unrelated to its functionality and are included
to make future changes easier to read and because I'm a cranky old lisp=
programmer.

- you should indent the code s.t. no lines are longer than 79 characters - comments which float after code (e.g., ";; end of first delimiter&qu= ot;)
=A0 should only use 1 ; character
- the series of if statements (if should-be-padded... if
=A0 possibly-padded... if actually-padded...) would be more legible if
=A0 written as a single `cond' form.

Thanks for this change. =A0It appears to pass all tests, so after the
above have been addressed I'd be very happy to apply it.

Thanks for contributing, this is much appreciated!

If you have the time and inclination to include a test which fails
without this patch applied that would be icing on the cake.

Best,

Footnotes:
[1] =A0http://orgmode.org/worg/org-contribute.html

--
Eric Schulte
https://cs.unm= .edu/~eschulte
PGP: 0x614CA05D

--047d7bdca5040fedc204e659fba9--