From mboxrd@z Thu Jan  1 00:00:00 1970
From: Allen Li <vianchielfaura@gmail.com>
Subject: Re: [PATCH 2/2] org-refile: Fix inconsistency when listing refile
 targets
Date: Wed, 21 Jun 2017 00:05:45 -0700
Message-ID: <CAJr1M6dvszi+xPTUG3kiM_XKFbMGpnP1rwq2beWKsnCwvZV99Q@mail.gmail.com>
References: <20170515125455.18251-1-seb@wirrsal.net>
	<20170515125455.18251-2-seb@wirrsal.net>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39986)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <vianchielfaura@gmail.com>) id 1dNZi1-0006m7-PC
	for emacs-orgmode@gnu.org; Wed, 21 Jun 2017 03:05:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <vianchielfaura@gmail.com>) id 1dNZi0-0003h0-Lg
	for emacs-orgmode@gnu.org; Wed, 21 Jun 2017 03:05:49 -0400
Received: from mail-ot0-x244.google.com ([2607:f8b0:4003:c0f::244]:35424)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <vianchielfaura@gmail.com>)
	id 1dNZi0-0003gg-Gp
	for emacs-orgmode@gnu.org; Wed, 21 Jun 2017 03:05:48 -0400
Received: by mail-ot0-x244.google.com with SMTP id z48so17937191otz.2
	for <emacs-orgmode@gnu.org>; Wed, 21 Jun 2017 00:05:46 -0700 (PDT)
In-Reply-To: <20170515125455.18251-2-seb@wirrsal.net>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: =?UTF-8?Q?Sebastian_Reu=C3=9Fe?= <seb@wirrsal.net>
Cc: emacs-orgmode@gnu.org

On Mon, May 15, 2017 at 5:54 AM, Sebastian Reu=C3=9Fe <seb@wirrsal.net> wro=
te:
> * org.el (org-refile-get-targets): Setting org-refile-use-outline-path
> to `file' or `buffer-name' causes an additional target for the file=E2=80=
=99s
> root node to be inserted. This functionality was absent when using
> `full-file-path'. We now add this since it is convenient and makes the
> behavior more consistent.
> ---
>  lisp/org.el | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/lisp/org.el b/lisp/org.el
> index 97713c523..28277e352 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -11563,6 +11563,8 @@ (defun org-refile-get-targets (&optional default-=
buffer)
>                  (push (list (file-name-nondirectory f) f nil nil) tgs))
>                (when (eq org-refile-use-outline-path 'buffer-name)
>                  (push (list (buffer-name (buffer-base-buffer)) f nil nil=
) tgs))
> +              (when (eq org-refile-use-outline-path 'full-file-path)
> +                (push (list (file-truename (buffer-file-name (buffer-bas=
e-buffer))) f nil nil) tgs))
>                (org-with-wide-buffer
>                 (goto-char (point-min))
>                 (setq org-outline-path-cache nil)
> --
> 2.13.0
>
>

If I'm not mistaken, the full file path needs to be wrapped in
org-protect-slash?