From mboxrd@z Thu Jan 1 00:00:00 1970 From: Samuel Wales Subject: Re: [bug] [babel] babel corrupts undo history Date: Sun, 9 Mar 2014 19:46:15 -0700 Message-ID: References: <87d2oxanct.fsf@gmail.com> <87hae9ajz2.fsf@gmail.com> <87bo4h8x63.fsf@gmail.com> <877gcx19zc.fsf@gmail.com> <871u3517no.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:59432) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WMqEL-0007Ak-UQ for emacs-orgmode@gnu.org; Sun, 09 Mar 2014 22:46:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WMqEL-0002O3-1q for emacs-orgmode@gnu.org; Sun, 09 Mar 2014 22:46:17 -0400 Received: from mail-we0-x234.google.com ([2a00:1450:400c:c03::234]:63279) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WMqEK-0002N7-R0 for emacs-orgmode@gnu.org; Sun, 09 Mar 2014 22:46:16 -0400 Received: by mail-we0-f180.google.com with SMTP id p61so7745884wes.25 for ; Sun, 09 Mar 2014 19:46:15 -0700 (PDT) In-Reply-To: List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Samuel Wales , Eric Schulte , emacs-orgmode@gnu.org as far as i know, my assessment below is correct, but i cannot confirm. i believe that if undo-related code is ripped out of babel, then undo will work correctly in the source buffer and in the edit buffer. i am not clear on what the purpose of changing undo behavior is? On 10/28/13, Samuel Wales wrote: > Hi Aaron, > > I think, but not sure, that: > > - your original patch had the right idea, and i think it improved > it, but did not fix it > - my tiny fix seemed to fix it, but i did not test enough > - i avoid the bug rather than carrying along my patch or yours > - my impression is that the bug was due to unnecessary undo fanciness > - there might have been a patch that made it into the repo? > > Samuel > > On 10/28/13, Aaron Ecay wrote: >> 2013ko urriak 28an, Samuel Wales-ek idatzi zuen: >>> >>> Hi Aaron, >>> >>> Below? >>> >>> If you mean my fix, I don't know why it worked and cannot investigate >>> it. >>> >>> Samuel >> >> Argh, I must have mistakenly deleted the quoted text from my reply; I >> did mean the suggestion to comment out the line >> >> (setq buffer-undo-list ul) >> >> But since my original patch worked for you (?), all should be fine now. >> >> -- >> Aaron Ecay >> > > > -- > The Kafka Pandemic: http://thekafkapandemic.blogspot.com > > The disease DOES progress. MANY people have died from it. ANYBODY can get > it. > > Denmark: free Karina Hansen NOW. > -- The Kafka Pandemic: http://thekafkapandemic.blogspot.com The disease DOES progress. MANY people have died from it. ANYBODY can get it. Denmark: free Karina Hansen NOW.