From: Samuel Wales <samologist@gmail.com>
To: Samuel Wales <samologist@gmail.com>,
Eric Schulte <schulte.eric@gmail.com>,
emacs-orgmode@gnu.org
Subject: Re: [bug] [babel] babel corrupts undo history
Date: Sun, 9 Mar 2014 19:46:15 -0700 [thread overview]
Message-ID: <CAJcAo8vyphimZXN6VcX3VDZSPUHLWMwajofWEVP6QKqedX3fXg@mail.gmail.com> (raw)
In-Reply-To: <CAJcAo8vvtxAKBQhzxVtyJ46Yg5c+zzcPqjCoH5CZF4Jit1zt5g@mail.gmail.com>
as far as i know, my assessment below is correct, but i cannot confirm.
i believe that if undo-related code is ripped out of babel, then undo
will work correctly in the source buffer and in the edit buffer. i am
not clear on what the purpose of changing undo behavior is?
On 10/28/13, Samuel Wales <samologist@gmail.com> wrote:
> Hi Aaron,
>
> I think, but not sure, that:
>
> - your original patch had the right idea, and i think it improved
> it, but did not fix it
> - my tiny fix seemed to fix it, but i did not test enough
> - i avoid the bug rather than carrying along my patch or yours
> - my impression is that the bug was due to unnecessary undo fanciness
> - there might have been a patch that made it into the repo?
>
> Samuel
>
> On 10/28/13, Aaron Ecay <aaronecay@gmail.com> wrote:
>> 2013ko urriak 28an, Samuel Wales-ek idatzi zuen:
>>>
>>> Hi Aaron,
>>>
>>> Below?
>>>
>>> If you mean my fix, I don't know why it worked and cannot investigate
>>> it.
>>>
>>> Samuel
>>
>> Argh, I must have mistakenly deleted the quoted text from my reply; I
>> did mean the suggestion to comment out the line
>>
>> (setq buffer-undo-list ul)
>>
>> But since my original patch worked for you (?), all should be fine now.
>>
>> --
>> Aaron Ecay
>>
>
>
> --
> The Kafka Pandemic: http://thekafkapandemic.blogspot.com
>
> The disease DOES progress. MANY people have died from it. ANYBODY can get
> it.
>
> Denmark: free Karina Hansen NOW.
>
--
The Kafka Pandemic: http://thekafkapandemic.blogspot.com
The disease DOES progress. MANY people have died from it. ANYBODY can get it.
Denmark: free Karina Hansen NOW.
next prev parent reply other threads:[~2014-03-10 2:46 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-28 1:13 [bug] [babel] babel corrupts undo history Samuel Wales
2013-08-28 14:42 ` Eric Schulte
2013-08-28 16:03 ` Aaron Ecay
2013-08-28 18:52 ` Eric Schulte
2013-08-28 19:41 ` Samuel Wales
2013-08-28 19:43 ` Samuel Wales
2013-08-28 19:51 ` Samuel Wales
2013-10-28 19:17 ` Aaron Ecay
2013-10-28 19:45 ` Samuel Wales
2013-10-28 20:07 ` Aaron Ecay
2013-10-28 21:26 ` Samuel Wales
2014-03-10 2:46 ` Samuel Wales [this message]
2014-03-18 20:48 ` Bastien
2014-03-21 21:34 ` Samuel Wales
2014-03-21 22:07 ` Bastien
2014-03-21 22:42 ` Samuel Wales
2014-03-21 22:45 ` Samuel Wales
2014-03-21 23:40 ` Bastien
2014-03-22 0:11 ` Samuel Wales
2014-03-22 0:18 ` Bastien
2014-03-22 0:37 ` Samuel Wales
2014-03-22 0:44 ` Samuel Wales
2014-03-22 8:43 ` Bastien
2014-03-22 8:57 ` Samuel Wales
2013-08-28 17:08 ` Samuel Wales
2013-08-28 17:18 ` Samuel Wales
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJcAo8vyphimZXN6VcX3VDZSPUHLWMwajofWEVP6QKqedX3fXg@mail.gmail.com \
--to=samologist@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=schulte.eric@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).