From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id gAcXFteD4l+JcAAA0tVLHw (envelope-from ) for ; Tue, 22 Dec 2020 23:40:07 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id OJPwEdeD4l+pUAAA1q6Kng (envelope-from ) for ; Tue, 22 Dec 2020 23:40:07 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 84AB39403C5 for ; Tue, 22 Dec 2020 23:40:06 +0000 (UTC) Received: from localhost ([::1]:40532 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1krrG7-0008Ix-Rg for larch@yhetil.org; Tue, 22 Dec 2020 18:40:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:37634) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1krrEb-0008Im-Kf for emacs-orgmode@gnu.org; Tue, 22 Dec 2020 18:38:29 -0500 Received: from mail-lf1-x12e.google.com ([2a00:1450:4864:20::12e]:41423) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1krrEU-0004uU-4x for emacs-orgmode@gnu.org; Tue, 22 Dec 2020 18:38:27 -0500 Received: by mail-lf1-x12e.google.com with SMTP id s26so35858412lfc.8 for ; Tue, 22 Dec 2020 15:38:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=2O+fBd6scPHalxJmNUpLdGmOG4dhI1bmK77Oj76kYmE=; b=s5NewFz4yOlQuCx6602nn0aAgoDVICkfeFJ1UxtMYItOnhHxGXoDOzSzLnnb6/TsAi BPfSxvnmwtpisqiGiS+2eFkQG4EzCDAvYyKw5CgqBfcORVsYRLA2xjbzyJsNbf63SbnH j6Zzl8PDVhHEH31VtFpMdXf0RCWmLzAt5RXfODYMGp8+fth0xLZDYT7InA1h801jI4cH fga2Mifp7ECS0TXn8XPKsXhLMXmGtoNyNBGitTAIfV7nBbiBOf3L4zORhs4vKeE1QflQ aEanMGUKSnOtGmyPYEg0G0OVF8aC8z6q4xUCgarVUp1rHbZ1EAqfVnCqcZUd+aKlM9Bb 0G5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=2O+fBd6scPHalxJmNUpLdGmOG4dhI1bmK77Oj76kYmE=; b=CX4zHhDMYEvWWh35ffu0d1p3//nb0tOIal+egtImuSJgfWb3KvWIHDsBKEzQKmM/AZ rWGSx1/uVhtlaV6sKm6N4RVFYYHTiwaMGcPEb5Q+KWJFrNtnL4epdf5tUD4tp429rZzB mApqX0FTiA1B6XPSD3P0OwfYsulmuFatNGpKapzUXkyxwtuIckIbD/Y1cxMBljWGs7Cm 3zu/4jTPlnS1V4H7yWVTuPHMw9ec9szbD4+ZK0sjwptKFtcqBbvxuA0FKKJEw10AMmme l/9JyfKY24KN9xnL4CMluJF7ujmZs9eOjA6UpoYF+CIDGm2bocUG0Tc3UCNHv8C+/X1a tbjg== X-Gm-Message-State: AOAM531CRM9i3GW4Qby4i8WNTEh8R3jj0x5WM4Jku0DwV8gsAlkC8rp5 V8TnE+FAzJgQpD6pCKNxSE/P5OXEh/EK6P4hKbc= X-Google-Smtp-Source: ABdhPJyGClONAOXWzIvsFNCksz/T3MO95txOhKHtqBDnmTfotulRYmnGk+AsPKAC4Us3leQ5SjPDvHl2KiSKbPXowto= X-Received: by 2002:a19:4c03:: with SMTP id z3mr9211951lfa.315.1608680300048; Tue, 22 Dec 2020 15:38:20 -0800 (PST) MIME-Version: 1.0 Received: by 2002:ab3:4a02:0:0:0:0:0 with HTTP; Tue, 22 Dec 2020 15:38:19 -0800 (PST) In-Reply-To: <20201222150516.kqounuguau3odhr7@gmail.com> References: <20201202142053.zexzdpmyv4ear3zc@gmail.com> <20201222150516.kqounuguau3odhr7@gmail.com> From: Samuel Wales Date: Tue, 22 Dec 2020 16:38:19 -0700 Message-ID: Subject: Re: overloading of internal priority calculations in agenda To: Adam Spiers Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2a00:1450:4864:20::12e; envelope-from=samologist@gmail.com; helo=mail-lf1-x12e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: org-mode mailing list Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -3.02 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=s5NewFz4; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 84AB39403C5 X-Spam-Score: -3.02 X-Migadu-Scanner: scn1.migadu.com X-TUID: WuOGz/e24g2Z if my opinion is worth anything [perhaps not much here :]], i like your proposals and the idea of being able to re-sort an existing agenda assuming that is your goal. i don't use any priority sorting except in user-customizable but it makes sense to decouple them for those who do. and i frequently want to differently sort an existing agenda view. On 12/22/20, Adam Spiers wrote: > Hi again, > > On Wed, Dec 02, 2020 at 02:20:53PM +0000, Adam Spiers wrote: >>Hi all, >> >>I'm currently working on adding a feature to org-agenda which allows >>manual ordering of entries in combination with the existing automatic >>ordering (as dictated by `org-agenda-sorting-strategy'). >> >>During my investigations I noticed that while `org-get-priority' converts >>[#B] style cookies into a numeric priority which is a multiple of >>1000, further adjustments are made in functions like >>`org-agenda-get-scheduled' before adding this numeric priority as a >>text property on the entry: >> >> 'priority (if habitp (org-habit-get-priority habitp) >> (+ 99 diff (org-get-priority item))) >> >>In this case `diff' refers to the number of days between now and when >>the item was scheduled. A slightly different calculation is made in >>`org-agenda-get-timestamps': >> >> (org-add-props item props >> 'priority (if habit? >> (org-habit-get-priority (org-habit-parse-todo)) >> (org-get-priority item)) >> >>I further noticed that this overloading of the internal priority by >>including timestamp and habit data causes disruption to the behaviour >>I imagine most users would expect from `org-agenda-sorting-strategy'. >>For example, if you have `priority-down' as the first entry in the >>`agenda' section and `category-keep' as the second, then differences >>in the SCHEDULED timestamp are included in the priority calculation >>and can therefore prevent sorting of two adjacent [#B] items by >>category. This seems like a bug to me, or at least breaks the >>Principle of Least Surprise. > > [snipped] > >>Given that `org-agenda-sorting-strategy' now supports all manner of >>sorting criteria, many of which are time-sensitive, I would like to >>know if there is any reason not to remove this overloading of the >>priority calculation, i.e. decoupling it to depend purely on the >>result of `org-get-priority' and `org-habit-get-priority'? >> >>If fact, perhaps we could go one step further and add support for new >>habit-priority-{up,down} sorters to `org-agenda-sorting-strategy', so >>that the priority-{up,down} sorters sort purely by the priority cookie >>and nothing else? > > Gently bumping this as I didn't get any replies yet. I would like to > continue working on a solution, but obviously don't want to waste time > on something which would be rejected. > > If it is considered important to preserve the exact behaviour > currently offered by `org-agenda-sorting-strategy' then I would > propose the following: > > - Keep the existing priority-{up,down} which combine priority cookies > with timestamp data and the result from `org-habit-get-priority', > but probably also deprecate it and remove it from the default value. > > - Introduce new priority-cookie-{up,down} sorters which operate purely > on [#A] and [#1] style priority cookies and nothing else. > > This would facilitate decoupling of the sortable criteria whilst > remaining backwards compatible. > > Does this sound reasonable? I am keen to proceed very soon (ideally > over the Xmas break). I have already written some new ert tests for > `org-agenda-sorting-strategy' which would be included in any submitted > patches. > > Thanks! > Adam > > -- The Kafka Pandemic Please learn what misopathy is. https://thekafkapandemic.blogspot.com/2013/10/why-some-diseases-are-wronged.html