From mboxrd@z Thu Jan  1 00:00:00 1970
From: Samuel Wales <samologist@gmail.com>
Subject: Re: [bug] [babel] babel corrupts undo history
Date: Fri, 21 Mar 2014 17:44:54 -0700
Message-ID: <CAJcAo8vHpB-ycW4GaO-CRfBHv=DMi5+=5yo=V7k+Mmy7K0M4Hw@mail.gmail.com>
References: <CAJcAo8ssJYAicyKLHCR=g81Gf3CxZZ2x-_q9kAFvfMW+XSmn6Q@mail.gmail.com>
	<87d2oxanct.fsf@gmail.com> <87hae9ajz2.fsf@gmail.com>
	<87bo4h8x63.fsf@gmail.com>
	<CAJcAo8uxcDWHqK0Z2wCPGH8c6PROPePC7TGexSkNz2Q5AqPGFg@mail.gmail.com>
	<CAJcAo8t_aGJbHex45KP1V=jNwmArWR1wXP5Nfpjw5uhBZf8Guw@mail.gmail.com>
	<CAJcAo8tX3dMwUDGH4LWwpS5CbESrVzgN0wC_=DvMCwLAfePsjw@mail.gmail.com>
	<877gcx19zc.fsf@gmail.com>
	<CAJcAo8uf=Vi7uh=SEDw5MrqBQB5Pn5DsAVfts0YdT9FTapvEmA@mail.gmail.com>
	<871u3517no.fsf@gmail.com>
	<CAJcAo8vvtxAKBQhzxVtyJ46Yg5c+zzcPqjCoH5CZF4Jit1zt5g@mail.gmail.com>
	<CAJcAo8vyphimZXN6VcX3VDZSPUHLWMwajofWEVP6QKqedX3fXg@mail.gmail.com>
	<87lhw7cjws.fsf@bzg.ath.cx>
	<CAJcAo8swSqkt=VJMnnh4yhG73xPZc5C1qgzV8sAxZSmtFXc9tA@mail.gmail.com>
	<87r45vkxxm.fsf@bzg.ath.cx>
	<CAJcAo8sFf7fxvyOyETb7UnsrfLNeHiw2ZA+RGM+hM62tWJ9sPA@mail.gmail.com>
	<87bnwzktmx.fsf@bzg.ath.cx>
	<CAJcAo8s6xonc0gsEeHjP4fzio7GnH6gPF=PHQWsJ1N3m2kefZA@mail.gmail.com>
	<877g7njdak.fsf@bzg.ath.cx>
	<CAJcAo8tNqMuPGyWKZhdY8S=W96B0W_socpo5T0QXc+Az=K4Q5w@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44069)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <samologist@gmail.com>) id 1WRA3U-0004AT-5w
	for emacs-orgmode@gnu.org; Fri, 21 Mar 2014 20:44:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <samologist@gmail.com>) id 1WRA3T-00042A-7d
	for emacs-orgmode@gnu.org; Fri, 21 Mar 2014 20:44:56 -0400
In-Reply-To: <CAJcAo8tNqMuPGyWKZhdY8S=W96B0W_socpo5T0QXc+Az=K4Q5w@mail.gmail.com>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Bastien <bzg@gnu.org>
Cc: emacs-orgmode@gnu.org, Eric Schulte <schulte.eric@gmail.com>

here is the fix for bug #3:

change this line in org-src.el

      (let ((buffer-undo-list t))

to:

      ;; don't change my undo list here, please
      (progn

this fixes the problem.  i really don't think this kind of fancy undo
list manipulation is the right thing to do in org.


On 3/21/14, Samuel Wales <samologist@gmail.com> wrote:
> bug #3:
>
> insert a source block
> edit after it
> c-c ' to edit
> edit
> c-c ' to go back to mybuffer
> edit before the source block
> undo
> undo
>
> you should notice that the source block is not restored.
>
> note that this is not the same buffer corruption issue i reported
> previously.
>
> in that one, you insert a source block, fill it, and undo.  then the
> next header line gets corrupted:
>
> bug #2:
>
> * header
> #+begin_src org
>   asdf
>   asdf
> #+end_src
> * header2
>
> put point inside the source block, fill, then undo.  you will see
> buffer corruption after the source block.  the exact corruption
> varies.  sometimes it is removal of the #.  other times it is removal
> of * in 1 or 2 headlines below.
>
> what makes it much worse is that you cannot undo to fix the buffer
> corruption.  you have to revert the buffer.
>
> there are others.  i believe the reason is that org tries to get fancy
> with undo.
>


-- 
The Kafka Pandemic: http://thekafkapandemic.blogspot.com

The disease DOES progress.  MANY people have died from it.  And
ANYBODY can get it.

Denmark: free Karina Hansen NOW.