From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id BR/xAJDpq2G4IgAAgWs5BA (envelope-from ) for ; Sat, 04 Dec 2021 23:20:00 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id qHV9N4/pq2EHMAAAbx9fmQ (envelope-from ) for ; Sat, 04 Dec 2021 22:19:59 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A050050B8 for ; Sat, 4 Dec 2021 23:19:59 +0100 (CET) Received: from localhost ([::1]:50820 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mtdNu-0007eL-9u for larch@yhetil.org; Sat, 04 Dec 2021 17:19:58 -0500 Received: from eggs.gnu.org ([209.51.188.92]:34812) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mtdNU-0007ch-1Y for emacs-orgmode@gnu.org; Sat, 04 Dec 2021 17:19:32 -0500 Received: from [2a00:1450:4864:20::133] (port=33725 helo=mail-lf1-x133.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mtdNS-0000ol-CX for emacs-orgmode@gnu.org; Sat, 04 Dec 2021 17:19:31 -0500 Received: by mail-lf1-x133.google.com with SMTP id bu18so15672051lfb.0 for ; Sat, 04 Dec 2021 14:19:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=k0mKy0KXJ67E1zNtFrbA0BN5w0NCDbCdJoSxkOYig9s=; b=KWKcIa8vTYhvSiG7+N26OY3KfgP2cG2sx9oAqdKQahv3B7N/C+LwAc1i+X9bb+Qq74 LGNZIpzoEj9LYD0U8ZLcesPH7SkAEQAgtd2u5RHjuktLgcj/r10XwhOhcaKHif6sqZAP RMwVPKh3TrCy2FRZn0FdSgHBH9sBrBkKKP0OeFRoySpiSr/AVExePmZp8z3jvMJPByXm Fgft/kBbafDTauQprsf4y3rSNZ+tBYZewxwyekW/ldie4OEQaYyRdiU0eEmlxCfAbgks k5T3/MykXqtu5HALDAlzILNqLg6EkIc8y3ONSBlJnLijrhlyyZ/W3jj1wq6yEN3dLgNA 1lHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=k0mKy0KXJ67E1zNtFrbA0BN5w0NCDbCdJoSxkOYig9s=; b=5K1BhfSSiMEr1Ve2ovbUE5cLlHUh1/GE5BPziuvWzRSRs/6XpLpTcZG7jsc/482cEl HnO2cO05BoMcoNzsSotP47fzJOkAb9P5EDavCvKajl/o3Wn5QyCbcLiPafF0m52tIv/e mpnyP1l72GeZiZxAkA0mhyF3pRuIZUGoptieeOEAE7OvZditrEt1sLeh6utU29SZiXgz Sey6JjLIn+AQe52lN8FhX9K565l9rfND1pT6szRxRLh5drUqqD7akpOMeKMfWu473XEG YVfyHR6yibv0HsiDKK2VPfysnKc+YbVcVTTqGB34upEmnwqC2ZUhs4iBeZmdSXaoUzMe 9u+w== X-Gm-Message-State: AOAM530/kkalvlxCQelAXgHJrbVUw3XFgoIKcRTpp1sZJHlMg87EInN9 OiwxKH84pkMaNTM13+pDgHH3NVlWYpmf+tktWNtdFjuDZvosWA== X-Google-Smtp-Source: ABdhPJyRlGWk4vQR4JEuTdALSWFbP7ZqYRYIjjcroEWzat/oUzRdzF7J17LocZy/lVgJgtszMLUbpvYcrznIVIHNYTA= X-Received: by 2002:a19:c754:: with SMTP id x81mr25301865lff.70.1638656368517; Sat, 04 Dec 2021 14:19:28 -0800 (PST) MIME-Version: 1.0 Received: by 2002:ab3:1912:0:0:0:0:0 with HTTP; Sat, 4 Dec 2021 14:19:27 -0800 (PST) In-Reply-To: <87czmcccrp.fsf@red-bean.com> References: <87czmcccrp.fsf@red-bean.com> From: Samuel Wales Date: Sat, 4 Dec 2021 15:19:27 -0700 Message-ID: Subject: Re: Removing obsolete function `org-truely-invisible-p'. To: Karl Fogel Content-Type: text/plain; charset="UTF-8" X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::133 (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::133; envelope-from=samologist@gmail.com; helo=mail-lf1-x133.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Org Mode Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1638656399; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=k0mKy0KXJ67E1zNtFrbA0BN5w0NCDbCdJoSxkOYig9s=; b=d2RGQoJYjvO2Rx362vJ8kuiv7+cosoOXkjjFukMVoQHNm5SPaB9/9qfc7TULav4474I727 uukGK6a1z0DZwlvI3pL2CfkT+gSfYLUhO/9WfafuBasqEdiF4MVQDgAM6u0YGoWhjak/V2 +5y0Du2VMJzxsg8M/FuzU/qFAuwsnMEU6ERTMT/gO9OgFzw/uUL2Mjyz0BfAheUSRiCakS xgFndIZmeA0uvUp+8ia/8oT/UcMrd/PREbZV3YdpI/2Y7yaKhYA0WhL9ZHZeLwiBzQPBU7 mjalawSnw+oIyCD2zvP0YuwVk+Cr1zDIt5yGnLZoY6BMcN4CGh6FPiAoa0PFPg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1638656399; a=rsa-sha256; cv=none; b=lLC7zAwAmv22YWR6sVBalXortjCRs9QcZyXZ7jnVxEalnoKXALGQsL8yxUFfndC71fM9a0 PThTutCMPieuh/bLLS+JYFov1Tmbbkv7LjsMfSjJaWP1tX+GGffzxLUf2cVO3po8IeURwO EJUv41vyoA5F0BZ8rzWeYJ2KzrquhuCsF1xSwKwu+OPfI665PvCFXipIrCwKLfHdj52S3e obccYdrvU/41zo0tD3Ep+XfJIMFsH7AtMeiuSvnYk+WLnBirhaaxm3CoOB4hLM8JBhrVci s+RlvkuzT10Sw2cg9EXYpupYCj8S29gIx4+SJcA4SV3/QGF9FHr0vS9EwH5Nkg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=KWKcIa8v; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.13 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=KWKcIa8v; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: A050050B8 X-Spam-Score: -4.13 X-Migadu-Scanner: scn0.migadu.com X-TUID: D0bX3yAuQJWR idk and will go along with whatever developers decide, but your note was a good reminder that visible mode can be checked. also made me wonder if it is possible to move anything from org-macs out to topic-specific files like org-visibility.el or so? no? [idk what org visibility functions do what. although i suspect org can do it, i still use htmlize-buffer-substring-no-invisible.] On 12/4/21, Karl Fogel wrote: > The function `org-truely-invisible-p' is defined in > 'lisp/org-macs.el', but it is not used anywhere anymore in Org > Mode, nor is it used anywhere in GNU Emacs (I checked on both > 'emacs-28' branch and 'master' branch). > > The last (and possibly only?) call to that function was removed > from `org-beginning-of-line' in this commit: > > commit 3baf246f4f73005a4eacd7c368f7222f95d50243 > Author: Nicolas Goaziou > AuthorDate: Thu Apr 28 23:28:15 2016 +0200 > Commit: Nicolas Goaziou > CommitDate: Thu Apr 28 23:28:15 2016 +0200 > > Handle correctly `shift-select-mode' > > * lisp/org.el (org-beginning-of-line): Handle correctly > `shift-select-mode'. > > Reported-by: Mathieu Marques > > > Then, a few months later in commit 87116700e6e, Nicholas moved the > function to 'org-macs.el', where it has been sitting unused ever > since. > > Should we just remove `org-truely-invisible-p'? Or at least > correct the spelling of its name ("truely" should be "truly")? > > It seems fairly unlikely to me that people are using it in their > own code, although of course I cannot be sure of that. Partly, I > believe that because surely someone else would have noticed the > misspelling by now, if enough people were using it :-). > > Best regards, > -Karl > > -- The Kafka Pandemic A blog about science, health, human rights, and misopathy: https://thekafkapandemic.blogspot.com