From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id gD9cAvBbLGBwbAAA0tVLHw (envelope-from ) for ; Tue, 16 Feb 2021 23:57:36 +0000 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id cNWoOe9bLGBbegAAB5/wlQ (envelope-from ) for ; Tue, 16 Feb 2021 23:57:35 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 30D0014E96 for ; Wed, 17 Feb 2021 00:57:35 +0100 (CET) Received: from localhost ([::1]:45334 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lCADm-0004PH-DF for larch@yhetil.org; Tue, 16 Feb 2021 18:57:34 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:53288) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lCADJ-0004Ow-Ja for emacs-orgmode@gnu.org; Tue, 16 Feb 2021 18:57:05 -0500 Received: from mail-lf1-x12e.google.com ([2a00:1450:4864:20::12e]:46463) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lCADH-0004Ek-7K for emacs-orgmode@gnu.org; Tue, 16 Feb 2021 18:57:05 -0500 Received: by mail-lf1-x12e.google.com with SMTP id v5so18675574lft.13 for ; Tue, 16 Feb 2021 15:57:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=1AXY/IqKTBcj/t+iAt/TkMPUPCmlBAn+CGtYeYnJl2A=; b=i21BhQkUlwc6eevZnbZDilBZPx02a8kK9AoyL8ZmxywpsBLmOUx16E2RfNQR43YGsJ uTHN0vKqhLSHjCDuc4JMo30HGM/o0PHN2Je1pZDenOS1kUU5FwwrYGCbEeCKUhbWTxRv HaXC9rHwJYwyEW4n1wk0i0Klz7tNwpDMrbgDlQG+/SLZuj9mLnd8LdLvAOveHW355CzQ oh6d+RFv1xsndYTy2Q9cjtFZ4rWcafg9NBzH3p5yrDh81OCIdDduBYs+jIjAllgsP8vZ St0xm+MqCnfsjNFLe1BnDLG9IxAqta+rudSefeLU0Q/yRg3YJvgyZz4Sm919VBmmZTjK 7F8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=1AXY/IqKTBcj/t+iAt/TkMPUPCmlBAn+CGtYeYnJl2A=; b=RjuaA9JZTCZCPFAj91i2NdLo0U7lklPRN77FD2x1R/nUPFzCcUOWcuayh2MFC7KeDe yOeqhUKsMg4M6UxU/v8/kq7ErRjUC/HfEbSHTzAEwCsNZFrr5p4oNfUQoEEwmme0mTA2 8yRbU7yNgoXRXOL4oSlMaFv63GwSQ/VLDCaRSdC9OAeyC1wozPvpkWc5Uar1X0ZLEaY8 Sl8b3bs79j9kc1gGa+cgK6n3Hf3d1mO4gftXLmAnwze3ZszaEgKReJIgiX13fMG40nu5 HAIdm6/aIaxk8w8xqYAtRvtvme4kelJonUTlN/0PFRGztA1NBRecsbPIIjySLgOqD2aU y5ZA== X-Gm-Message-State: AOAM5312Buss1SWG9cdDVnxRPN0/iGNj0KFzzCuXkisu9HmL0RnQP7FO JI3FNmuE/kkyIK6OTtOxPe9AY2g06NRgwCqbA5s= X-Google-Smtp-Source: ABdhPJx9p8Uy/gzSRBuZLUtWb7wfkEg0xpZfi36WtA9p7fSsm7XCD3Hy1bvSc036TPL0wZcWBgnbLpjBdeVTfBsk2uk= X-Received: by 2002:a19:3c4:: with SMTP id 187mr13777495lfd.458.1613519820581; Tue, 16 Feb 2021 15:57:00 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a05:6504:40c8:0:0:0:0 with HTTP; Tue, 16 Feb 2021 15:57:00 -0800 (PST) In-Reply-To: References: <87tuqbpq1s.fsf@gmail.com> From: Samuel Wales Date: Tue, 16 Feb 2021 16:57:00 -0700 Message-ID: Subject: Re: [bug] org-do-emphasis-faces breaks with incomplete emphasis To: Tim Cross Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2a00:1450:4864:20::12e; envelope-from=samologist@gmail.com; helo=mail-lf1-x12e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -3.06 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=i21BhQkU; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 30D0014E96 X-Spam-Score: -3.06 X-Migadu-Scanner: scn1.migadu.com X-TUID: YmMSIwTkkPQB to answer your question: i expected it to just skip the non-emphasis. not emphasizing the rest of the buffer seemed quite unusual. On 2/16/21, Samuel Wales wrote: > hi tim, > > it isn't malformed, so definitely not looking to be told it's > malformed. it is just text that is not emphasis. > > if you think the function works as expected by skipping the rest of > the buffer, then never mind. > > i was, in that case, just emphasizing that the code floating around > that is used to fontify the agenda is going to break. so nm. > > > On 2/16/21, Tim Cross wrote: >> >> Samuel Wales writes: >> >>> in fundamental mode [to eliminate any extra stuff]: >>> >>> === >>> hi >>> /hi/ >>> hi =test >>> hi >>> hi >>> hi >>> /hi/ >>> hi >>> *hi* >>> hi >>> hi >>> hi >>> === >>> >>> m-: (org-do-emphasis-faces nil) RET >>> >>> everything after =test does not get emphasized. >>> >>> there is code floating around that calls hte function directly instead >>> of via font lock. so even if font lock or org mode forgive this, that >>> code does not seem to. and idk whether it is forgiven or if there are >>> unintended consequences. >>> >>> e.g. to emphasize in agenda. which, not sure why it isn't? >> >> I'm not clear on what you are expecting/wanting here. If you have badly >> formed markup, syntax highlighting and other functions can be expected >> to fail. >> >> Are you expecting something more informative, like an error message >> saying you have an unterminated emphasis marker or similar? If so, while >> it might be possible, I suspect it would come at a high cost from a >> performance perspective, especially in large org files. For example, at >> what point do you decide the closing marker is missing rather than just >> a little further along? At what point do you begin doing the checking - >> after typing the first marker, after the first character, after the >> first space (noting that all this checking comes at a performance cost)? >> >> What does org-lint tell you when you have such malformed markup in your >> document? Would that be sufficient to track down issues when they occur? >> If org-lint is not picking it up or is not providing enough detail to >> help resolve the issue, perhaps tweaking it would be worthwhile. >> >> -- >> Tim Cross >> >> > > > -- > The Kafka Pandemic > > Please learn what misopathy is. > https://thekafkapandemic.blogspot.com/2013/10/why-some-diseases-are-wronged.html > -- The Kafka Pandemic Please learn what misopathy is. https://thekafkapandemic.blogspot.com/2013/10/why-some-diseases-are-wronged.html