From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jay McCarthy Subject: Re: Faces interaction between org-mode and emacs24 Date: Mon, 20 Aug 2012 09:22:02 -0600 Message-ID: References: <87393iud7m.fsf@altern.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=bcaec501c1665fda4804c7b412c6 Return-path: Received: from eggs.gnu.org ([208.118.235.92]:39327) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T3Tnu-0007tE-1x for emacs-orgmode@gnu.org; Mon, 20 Aug 2012 11:22:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T3Tno-0005EA-CQ for emacs-orgmode@gnu.org; Mon, 20 Aug 2012 11:22:10 -0400 Received: from mail-vb0-f41.google.com ([209.85.212.41]:57796) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T3Tno-0005Dt-3e for emacs-orgmode@gnu.org; Mon, 20 Aug 2012 11:22:04 -0400 Received: by vbkv13 with SMTP id v13so6315840vbk.0 for ; Mon, 20 Aug 2012 08:22:03 -0700 (PDT) In-Reply-To: <87393iud7m.fsf@altern.org> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Bastien Cc: emacs-orgmode@gnu.org --bcaec501c1665fda4804c7b412c6 Content-Type: text/plain; charset=UTF-8 Yes, it was under column mode. I tried in vain to make a small example but my emacs-fu is not strong enough. Attached is what I started to do... Jay On Sun, Aug 19, 2012 at 9:13 AM, Bastien wrote: > Hi Jay, > > Jay McCarthy writes: > >> I recently upgraded from emacs23 to emacs24, using the current git >> version of org-mode with both (current = e4c4d85). I am now >> experiencing something odd. >> >> If I open up the org-agenda to see my TODOs, the node titles are >> colored one way (red for late, gray for future, etc). I have this >> color setup using the org-agenda-before-sorting-filter-function >> variable, it basically looks at the deadline time and then calls >> put-text-property to give the text a new 'face property. You can see >> the code here: >> >> https://github.com/jeapostrophe/exp/blob/master/.emacs.el#L627 (it >> goes to about line 736) >> >> This worked great in emacs23. But now with emacs24, the colors are >> only correct when I first start emacs and load the agenda the first >> time. If I ever go to visit a TODO item in the org buffer (for >> example, by pressing ) then the color of the item from the org >> buffer appears in the agenda. For example, if something is one level >> deep (*) then it becomes blue-ish, even though my filtering function >> has change the face to be red. > > I assume the above is with column-mode turned on, right? > > ... > >> If I put my cursor in the org-buffer on the item and describe its >> text-properties, then I get the face to be, for example 'org-level-6, >> but if I go to the org-agenda and put my cursor on the text, I see >> that the face is 'due (what it is supposed to be) >> >> Even stranger, if I am in the org-agenda and turn OFF column mode >> (org-columns), then I see the "correct" colors of all the items. It is >> just in column mode that I see the colors from the org buffer. >> >> I was able to fix this with the following patch: > > ... otherwise I don't see why just fixing `org-columns-new-overlay' > should fix the first situation you describe. > > I under the idea behind the patch but I'd like to make sure there is > nothing more than this. Perhaps a simple reproducible example? > > Thanks! > > -- > Bastien -- Jay McCarthy Assistant Professor / Brigham Young University http://faculty.cs.byu.edu/~jay "The glory of God is Intelligence" - D&C 93 --bcaec501c1665fda4804c7b412c6 Content-Type: application/octet-stream; name="faces.el" Content-Disposition: attachment; filename="faces.el" Content-Transfer-Encoding: base64 X-Attachment-Id: f_h63pqj400 KHNldHEgbG9hZC1wYXRoIChjb25zICJ+L0Rldi9kaXN0L29yZy1tb2RlL2xpc3AiIGxvYWQtcGF0 aCkpCihzZXRxIGxvYWQtcGF0aCAoY29ucyAifi9EZXYvZGlzdC9vcmctbW9kZS9jb250cmliL2xp c3AiIGxvYWQtcGF0aCkpCihhZGQtdG8tbGlzdCAnSW5mby1kZWZhdWx0LWRpcmVjdG9yeS1saXN0 CiAgICAgICAgICAgICAoZXhwYW5kLWZpbGUtbmFtZSAifi9EZXYvZGlzdC9vcmctbW9kZS9kb2Mi KSkKKHJlcXVpcmUgJ29yZy1pbnN0YWxsKQoocmVxdWlyZSAnb3JnKQoocmVxdWlyZSAnb3JnLWZh Y2VzKQoKKHNldHEgb3JnLWRpcmVjdG9yeSAifi9EZXYvZGlzdC9vcmctbW9kZS9lcnJvcnMvZmFj ZXMvIikKKHNldHEgb3JnLWFnZW5kYS1maWxlcyAobGlzdCBvcmctZGlyZWN0b3J5KSkKCihzZXRx IG9yZy1hZ2VuZGEtYmVmb3JlLXNvcnRpbmctZmlsdGVyLWZ1bmN0aW9uICd0b2RvLWNvbG9yaXpl KQooc2V0cSBvcmctYWdlbmRhLWN1c3RvbS1jb21tYW5kcyAKICAgICAgJygoInQiICJUb2RvIGxp c3QiIHRvZG8gIlRPRE8iCiAgICAgICAgICgpKSkpCgooZGVmZmFjZSBkdWUKICAob3JnLWNvbXBh dGlibGUtZmFjZSAnZGVmYXVsdAogICAgJygodCAoOmZvcmVncm91bmQgIiMwMDAwMDAiKSkpKQog ICJGYWNlIGZvciBkdWUgaXRlbXMiCiAgOmdyb3VwICdvcmctZmFjZXMpCihzZXQtZmFjZS1mb3Jl Z3JvdW5kICdkdWUgIiNkYzMyMmYiKQoKKGRlZnVuIHRvZG8tY29sb3JpemUgKGEpCiAgKGxldCog KCkKICAgIDs7IFJlbW92ZSB0aGUgVE9ETwogICAgKHB1dC10ZXh0LXByb3BlcnR5CiAgICAgMCAo bGVuZ3RoIGEpCiAgICAgJ3R4dAogICAgIChyZXBsYWNlLXJlZ2V4cC1pbi1zdHJpbmcgIl5UT0RP ICoiICIiIChnZXQtdGV4dC1wcm9wZXJ0eSAwICd0eHQgYSkpCiAgICAgYSkKCiAgICA7OyBSZW1v dmUgdGhlIG9sZCBmYWNlCiAgICAocmVtb3ZlLXRleHQtcHJvcGVydGllcyAwIChsZW5ndGggYSkg JygoZmFjZSBuaWwpIChmb250aWZpZWQgbmlsKSkgYSkKCiAgICA7OyBQdXQgb24gdGhlIG5ldyBm YWNlCiAgICAocHV0LXRleHQtcHJvcGVydHkgMCAobGVuZ3RoIGEpICdmYWNlICdkdWUgYSkKCiAg ICBhKSkKCihvcmctYWdlbmRhICIiICJ0IikKKG9yZy1hZ2VuZGEtY29sdW1ucykK --bcaec501c1665fda4804c7b412c6 Content-Type: application/octet-stream; name="faces.org" Content-Disposition: attachment; filename="faces.org" Content-Transfer-Encoding: base64 X-Attachment-Id: f_h63pqmmk1 KiBUT0RPIEZpcnN0CioqIFRPRE8gU2Vjb25kCioqKiBUT0RPIFRoaXJkCioqKiogVE9ETyBGb3Vy dGgKKioqKiogVE9ETyBGaWZ0aAoqKioqKiogVE9ETyBTaXh0aAoqKioqKioqIFRPRE8gU2V2ZW50 aAo= --bcaec501c1665fda4804c7b412c6--