emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* Bug: org-publish-resolve-external-link doesn't respect org-export-with-broken-links for fuzzy links
@ 2019-09-27 19:30 Robert Irelan
  2019-10-08  9:18 ` Nicolas Goaziou
  0 siblings, 1 reply; 2+ messages in thread
From: Robert Irelan @ 2019-09-27 19:30 UTC (permalink / raw)
  To: Org-mode

[-- Attachment #1: Type: text/plain, Size: 59 bytes --]

Patch to fix attached

-- 
Robert Irelan
rirelan@gmail.com

[-- Attachment #2: 0001-ox-publish-signal-org-link-broken-for-broken-fuzzy-l.patch --]
[-- Type: text/x-patch, Size: 1265 bytes --]

From 3d3008398abb6c3a8cdfd796e6daa3f3ba909ad2 Mon Sep 17 00:00:00 2001
From: Robert Irelan <rmirelan@google.com>
Date: Fri, 27 Sep 2019 12:19:03 -0700
Subject: [PATCH] ox-publish: signal org-link-broken for broken fuzzy links

* lisp/ox-publish.el (org-publish-resolve-external-link): Signal
`org-link-broken' when `org-link-search' fails to resolve a link.
Without this change, a broken fuzzy link will always abort the export
even when `org-export-with-broken-links' is non-nil.
---
 lisp/ox-publish.el | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/lisp/ox-publish.el b/lisp/ox-publish.el
index 8928301fd..92a8aead3 100644
--- a/lisp/ox-publish.el
+++ b/lisp/ox-publish.el
@@ -1171,7 +1171,10 @@ (defun org-publish-resolve-external-link (search file &optional prefer-custom)
 	   (with-current-buffer (find-file-noselect file)
 	     (org-with-point-at 1
 	       (let ((org-link-search-must-match-exact-headline t))
-		 (org-link-search search nil t))
+		 (condition-case err
+		     (org-link-search search nil t)
+		   (error
+		    (signal 'org-link-broken (cdr err)))))
 	       (and (org-at-heading-p)
 		    (org-string-nw-p (org-entry-get (point) "CUSTOM_ID"))))))))
    ((not org-publish-cache)
-- 
2.23.0.444.g18eeb5a265-goog


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: Bug: org-publish-resolve-external-link doesn't respect org-export-with-broken-links for fuzzy links
  2019-09-27 19:30 Bug: org-publish-resolve-external-link doesn't respect org-export-with-broken-links for fuzzy links Robert Irelan
@ 2019-10-08  9:18 ` Nicolas Goaziou
  0 siblings, 0 replies; 2+ messages in thread
From: Nicolas Goaziou @ 2019-10-08  9:18 UTC (permalink / raw)
  To: Robert Irelan; +Cc: Org-mode

Hello,

Robert Irelan <rirelan@gmail.com> writes:

> Patch to fix attached

Applied. Thank you.

Regards,

-- 
Nicolas Goaziou

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-10-08  9:18 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-09-27 19:30 Bug: org-publish-resolve-external-link doesn't respect org-export-with-broken-links for fuzzy links Robert Irelan
2019-10-08  9:18 ` Nicolas Goaziou

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).