emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* Bug: broken org-cycle-include-plain-lists integrate [9.3.3 (9.3.3-elpa @ /home/bruce/.emacs.d/elpa/org-9.3.3/)]
@ 2020-02-09  8:08 Bruce Tulloch
  2020-02-11  5:00 ` stardiviner
  2020-02-11  6:57 ` Bastien
  0 siblings, 2 replies; 5+ messages in thread
From: Bruce Tulloch @ 2020-02-09  8:08 UTC (permalink / raw)
  To: emacs-orgmode

* Bug Report

  (setq org-cycle-include-plain-lists 'integrate)

  seems to have no effect.

  That is, plain lists are no longer cycling as children of outline headings.

* Example

  This content appears when cycling on Example

  * This plain list line appears (correct)
    * this line also appears (incorrect)
    * this one too (it shouldn't)
  * but this one should appear (and does)
  * as does this one but
    * this should not (but does)
      * and so does this one
* Discussion

  When cycling on the heading, plain lists always appears in the expanded state
  since upgrading to 9.3.3. The plain list will not cycle (as children of the
  heading). It appears that when org-cycle-include-plain-lists is 'integrate it
  is behaving the same as when set to t.

  This changed has appeared since 9.2.1 (which used to work).
* Current State
  #+begin_src elisp
  (setq org-src-mode-hook '(org-src-babel-configure-edit-buffer
    org-src-mode-configure-edit-buffer)
org-link-shell-confirm-function 'yes-or-no-p
org-html-head-include-scripts nil
org-metadown-hook '(org-babel-pop-to-session-maybe)
org-export-with-sub-superscripts '{}
org-clock-out-hook '(org-clock-remove-empty-clock-drawer)
org-html-format-inlinetask-function
'org-html-format-inlinetask-default-function
org-edit-src-content-indentation 0
org-odt-format-headline-function 'org-odt-format-headline-default-function
org-ascii-format-inlinetask-function 'org-ascii-format-inlinetask-default
org-cycle-include-plain-lists 'integrate
org-archive-location "ARCHIVE.org::* %s"
org-mode-hook '(org-tempo-setup org-clock-load
navi-make-org-mode-promotion-headings-list #[0 "\301\211 \207"
       [imenu-create-index-function org-imenu-get-tree] 2]
#[0 "\300\301\302\303\304$\207" [add-hook change-major-mode-hook
  org-show-all append local] 5]
#[0 "\300\301\302\303\304$\207" [add-hook change-major-mode-hook
  org-babel-show-result-all append local] 5]
org-babel-result-hide-spec org-babel-hide-all-hashes)
org-clock-persist 'history
org-odt-format-drawer-function #[514 "\207" [] 3 "\n\n(fn NAME CONTENTS)"]
org-archive-hook '(org-attach-archive-delete-maybe)
org-confirm-elisp-link-function 'yes-or-no-p
org-group-tags nil
org-clock-history-length 50
org-reverse-note-order t
org-agenda-before-write-hook '(org-agenda-add-entry-text)
org-metaup-hook '(org-babel-load-in-session-maybe)
org-bibtex-headline-format-function #[257 "\300 \236A\207" [:title] 3
  "\n\n(fn ENTRY)"]
org-latex-format-drawer-function #[514 "\207" [] 3 "\n\n(fn _ CONTENTS)"]
org-babel-pre-tangle-hook '(save-buffer)
org-file-apps '((auto-mode . emacs) ("\\.mm\\'" . default)
("\\.x?html?\\'" . default) ("\\.pdf\\'" . "evince %s"))
org-tab-first-hook '(org-babel-hide-result-toggle-maybe
     org-babel-header-arg-expand)
org-hide-leading-stars t
org-export-initial-scope 'subtree
org-html-text-markup-alist '((bold . "<b>%s</b>") (code .
"<kbd>%s</kbd>") (italic . "<i>%s</i>")
(strike-through . "<del>%s</del>") (underline . "<span
class=\"underline\">%s</span>")
(verbatim . "<code>%s</code>"))
org-hide-emphasis-markers t
org-link-file-path-type 'relative
org-ascii-format-drawer-function #[771 " \207" [] 4 "\n\n(fn NAME
CONTENTS WIDTH)"]
org-attach-store-link-p 'attached
org-catch-invisible-edits 'error
org-occur-hook '(org-first-headline-recenter)
outline-minor-mode-hook '(outshine--outline-minor-mode-hook)
org-log-into-drawer t
org-export-before-processing-hook
'(org-blackfriday--reset-org-blackfriday--code-block-num-backticks)
org-html-head-include-default-style nil
org-html-htmlize-output-type 'css
org-cycle-hook '(org-cycle-hide-archived-subtrees
org-cycle-show-empty-lines
org-optimize-window-after-visibility-change)
org-speed-command-hook '(org-speed-command-activate
org-babel-speed-command-activate)
org-odt-format-inlinetask-function 'org-odt-format-inlinetask-default-function
org-clock-display-default-range 'untilnow
org-confirm-shell-link-function 'yes-or-no-p
("eww" :follow eww :store org-eww-store-link) ("rmail" :follow
       org-rmail-open :store org-rmail-store-link)
("mhe" :follow org-mhe-open :store org-mhe-store-link)
("irc" :follow org-irc-visit :store org-irc-store-link :export
org-irc-export)
("info" :follow org-info-open :export org-info-export :store
org-info-store-link)
("gnus" :follow org-gnus-open :store org-gnus-store-link)
("docview" :follow org-docview-open :export org-docview-export
:store org-docview-store-link)
("bibtex" :follow org-bibtex-open :store org-bibtex-store-link)
("bbdb" :follow org-bbdb-open :export org-bbdb-export :complete
org-bbdb-complete-link :store
org-bbdb-store-link)
("w3m" :store org-w3m-store-link)
("orgit-rev" :store orgit-rev-store :follow orgit-rev-open
:export orgit-rev-export :complete
orgit-rev-complete-link)
("orgit-log" :store orgit-log-store :follow orgit-log-open
:export orgit-log-export :complete
orgit-log-complete-link)
("orgit" :store orgit-status-store :follow orgit-status-open
:export orgit-status-export :complete
orgit-status-complete-link)
("file+sys") ("file+emacs") ("shell" :follow org-link--open-shell)
("news" :follow #[257 "\301\300\302 Q!\207" ["news" browse-url
     ":"] 5 "\n\n(fn URL)"])
("mailto" :follow #[257 "\301\300\302 Q!\207" ["mailto"
       browse-url ":"] 5 "\n\n(fn URL)"])
("https" :follow #[257 "\301\300\302 Q!\207" ["https" browse-url
      ":"] 5 "\n\n(fn URL)"])
("http" :follow #[257 "\301\300\302 Q!\207" ["http" browse-url
     ":"] 5 "\n\n(fn URL)"])
("ftp" :follow #[257 "\301\300\302 Q!\207" ["ftp" browse-url
    ":"] 5 "\n\n(fn URL)"])
("help" :follow org-link--open-help) ("file" :complete
      org-link-complete-file)
("elisp" :follow org-link--open-elisp) ("doi" :
follow org-link--open-doi)
org-html-postamble nil
org-latex-format-headline-function 'org-latex-format-headline-default-function
org-link-elisp-confirm-function 'yes-or-no-p
org-latex-format-inlinetask-function
'org-latex-format-inlinetask-default-function
org-tab-before-tab-emulation-hook '(org-tempo-complete-tag)
org-html-format-drawer-function #[514 "\207" [] 3 "\n\n(fn NAME CONTENTS)"]
org-image-actual-width 200
outline-minor-mode-prefix "\243"
org-html-format-headline-function 'org-html-format-headline-default-function
org-use-speed-commands t
org-html-validation-link nil
org-list-allow-alphabetical t
))
  #+end_src

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Bug: broken org-cycle-include-plain-lists integrate [9.3.3 (9.3.3-elpa @ /home/bruce/.emacs.d/elpa/org-9.3.3/)]
  2020-02-09  8:08 Bug: broken org-cycle-include-plain-lists integrate [9.3.3 (9.3.3-elpa @ /home/bruce/.emacs.d/elpa/org-9.3.3/)] Bruce Tulloch
@ 2020-02-11  5:00 ` stardiviner
  2020-02-11  6:56   ` Bastien
  2020-02-11  6:57 ` Bastien
  1 sibling, 1 reply; 5+ messages in thread
From: stardiviner @ 2020-02-11  5:00 UTC (permalink / raw)
  To: Bruce Tulloch; +Cc: emacs-orgmode


This this related to recently new added option value.

#+begin_src emacs-lisp
(setq org-adapt-indentation 'headline-data)
#+end_src

It is introduced in commit "e3b79ad2bf7ab7b91c0ad2b8383d639bfe154ce7". Which
might breaks indentation of plain list etc.

Bruce Tulloch <bruce@metachip.com> writes:

> * Bug Report
>
>   (setq org-cycle-include-plain-lists 'integrate)
>
>   seems to have no effect.
>
>   That is, plain lists are no longer cycling as children of outline headings.
>
> * Example
>
>   This content appears when cycling on Example
>
>   * This plain list line appears (correct)
>     * this line also appears (incorrect)
>     * this one too (it shouldn't)
>   * but this one should appear (and does)
>   * as does this one but
>     * this should not (but does)
>       * and so does this one
> * Discussion
>
>   When cycling on the heading, plain lists always appears in the expanded state
>   since upgrading to 9.3.3. The plain list will not cycle (as children of the
>   heading). It appears that when org-cycle-include-plain-lists is 'integrate it
>   is behaving the same as when set to t.
>
>   This changed has appeared since 9.2.1 (which used to work).
> * Current State
>   #+begin_src elisp
>   (setq org-src-mode-hook '(org-src-babel-configure-edit-buffer
>     org-src-mode-configure-edit-buffer)
> org-link-shell-confirm-function 'yes-or-no-p
> org-html-head-include-scripts nil
> org-metadown-hook '(org-babel-pop-to-session-maybe)
> org-export-with-sub-superscripts '{}
> org-clock-out-hook '(org-clock-remove-empty-clock-drawer)
> org-html-format-inlinetask-function
> 'org-html-format-inlinetask-default-function
> org-edit-src-content-indentation 0
> org-odt-format-headline-function 'org-odt-format-headline-default-function
> org-ascii-format-inlinetask-function 'org-ascii-format-inlinetask-default
> org-cycle-include-plain-lists 'integrate
> org-archive-location "ARCHIVE.org::* %s"
> org-mode-hook '(org-tempo-setup org-clock-load
> navi-make-org-mode-promotion-headings-list #[0 "\301\211 \207"
>        [imenu-create-index-function org-imenu-get-tree] 2]
> #[0 "\300\301\302\303\304$\207" [add-hook change-major-mode-hook
>   org-show-all append local] 5]
> #[0 "\300\301\302\303\304$\207" [add-hook change-major-mode-hook
>   org-babel-show-result-all append local] 5]
> org-babel-result-hide-spec org-babel-hide-all-hashes)
> org-clock-persist 'history
> org-odt-format-drawer-function #[514 "\207" [] 3 "\n\n(fn NAME CONTENTS)"]
> org-archive-hook '(org-attach-archive-delete-maybe)
> org-confirm-elisp-link-function 'yes-or-no-p
> org-group-tags nil
> org-clock-history-length 50
> org-reverse-note-order t
> org-agenda-before-write-hook '(org-agenda-add-entry-text)
> org-metaup-hook '(org-babel-load-in-session-maybe)
> org-bibtex-headline-format-function #[257 "\300 \236A\207" [:title] 3
>   "\n\n(fn ENTRY)"]
> org-latex-format-drawer-function #[514 "\207" [] 3 "\n\n(fn _ CONTENTS)"]
> org-babel-pre-tangle-hook '(save-buffer)
> org-file-apps '((auto-mode . emacs) ("\\.mm\\'" . default)
> ("\\.x?html?\\'" . default) ("\\.pdf\\'" . "evince %s"))
> org-tab-first-hook '(org-babel-hide-result-toggle-maybe
>      org-babel-header-arg-expand)
> org-hide-leading-stars t
> org-export-initial-scope 'subtree
> org-html-text-markup-alist '((bold . "<b>%s</b>") (code .
> "<kbd>%s</kbd>") (italic . "<i>%s</i>")
> (strike-through . "<del>%s</del>") (underline . "<span
> class=\"underline\">%s</span>")
> (verbatim . "<code>%s</code>"))
> org-hide-emphasis-markers t
> org-link-file-path-type 'relative
> org-ascii-format-drawer-function #[771 " \207" [] 4 "\n\n(fn NAME
> CONTENTS WIDTH)"]
> org-attach-store-link-p 'attached
> org-catch-invisible-edits 'error
> org-occur-hook '(org-first-headline-recenter)
> outline-minor-mode-hook '(outshine--outline-minor-mode-hook)
> org-log-into-drawer t
> org-export-before-processing-hook
> '(org-blackfriday--reset-org-blackfriday--code-block-num-backticks)
> org-html-head-include-default-style nil
> org-html-htmlize-output-type 'css
> org-cycle-hook '(org-cycle-hide-archived-subtrees
> org-cycle-show-empty-lines
> org-optimize-window-after-visibility-change)
> org-speed-command-hook '(org-speed-command-activate
> org-babel-speed-command-activate)
> org-odt-format-inlinetask-function 'org-odt-format-inlinetask-default-function
> org-clock-display-default-range 'untilnow
> org-confirm-shell-link-function 'yes-or-no-p
> ("eww" :follow eww :store org-eww-store-link) ("rmail" :follow
>        org-rmail-open :store org-rmail-store-link)
> ("mhe" :follow org-mhe-open :store org-mhe-store-link)
> ("irc" :follow org-irc-visit :store org-irc-store-link :export
> org-irc-export)
> ("info" :follow org-info-open :export org-info-export :store
> org-info-store-link)
> ("gnus" :follow org-gnus-open :store org-gnus-store-link)
> ("docview" :follow org-docview-open :export org-docview-export
> :store org-docview-store-link)
> ("bibtex" :follow org-bibtex-open :store org-bibtex-store-link)
> ("bbdb" :follow org-bbdb-open :export org-bbdb-export :complete
> org-bbdb-complete-link :store
> org-bbdb-store-link)
> ("w3m" :store org-w3m-store-link)
> ("orgit-rev" :store orgit-rev-store :follow orgit-rev-open
> :export orgit-rev-export :complete
> orgit-rev-complete-link)
> ("orgit-log" :store orgit-log-store :follow orgit-log-open
> :export orgit-log-export :complete
> orgit-log-complete-link)
> ("orgit" :store orgit-status-store :follow orgit-status-open
> :export orgit-status-export :complete
> orgit-status-complete-link)
> ("file+sys") ("file+emacs") ("shell" :follow org-link--open-shell)
> ("news" :follow #[257 "\301\300\302 Q!\207" ["news" browse-url
>      ":"] 5 "\n\n(fn URL)"])
> ("mailto" :follow #[257 "\301\300\302 Q!\207" ["mailto"
>        browse-url ":"] 5 "\n\n(fn URL)"])
> ("https" :follow #[257 "\301\300\302 Q!\207" ["https" browse-url
>       ":"] 5 "\n\n(fn URL)"])
> ("http" :follow #[257 "\301\300\302 Q!\207" ["http" browse-url
>      ":"] 5 "\n\n(fn URL)"])
> ("ftp" :follow #[257 "\301\300\302 Q!\207" ["ftp" browse-url
>     ":"] 5 "\n\n(fn URL)"])
> ("help" :follow org-link--open-help) ("file" :complete
>       org-link-complete-file)
> ("elisp" :follow org-link--open-elisp) ("doi" :
> follow org-link--open-doi)
> org-html-postamble nil
> org-latex-format-headline-function 'org-latex-format-headline-default-function
> org-link-elisp-confirm-function 'yes-or-no-p
> org-latex-format-inlinetask-function
> 'org-latex-format-inlinetask-default-function
> org-tab-before-tab-emulation-hook '(org-tempo-complete-tag)
> org-html-format-drawer-function #[514 "\207" [] 3 "\n\n(fn NAME CONTENTS)"]
> org-image-actual-width 200
> outline-minor-mode-prefix "\243"
> org-html-format-headline-function 'org-html-format-headline-default-function
> org-use-speed-commands t
> org-html-validation-link nil
> org-list-allow-alphabetical t
> ))
>   #+end_src


-- 
[ stardiviner ]
       I try to make every word tell the meaning what I want to express.

       Blog: https://stardiviner.github.io/
       IRC(freenode): stardiviner, Matrix: stardiviner
       GPG: F09F650D7D674819892591401B5DF1C95AE89AC3
      

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Bug: broken org-cycle-include-plain-lists integrate [9.3.3 (9.3.3-elpa @ /home/bruce/.emacs.d/elpa/org-9.3.3/)]
  2020-02-11  5:00 ` stardiviner
@ 2020-02-11  6:56   ` Bastien
  2020-02-12  1:54     ` Bruce Tulloch
  0 siblings, 1 reply; 5+ messages in thread
From: Bastien @ 2020-02-11  6:56 UTC (permalink / raw)
  To: stardiviner; +Cc: Bruce Tulloch, emacs-orgmode

Hi Stardiviner,

stardiviner <numbchild@gmail.com> writes:

> This this related to recently new added option value.

the option was introduced just 2-3 hours before Bruce reported his
problem ;)

> #+begin_src emacs-lisp
> (setq org-adapt-indentation 'headline-data)
> #+end_src
>
> It is introduced in commit "e3b79ad2bf7ab7b91c0ad2b8383d639bfe154ce7". Which
> might breaks indentation of plain list etc.

I hope e3b79ad2 won't break anything but you're right, it can.

Thanks,

-- 
 Bastien

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Bug: broken org-cycle-include-plain-lists integrate [9.3.3 (9.3.3-elpa @ /home/bruce/.emacs.d/elpa/org-9.3.3/)]
  2020-02-09  8:08 Bug: broken org-cycle-include-plain-lists integrate [9.3.3 (9.3.3-elpa @ /home/bruce/.emacs.d/elpa/org-9.3.3/)] Bruce Tulloch
  2020-02-11  5:00 ` stardiviner
@ 2020-02-11  6:57 ` Bastien
  1 sibling, 0 replies; 5+ messages in thread
From: Bastien @ 2020-02-11  6:57 UTC (permalink / raw)
  To: Bruce Tulloch; +Cc: emacs-orgmode

Hi Bruce,

> * Bug Report
>
>   (setq org-cycle-include-plain-lists 'integrate)
>
>   seems to have no effect.

Thanks for reporting this.  Fixed now.  This was the consequence of
this commit: https://code.orgmode.org/bzg/org-mode/commit/c2aebcee27

Best,

-- 
 Bastien

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Bug: broken org-cycle-include-plain-lists integrate [9.3.3 (9.3.3-elpa @ /home/bruce/.emacs.d/elpa/org-9.3.3/)]
  2020-02-11  6:56   ` Bastien
@ 2020-02-12  1:54     ` Bruce Tulloch
  0 siblings, 0 replies; 5+ messages in thread
From: Bruce Tulloch @ 2020-02-12  1:54 UTC (permalink / raw)
  To: Bastien; +Cc: emacs-orgmode

[-- Attachment #1: Type: text/plain, Size: 655 bytes --]

Thanks for the prompt response guys! :01:nt3r448ppfurl90h:

On Tue, Feb 11, 2020 at 5:56 PM Bastien <bzg@gnu.org> wrote:

> Hi Stardiviner,
>
> stardiviner <numbchild@gmail.com> writes:
>
> > This this related to recently new added option value.
>
> the option was introduced just 2-3 hours before Bruce reported his
> problem ;)
>
> > #+begin_src emacs-lisp
> > (setq org-adapt-indentation 'headline-data)
> > #+end_src
> >
> > It is introduced in commit "e3b79ad2bf7ab7b91c0ad2b8383d639bfe154ce7".
> Which
> > might breaks indentation of plain list etc.
>
> I hope e3b79ad2 won't break anything but you're right, it can.
>
> Thanks,
>
> --
>  Bastien
>

[-- Attachment #2: Type: text/html, Size: 1209 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-02-12  1:55 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-09  8:08 Bug: broken org-cycle-include-plain-lists integrate [9.3.3 (9.3.3-elpa @ /home/bruce/.emacs.d/elpa/org-9.3.3/)] Bruce Tulloch
2020-02-11  5:00 ` stardiviner
2020-02-11  6:56   ` Bastien
2020-02-12  1:54     ` Bruce Tulloch
2020-02-11  6:57 ` Bastien

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).