Re: [PATCH] Margin added for overflow visibility problem

[Fatih Aydin <fataydin138@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1352 bytes --]

Thanks for the suggestion, it's okay for me. I just wanted to make sure
that the issue is clear for everyone by describing the steps.
I also agree with waiting for CSS gurus.

On Sun, Dec 13, 2020 at 6:56 AM Kyle Meyer <kyle@kyleam.com> wrote:

>
> Fatih Aydin writes:
>
> > Write a code block in an org file and publish it to a html file. You
> > will see that only bottom part of the name of the programming language
> > is visible when you hover on it because of the css of that block
> > (overflow:auto)
> > To fix this, a margin-top can be added.
>
> Ah, that's a nice visual improvement.  Thanks!
>
> To more closely follow conventions for commit messages in this project
> [1], I'd suggest to rewrite the message to something like this:
>
> --8<---------------cut here---------------start------------->8---
> Subject: [PATCH] ox-html: Add margin to fix overflow visibility problem
>
> * lisp/ox-html.el (org-html-style-default): Add the margin-top
> property to pre.src:hover:before so that the programming language is
> fully visible.
>
> TINYCHANGE
> --8<---------------cut here---------------end--------------->8---
>
> Does that look okay to you?  If so, I can amend your commit when
> applying.  (I'll wait a few more days for any CSS gurus on the list to
> weigh in.)
>
> [1] https://orgmode.org/worg/org-contribute.html#commit-messages
>

[-- Attachment #2: Type: text/html, Size: 1900 bytes --]