From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jacob Matthews Subject: [PATCH] org-mobile.org: Properly escape checksum binary path Date: Tue, 07 Apr 2015 18:33:18 +0000 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=001a11427064160d14051326a6d0 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:40289) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YfYPg-0007RR-Vb for emacs-orgmode@gnu.org; Tue, 07 Apr 2015 14:39:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YfYPd-0002aX-4J for emacs-orgmode@gnu.org; Tue, 07 Apr 2015 14:39:52 -0400 Received: from mail-ig0-f172.google.com ([209.85.213.172]:36712) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YfYKR-0000es-SN for emacs-orgmode@gnu.org; Tue, 07 Apr 2015 14:34:27 -0400 Received: by igblo3 with SMTP id lo3so20201629igb.1 for ; Tue, 07 Apr 2015 11:33:19 -0700 (PDT) List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org --001a11427064160d14051326a6d0 Content-Type: multipart/alternative; boundary=001a11427064160d0e051326a6ce --001a11427064160d0e051326a6ce Content-Type: text/plain; charset=UTF-8 Hi --- After lots of debugging last night on why MobileOrg wasn't seeing org-mode files I pushed from my Windows computer, I found a bug in org-mobile.el that appears to affect all platforms -- if the full path to the checksum binary contains a space then checksumming will silently fail. Attached is a fix. -jacob --001a11427064160d0e051326a6ce Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi ---

After lots of debugging last nig= ht on why MobileOrg wasn't seeing org-mode files I pushed from my Windo= ws computer, I found a bug in org-mobile.el that appears to affect all plat= forms -- if the full path to the checksum binary contains a space then chec= ksumming will silently fail.

Attached is a fix.

-jacob
--001a11427064160d0e051326a6ce-- --001a11427064160d14051326a6d0 Content-Type: text/x-patch; charset=US-ASCII; name="0001-org-mobile.org-Properly-escape-checksum-binary-path.patch" Content-Disposition: attachment; filename="0001-org-mobile.org-Properly-escape-checksum-binary-path.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: 14c95231db4177e03dd1 RnJvbSAzYTkyYjJhNTQxMWFhYmIwOTZhZDU5MmVmZTdkMmRjMDg1NjUzZWU2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKYWNvYiBNYXR0aGV3cyA8bWF0dGhld3NqQGdvb2dsZS5jb20+ CkRhdGU6IFR1ZSwgNyBBcHIgMjAxNSAxMjo1MjoyNSAtMDUwMApTdWJqZWN0OiBbUEFUQ0hdIG9y Zy1tb2JpbGUub3JnOiBQcm9wZXJseSBlc2NhcGUgY2hlY2tzdW0gYmluYXJ5IHBhdGgKCiogbGlz cC9vcmctbW9iaWxlLm9yZyAob3JnLW1vYmlsZS1jb3B5LWFnZW5kYS1maWxlcyk6IEVzY2FwZSBv cmctbW9iaWxlLWNoZWNrc3VtLWJpbmFyeS4KCkZpeCBhIGJ1ZyB3aGVyZSBpZiB0aGUgY2hlY2tz dW0gYmluYXJ5IGlzIGluIGEgbm9uIHNoZWxsLXNhZmUgcGF0aCwgdGhlbgp0aGUgc2hlbGwgaW52 b2NhdGlvbiBzaWxlbnRseSBmYWlscy4gVGhpcyBjYW4gaGFwcGVuIG9uIGFueSBwbGF0Zm9ybSBi dXQKaXMgcHJvYmFibHkgd29yc3Qgb24gV2luZG93cyB3aGVyZSBpdCdzIGNvbW1vbiB0byBwdXQg cHJvZ3JhbXMgaW4KIkM6L1Byb2dyYW0gRmlsZXMiLgotLS0KIGxpc3Avb3JnLW1vYmlsZS5lbCB8 IDMgKystCiAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCgpk aWZmIC0tZ2l0IGEvbGlzcC9vcmctbW9iaWxlLmVsIGIvbGlzcC9vcmctbW9iaWxlLmVsCmluZGV4 IGMyODI4YTkuLjJjMTM4MDIgMTAwNjQ0Ci0tLSBhL2xpc3Avb3JnLW1vYmlsZS5lbAorKysgYi9s aXNwL29yZy1tb2JpbGUuZWwKQEAgLTQ5OSw3ICs0OTksOCBAQCBhZ2VuZGEgdmlldyBzaG93aW5n IHRoZSBmbGFnZ2VkIGl0ZW1zLiIKIAkgICAgKG9yZy1tb2JpbGUtZW5jcnlwdC1hbmQtbW92ZSBm aWxlIHRhcmdldC1wYXRoKQogCSAgKGNvcHktZmlsZSBmaWxlIHRhcmdldC1wYXRoICdvay1pZi1l eGlzdHMpKQogCShzZXRxIGNoZWNrIChzaGVsbC1jb21tYW5kLXRvLXN0cmluZwotCQkgICAgIChj b25jYXQgb3JnLW1vYmlsZS1jaGVja3N1bS1iaW5hcnkgIiAiCisJCSAgICAgKGNvbmNhdCAoc2hl bGwtcXVvdGUtYXJndW1lbnQgb3JnLW1vYmlsZS1jaGVja3N1bS1iaW5hcnkpCisJCQkgICAgICIg IgogCQkJICAgICAoc2hlbGwtcXVvdGUtYXJndW1lbnQgKGV4cGFuZC1maWxlLW5hbWUgZmlsZSkp KSkpCiAJKHdoZW4gKHN0cmluZy1tYXRjaCAiW2EtZkEtRjAtOV1cXHszMCw0MFxcfSIgY2hlY2sp CiAJICAocHVzaCAoY29ucyBsaW5rLW5hbWUgKG1hdGNoLXN0cmluZyAwIGNoZWNrKSkKLS0gCjIu Mi4wLnJjMC4yMDcuZ2EzYTYxNmMKCg== --001a11427064160d14051326a6d0--