From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id cCAwF1kjqGLf4gAAbAwnHQ (envelope-from ) for ; Tue, 14 Jun 2022 07:57:45 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id GBEuF1kjqGIsVwAA9RJhRA (envelope-from ) for ; Tue, 14 Jun 2022 07:57:45 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CDC5E2868A for ; Tue, 14 Jun 2022 07:57:44 +0200 (CEST) Received: from localhost ([::1]:41234 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o0zYd-0006oL-TF for larch@yhetil.org; Tue, 14 Jun 2022 01:57:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59176) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o0zWg-0006nP-V0 for emacs-orgmode@gnu.org; Tue, 14 Jun 2022 01:55:43 -0400 Received: from mail-lj1-x22f.google.com ([2a00:1450:4864:20::22f]:42807) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o0zWe-0006B1-Q2 for emacs-orgmode@gnu.org; Tue, 14 Jun 2022 01:55:42 -0400 Received: by mail-lj1-x22f.google.com with SMTP id c30so8491277ljr.9 for ; Mon, 13 Jun 2022 22:55:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vicarious-living-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dVSRo0ibR2AMC5o7Q7Il/8y/xDYjE2XpeomCix9e4oM=; b=oQxgEv8hvdyDZgMp+436poa4BGITwwLzKU17aNv+gUmZYjlI4c5OwjJ23t0w/zaen8 +892oVdpgV6qlQqA4flSbQz/a7FQ08A0PeubcNORqR0VAPaE567snkx4KNe9Jc8tXKwj xQeowimLv1gWaKplrri7QobFYSSDFSI1ZL8rMACT8XjUOLJXuWuYjZAfCqwgDH0PGBfd PteSNhhAsWggEp/M2U9mry9DMebIivayswgBZpbIpM0IX/xxhNFr/tMvCbaA2qtr90n9 Z74rNTrjjdyC2AGzVJagcfnEZTxx9316AvVee4pDq85Lb64b4PxAO3n38sQvtcDhYzn9 D+Qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dVSRo0ibR2AMC5o7Q7Il/8y/xDYjE2XpeomCix9e4oM=; b=E7SAGo+v1azwxs37uLqu3M2cs1bXWLNU4+ebtw5cmFPk/Tu4oSPd93kK1MYbfkPJ1X qcLZXfJF/dQU3TtOQQOgEjk5JoumuMOICA5rLlmK3Pw5jN5T96u06Q+xbmmAhgGiK9O3 Qlj6UfVehxtPWoFwYfUSoR4ARanX6WRB6NzPNiWImZlc1oZWM+GUiHvWC2IribsrbRAK EIQmBw8M0hFFvWWV/Yn8rNRg/C7cpKFol2/kznpp/D+JLxBJsT+bvjDmQx8N7L5yRoGW hBALF6d7P7isODQczz7V7BGNZ2ncx1IFWMnNDHGs2jt4csgv4VCJZlySovnVZYvKbYKf pNNA== X-Gm-Message-State: AJIora9EmYB11S3PHSV9eFvq5IVIwZd04SZwsS6U2TtWinpp1kYA7eEW UUhl+ZgXZVd8qDJQfs4UMxB4lld7o2vKtcGKA53twQ== X-Google-Smtp-Source: AGRyM1s6mI43+PLox3wUxdxfC9QbE7qWqR98E0PAydPGgzqjBqmlDeZkoX1kAE6zqy1mwIZDBSFcKh7qovlG0wikMrg= X-Received: by 2002:a05:651c:158c:b0:250:a23d:2701 with SMTP id h12-20020a05651c158c00b00250a23d2701mr1539827ljq.475.1655186138257; Mon, 13 Jun 2022 22:55:38 -0700 (PDT) MIME-Version: 1.0 References: <981938.1630590273@apollo2.minshall.org> <87czpqjqvw.fsf@localhost> <87zgkey55y.fsf@localhost> <8735i5u039.fsf@localhost> <87h74rq0ql.fsf@localhost> <87czffbc0r.fsf@localhost> <87sfo7q3xs.fsf@localhost> In-Reply-To: <87sfo7q3xs.fsf@localhost> From: Ryan Scott Date: Mon, 13 Jun 2022 22:55:26 -0700 Message-ID: Subject: Re: [PATCH] Re: New source block results option for attaching file to node To: Ihor Radchenko Cc: numbchild@gmail.com, Greg Minshall , Timothy , emacs-orgmode@gnu.org Content-Type: multipart/alternative; boundary="000000000000cef3ff05e1620ddf" Received-SPF: none client-ip=2a00:1450:4864:20::22f; envelope-from=ryan@vicarious-living.com; helo=mail-lj1-x22f.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1655186265; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=dVSRo0ibR2AMC5o7Q7Il/8y/xDYjE2XpeomCix9e4oM=; b=FZLMHSCOQVsoP7uU34DUzzCeBRarPPbWrlJ/upE9vfBpFML0b/1zQWjdU8LyQlU48kGFAg A2gfJoAXK3T0P3/4FPOI+tdn3WUKjghwAXxHHNQ8/Id3Vbst9RQYzk0MO4JOvbR0ifFs/h OuT6GVTCfqL+e1GQprOHv3kLzjJTdD7VwOqtJwOCv8iL9YOgYtox74yKxq1SB4bHuGzCzK EdMO8SV6K4myA7jjlQWMfEHAZUHg9kPOKSxGFfcuogdZxSdWxT+WxeyajDxj/Zd0yN/7tY ErbZkdHd3z/B773mNjGva4qkgx24LG4YoRtpbav20cu1omObeGtwewVR7oArdA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1655186265; a=rsa-sha256; cv=none; b=b8AIdrKjUWfAKIJBawxyM94ckAekuSRSuCEcz5wAkBviePBpPH6LGzUsUsFtsbq7xUAQtP rymJURUMlQeV6RNPiCtb4T93yXbP/dLLoWS6eZVfqVNMGWuISraDWldAj23DGBUrjnUzup LEmNFQgNR7pDqvk8Q6+JEYPf5uHs+UMUJGyJDZVGjB7cOzF70/7qmCdbMCCf9K4vVk/2hS o3D7wsuTIXVsgFlgD8ByoPr2OVBPNoSKWjJ4n2F64xYAO4qfj6aFG6p0tDzq51UkgRrZDX ruz4osx90NzyumHG9MIvvtDKqxqEYAjtQh7dTtR3xAetSNertuJJZ3M2Mjodyw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=vicarious-living-com.20210112.gappssmtp.com header.s=20210112 header.b=oQxgEv8h; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -6.99 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=vicarious-living-com.20210112.gappssmtp.com header.s=20210112 header.b=oQxgEv8h; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: CDC5E2868A X-Spam-Score: -6.99 X-Migadu-Scanner: scn0.migadu.com X-TUID: CZenVmE0RiH5 --000000000000cef3ff05e1620ddf Content-Type: text/plain; charset="UTF-8" Strange. I'll figure out a better setup for running the tests and get to the bottom of that. Thanks for the help. On Tue, Jun 14, 2022, 00:10 Ihor Radchenko wrote: > Ryan Scott writes: > > > Ah sorry about that. I'm on a windows laptop and didn't have make, so was > > testing interactively and they were passing. > > I cleaned that up and remove the f-* usage and verified under Ubuntu (on > > WSL) that the new tests are passing. I was getting some failures with > > unrelated tests, but also get those in master as well. > > I am still getting test failures using Emacs 28. > All the tests are passing on main. > > Example backtrace: > > file-name-directory(nil) > org-babel-result-to-file("/tmp/test.txt" nil attachment) > org-babel-insert-result("/tmp/test.txt" ("replace" "value" "file" "g > org-babel-execute-src-block() > (progn (org-mode) (let ((point (string-match "" inside-text)) > (unwind-protect (progn (org-mode) (let ((point (string-match " (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn > (let ((temp-buffer (generate-new-buffer " *temp*" t))) (save-current > (let ((inside-text (if (stringp "\n#+begin_src shell :results > (let ((lexical-binding nil)) (let ((inside-text (if (stringp "\n (lambda nil (let ((lexical-binding nil)) (let ((inside-text (if (str > ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test > ert-run-test(#s(ert-test :name test-ob/result-graphics-link-type-hea > ert-run-or-rerun-test(#s(ert--stats :selector "test-ob" :tests ... : > ert-run-tests("test-ob" #f(compiled-function (event-type &rest event > ert-run-tests-batch("test-ob") > ert-run-tests-batch-and-exit("test-ob") > (let ((org-id-track-globally t) (org-test-selector (if org-test-sele > org-test-run-batch-tests("test-ob") > command-line-1(("--eval" "(setq vc-handled-backends nil org-startup- > command-line() > normal-top-level() > Test test-ob/result-graphics-link-type-header-argument condition: > (wrong-type-argument stringp nil) > FAILED 129/140 test-ob/result-graphics-link-type-header-argument > (0.006189 sec) > > Best, > Ihor > --000000000000cef3ff05e1620ddf Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Strange. I'll figure out a better se= tup for running the tests and get to the bottom of that.
Thanks f= or the help.

On Tue, Jun 14, 2022, 00:10 Ihor Radchenko <yantar92@gmail.com> wr= ote:
Ryan Scott = <ryan@vicarious-living.com> writes:

> Ah sorry about that. I'm on a windows laptop and didn't have m= ake, so was
> testing interactively and they were passing.
> I cleaned that up and remove the f-* usage and verified under Ubuntu (= on
> WSL) that the new tests are passing. I was getting some failures with<= br> > unrelated tests, but also get those in master as well.

I am still getting test failures using Emacs 28.
All the tests are passing on main.

Example backtrace:

file-name-directory(nil)
=C2=A0 org-babel-result-to-file("/tmp/test.txt" nil attachment) =C2=A0 org-babel-insert-result("/tmp/test.txt" ("replace&quo= t; "value" "file" "g
=C2=A0 org-babel-execute-src-block()
=C2=A0 (progn (org-mode) (let ((point (string-match "<point>&quo= t; inside-text))
=C2=A0 (unwind-protect (progn (org-mode) (let ((point (string-match "&= lt;point
=C2=A0 (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn=
=C2=A0 (let ((temp-buffer (generate-new-buffer " *temp*" t))) (sa= ve-current
=C2=A0 (let ((inside-text (if (stringp "\n<point>#+begin_src she= ll :results
=C2=A0 (let ((lexical-binding nil)) (let ((inside-text (if (stringp "\= n<poi
=C2=A0 (lambda nil (let ((lexical-binding nil)) (let ((inside-text (if (str=
=C2=A0 ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test=
=C2=A0 ert-run-test(#s(ert-test :name test-ob/result-graphics-link-type-hea=
=C2=A0 ert-run-or-rerun-test(#s(ert--stats :selector "test-ob" :t= ests ... :
=C2=A0 ert-run-tests("test-ob" #f(compiled-function (event-type &= amp;rest event
=C2=A0 ert-run-tests-batch("test-ob")
=C2=A0 ert-run-tests-batch-and-exit("test-ob")
=C2=A0 (let ((org-id-track-globally t) (org-test-selector (if org-test-sele=
=C2=A0 org-test-run-batch-tests("test-ob")
=C2=A0 command-line-1(("--eval" "(setq vc-handled-backends n= il org-startup-
=C2=A0 command-line()
=C2=A0 normal-top-level()
Test test-ob/result-graphics-link-type-header-argument condition:
=C2=A0 =C2=A0 (wrong-type-argument stringp nil)
=C2=A0 =C2=A0FAILED=C2=A0 129/140=C2=A0 test-ob/result-graphics-link-type-h= eader-argument (0.006189 sec)

Best,
Ihor
--000000000000cef3ff05e1620ddf--