From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Vorobiev Subject: Re: org mode R remote code evaluation Date: Tue, 24 Sep 2013 23:24:33 -0500 Message-ID: References: <87d2ownbtv.fsf@hornfels.zedat.fu-berlin.de> <87r4ce2x8k.fsf@gmx.de> <87mwn22vy8.fsf@gmx.de> <878uymyser.fsf@gmx.de> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=047d7b33d956895eb404e72da233 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:56475) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VOgem-0002Mx-Go for emacs-orgmode@gnu.org; Wed, 25 Sep 2013 00:24:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VOgel-0006zY-95 for emacs-orgmode@gnu.org; Wed, 25 Sep 2013 00:24:56 -0400 Received: from mail-pb0-x229.google.com ([2607:f8b0:400e:c01::229]:46052) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VOgek-0006zH-TV for emacs-orgmode@gnu.org; Wed, 25 Sep 2013 00:24:55 -0400 Received: by mail-pb0-f41.google.com with SMTP id rp2so5504182pbb.0 for ; Tue, 24 Sep 2013 21:24:53 -0700 (PDT) In-Reply-To: <878uymyser.fsf@gmx.de> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Michael Albinus Cc: Loris Bennett , emacs-orgmode , Johannes Rainer --047d7b33d956895eb404e72da233 Content-Type: text/plain; charset=ISO-8859-1 Hi Michael, The patch seems to be working, the only thing I noticed is having http://www.emacswiki.org/emacs/setup-cygwin.el loaded together with the patched ob-core.el makes tramp prepend "/cygwin" to /tmp/. When I disabled (require 'setup-cygwin) the patch works as expected. Outside of org/babel setup-cygwin has no effect on Tramp. Thanks, Alex On Tue, Sep 24, 2013 at 1:40 PM, Michael Albinus wrote: > Alexander Vorobiev writes: > > > Hi Michael, > > Hi Alex, > > > Here it is. > > Thanks. I believe, the following patch shall cure it: > > --8<---------------cut here---------------start------------->8--- > --- a/lisp/ob-core.el > +++ b/lisp/ob-core.el > @@ -2735,8 +2735,12 @@ > value of `temporary-file-directory' temporarily set to the value > of `org-babel-temporary-directory'." > (if (file-remote-p default-directory) > (let ((prefix > + ;; We cannot use `temporary-file-directory' as local part > + ;; on the remote host, because it might be another OS > + ;; there. So we assume "/tmp", which ought to exist on > + ;; relevant architectures. > (concat (file-remote-p default-directory) > - (expand-file-name prefix temporary-file-directory)))) > + (expand-file-name prefix "/tmp/")))) > (make-temp-file prefix nil suffix)) > (let ((temporary-file-directory > (or (and (boundp 'org-babel-temporary-directory) > --8<---------------cut here---------------end--------------->8--- > > Could you, please, test? > > > Thanks, > > Alex > > Best regards, Michael. > --047d7b33d956895eb404e72da233 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
Hi Michael,

The patch seems to be worki= ng, the only thing I noticed is having=A0http://www.emacswiki.org/emacs/setup-cygwin.el= =A0loaded together with the patched ob-core.el makes tramp prepend "/c= ygwin" to /tmp/. When I disabled (require 'setup-cygwin) the patch= works as expected. Outside of org/babel setup-cygwin has no effect on Tram= p.

Thanks,
Alex


On Tue, Sep 24, 2013 at 1:40 PM, M= ichael Albinus <michael.albinus@gmx.de> wrote:
Alexander Vorobiev <alexander.vorobiev@gmail.com> writes:

> Hi Michael,

Hi Alex,

> Here it is.

Thanks. I believe, the following patch shall cure it:

--8<---------------cut here---------------start------------->8---
--- a/lisp/ob-core.el
+++ b/lisp/ob-core.el
@@ -2735,8 +2735,12 @@
=A0value of `temporary-file-directory' temporarily set to the value
=A0of `org-babel-temporary-directory'."
=A0 =A0(if (file-remote-p default-directory)
=A0 =A0 =A0 =A0(let ((prefix
+ =A0 =A0 =A0 =A0 =A0 =A0;; We cannot use `temporary-file-directory' as= local part
+ =A0 =A0 =A0 =A0 =A0 =A0;; on the remote host, because it might be another= OS
+ =A0 =A0 =A0 =A0 =A0 =A0;; there. =A0So we assume "/tmp", which = ought to exist on
+ =A0 =A0 =A0 =A0 =A0 =A0;; relevant architectures.
=A0 =A0 =A0 =A0 =A0 =A0 =A0 (concat (file-remote-p default-directory)
- =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 (expand-file-name prefix temporar= y-file-directory))))
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 (expand-file-name prefix "/t= mp/"))))
=A0 =A0 =A0 =A0 =A0(make-temp-file prefix nil suffix))
=A0 =A0 =A0(let ((temporary-file-directory
=A0 =A0 =A0 =A0 =A0 =A0(or (and (boundp 'org-babel-temporary-directory)=
--8<---------------cut here---------------end--------------->8---

Could you, please, test?

> Thanks,
> Alex

Best regards, Michael.

--047d7b33d956895eb404e72da233--