From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kaushal Modi Subject: Re: New package: ox-minutes [Please critique] Date: Wed, 10 Aug 2016 16:29:11 +0000 Message-ID: References: <87fuqctxa0.fsf@oremacs.com> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a11441494d112170539ba26a2 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:58558) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bXWNg-0005SF-JL for emacs-orgmode@gnu.org; Wed, 10 Aug 2016 12:29:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bXWNe-0007Rs-Bb for emacs-orgmode@gnu.org; Wed, 10 Aug 2016 12:29:23 -0400 Received: from mail-oi0-x22c.google.com ([2607:f8b0:4003:c06::22c]:36082) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bXWNe-0007Ro-5W for emacs-orgmode@gnu.org; Wed, 10 Aug 2016 12:29:22 -0400 Received: by mail-oi0-x22c.google.com with SMTP id f189so66199318oig.3 for ; Wed, 10 Aug 2016 09:29:22 -0700 (PDT) In-Reply-To: <87fuqctxa0.fsf@oremacs.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Oleh Krehel Cc: emacs-org list --001a11441494d112170539ba26a2 Content-Type: text/plain; charset=UTF-8 On Wed, Aug 10, 2016 at 12:16 PM Oleh Krehel wrote: > Congrats on your first package! It will surely come in handy when > interacting with my less Emacs-enlightened colleagues. I recall one of > them writing very similar-looking notes in Microsoft Outlook. One or two > times I had to send them some notes, I actually did by hand the > transformation that `ox-minutes' now does. > Yeah, I had to do that so many times by hand and I kept on thinking that 'some day' I will fix this. > The coding looks fine. Just a suggestion: I think "\n" looks better than > a literal string newline. > Strange, I assure you that I already tried that and it did not work. But it DOES work. So that regexp probably had a lot of non-working components earlier. I will fix this; I anyways did not like the literal newline :) It would be cool to have a regression test with: > > ./ox-minutes/ox-minutes-test.el > ./ox-minutes/test_input.org > ./ox-minutes/test_output.txt > > Both test_input.org and test_output.txt could be moved from README.md. > Good point. Learning to use ert is on my 'some day' list. I will eventually get to it. Thanks for the feedback! -- Kaushal Modi --001a11441494d112170539ba26a2 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On Wed, Aug 10= , 2016 at 12:16 PM Oleh Krehel <oleh= @oremacs.com> wrote:
Congrat= s on your first package! It will surely come in handy when
interacting with my less Emacs-enlightened colleagues. I recall one of
them writing very similar-looking notes in Microsoft Outlook. One or two times I had to send them some notes, I actually did by hand the
transformation that `ox-minutes' now does.

Yeah, I had to do that so many times by hand and I kept on thinking= that 'some day' I will fix this.
=C2=A0
The coding looks fine. Just a suggestion: I think "\n" looks bett= er than
a literal string newline.

Strange, I as= sure you that I already tried that and it did not work. But it DOES work. S= o that regexp probably had a lot of non-working components earlier. I will = fix this; I anyways did not like the literal newline :)

It would be cool to have a regression test with:

=C2=A0 =C2=A0 ./ox-minutes/ox-minutes-test.el
=C2=A0 =C2=A0 ./ox-minutes/test_input.org
=C2=A0 =C2=A0 ./ox-minutes/test_output.txt

Both test_input.org and test_output.txt could be moved from README.md.
<= /blockquote>
=C2=A0
Good point. Learning to use ert is on my = 'some day' list. I will eventually get to it.

<= div>Thanks for the feedback!
--

Ka= ushal Modi

--001a11441494d112170539ba26a2--