From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kaushal Modi Subject: Re: [PATCH] org-capture: Add a custom to control save target file or not. Date: Thu, 13 Dec 2018 10:08:33 -0500 Message-ID: References: <19dc1211.1e75.162b770bd5c.Coremail.tumashu@163.com> <87po34y2ya.fsf@nicolasgoaziou.fr> <77a63bcf.32cc.162bcc4a5d0.Coremail.tumashu@163.com> <877epap70f.fsf@nicolasgoaziou.fr> <875zyro5jz.fsf@gmail.com> <87sh1t5ots.fsf@nicolasgoaziou.fr> <87o9cg6ci3.fsf@nicolasgoaziou.fr> <87sh1szjhf.fsf@gmail.com> <3C79C151-715A-4BF7-8CBF-63614A723721@scratch.space> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000005ec760057ce8b2b1" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:41456) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gXSc7-0000Xm-Uv for emacs-orgmode@gnu.org; Thu, 13 Dec 2018 10:09:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gXSc2-0001nf-T2 for emacs-orgmode@gnu.org; Thu, 13 Dec 2018 10:09:23 -0500 In-Reply-To: <3C79C151-715A-4BF7-8CBF-63614A723721@scratch.space> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Nicolas Goaziou Cc: van@scratch.space, Eric Abrahamsen , emacs-org list , Bastien Guerry --0000000000005ec760057ce8b2b1 Content-Type: text/plain; charset="UTF-8" Hello Nicolas, While we are planning to cut Org 9.2 release this week, this one regression in the Org Capture and auto-saving behavior comes to my mind, that I think should be fixed. Summary: In Org 9.1.x, org-capture target files got auto-saved after C-c C-c when ending the capture. In Org master branch, that stopped happening. As per your last proposal, we should revert https://code.orgmode.org/bzg/org-mode/commit/b4422add3745c26ec3b2e11b8da425844b2e9d3d and then add a :no-save option that skips that save-buffer call. Past references: - https://lists.gnu.org/r/emacs-orgmode/2018-04/msg00204.html - https://lists.gnu.org/r/emacs-orgmode/2018-09/msg00325.html -- Kaushal Modi On Sat, Sep 29, 2018 at 6:36 AM Van L wrote: > > >> Then saving should be the default again, and not saving optional. > > > > I believe this would be the best option. > > Very, very strongly concur with this belief. > > --0000000000005ec760057ce8b2b1 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
He= llo Nicolas,

While we are planning to cut Org 9.2 = release this week, this one regression in the Org Capture and auto-saving b= ehavior comes to my mind, that I think should be fixed.

Summary:

In Org 9.1.x, org-capture target fi= les got auto-saved after C-c C-c when ending the capture. In Org master bra= nch, that stopped happening.

As per your last prop= osal, we should revert https://code.orgmode.org/bzg/= org-mode/commit/b4422add3745c26ec3b2e11b8da425844b2e9d3d and then add a= :no-save option that skips that save-buffer call.

=
Past references:

--
Kaushal Modi

On Sat, = Sep 29, 2018 at 6:36 AM Van L <van@scratch.space> wrote:

>> Then saving should be the default again, and not saving optional.<= br> >
> I believe this would be the best option.

Very, very strongly concur with this belief.

--0000000000005ec760057ce8b2b1--