From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id ACpkA+UzrGFStAAAgWs5BA (envelope-from ) for ; Sun, 05 Dec 2021 04:37:09 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id uHrEOuQzrGFtYQAA1q6Kng (envelope-from ) for ; Sun, 05 Dec 2021 03:37:08 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8F5E62BE93 for ; Sun, 5 Dec 2021 04:37:08 +0100 (CET) Received: from localhost ([::1]:49120 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mtiKo-0001g7-1c for larch@yhetil.org; Sat, 04 Dec 2021 22:37:06 -0500 Received: from eggs.gnu.org ([209.51.188.92]:50410) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mtiK5-0001fw-CG for emacs-orgmode@gnu.org; Sat, 04 Dec 2021 22:36:21 -0500 Received: from [2a00:1450:4864:20::432] (port=33769 helo=mail-wr1-x432.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mtiK3-0004m4-3b for emacs-orgmode@gnu.org; Sat, 04 Dec 2021 22:36:21 -0500 Received: by mail-wr1-x432.google.com with SMTP id d24so14770194wra.0 for ; Sat, 04 Dec 2021 19:36:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jzCVfJuNyedXl/P4KaMxppOxML3RIWg42LFqAkNyTfk=; b=XWbbycf71C6i3ho8xgezlEDsr+gxVrok2g4lBv3BDcUlzA2xuPTsaL2UDxI75iWVHI 5U6CzeX8gLN8TrhYbYQtwUXq2aWFF6IWH7uCbUJOSA/6dnMT7onPk4viPP5z3vxcXiEv +gzN5ShW97+johUzeaYUlDZCEIQdIoCkktRyI/tOy0qpjyJDC13Y/gY2csW+txZFfOu/ IqEtFKvHcO7TrACjLVWtZZNaHBFBsEJQA7SGSPStTx2vvpt+fbpxWtDB5Z/N2LuHSScW 7cleOZa22rPxm+pQCHxNwBtwHcbQ/Dpu2eG7xzNwJbU6b4zPtssWG12fVLpVxhAC+S9/ 8pew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jzCVfJuNyedXl/P4KaMxppOxML3RIWg42LFqAkNyTfk=; b=YEt3whGsbSuAHo7noTcKCfb++eK4itd4CoFuidC5BDdH6YWplDVEWSjihefPr2xy7i IpBpL037dBftah3052jAoGNgGeINQ12Q/lM9nksVAAuDG5linZPl7jXgGW44rtMn7HMW Qhf2iW4+4LdFjPeFr23Ttn3uQ4mF/oW9W5T3z204abPFYON5jnYbb7cyEBP89vi25sZ7 BeIwPkIvrh/h9oeN6ERIJseJc2NkwfQYLewwpPWF3d5x9IIiHNhZj3xwXRRkDLUbqEcX MM96L1B20sTAVdUu8uvaL2B0UqgM67cVZV08QVnpGZGNl3VAL237YNCXxvctBrsjEkj0 jOFA== X-Gm-Message-State: AOAM530vVB9kbcPAa3kfNPqXJ/OMBmn2PWOlazye3r/PAwvbQWnVzdxJ 3/s3t/4OO9KuOkoWl1+8FHeb68+78CzXXjThAHE= X-Google-Smtp-Source: ABdhPJx7QrTkCVJDsxDEHzOh+Wi7zBUXs2o2CsjpuYwGTSvfEGVDfS0PjVZwfH5WTVojIFxtKcyM29XTb1QazJrnf9Y= X-Received: by 2002:a05:6000:1a41:: with SMTP id t1mr33517133wry.261.1638675377083; Sat, 04 Dec 2021 19:36:17 -0800 (PST) MIME-Version: 1.0 References: <87lf18fue9.fsf@aquinas.i-did-not-set--mail-host-address--so-tickle-me> <87v90cpcdx.fsf@yandex.com> <87ilwcf31l.fsf@aquinas.i-did-not-set--mail-host-address--so-tickle-me> <87pmqjkai3.fsf@gmail.com> <87fsrffknl.fsf@aquinas.i-did-not-set--mail-host-address--so-tickle-me> <87czmijtrp.fsf@gmail.com> <87o861o9sh.fsf@aquinas.i-did-not-set--mail-host-address--so-tickle-me> <87h7btpfbt.fsf@gmail.com> <87zgpli5nc.fsf@gmail.com> <871r2suhw2.fsf@gmail.com> In-Reply-To: <871r2suhw2.fsf@gmail.com> From: Kaushal Modi Date: Sat, 4 Dec 2021 22:36:07 -0500 Message-ID: Subject: Re: [PATCH] Fix org-comment-line-break-function To: Tim Cross Content-Type: multipart/alternative; boundary="000000000000c0d82005d25dd7c8" X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::432 (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::432; envelope-from=kaushal.modi@gmail.com; helo=mail-wr1-x432.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Lawrence , Marco Wahl , emacs-org list , Nicolas Goaziou Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1638675428; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=jzCVfJuNyedXl/P4KaMxppOxML3RIWg42LFqAkNyTfk=; b=XhztFoPOLvfrkEVcrmOjM1y4ZEfDx/M9H942JWAGbtRgjT/sh4OJw0oa7iO4b/fld5d4fr SO4Ca/VlUor31ubK2O3jRNjh32CnxtRrfSo6K5xJQiPiA+iKyMWWwGbxX76IQd7PyWvaj9 G7AV2N+2x2gDZZizCo8lAdIcsl5/3FbX6xw/fdIxRL71Z3nApwitf0TE1XEomMoz6tjlN9 fs2Bwp3UOzV713s3l7jtIq0MBuSMh8YRWt336VMawfrU6EVq4fMGJd/jfMxPbRTNSJrORn O4Q3Eq+bJQBcmljVKsZoJK8iAHuFyda+1gjTXyQmUXhCRk+fCpzscr10brhDmA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1638675428; a=rsa-sha256; cv=none; b=fGUSt333b/XW/3vB2429qSyDYibNTEf9uYNmB6eaV3D4egr3h2q6CFaqwWsu623VEd/Z2G nraw8yFmz59DgXS5r/avsL103DRQBYSqYkkOTL91ektwpFvfSXCB2rP2NLDg/+xoFiNvlT jdZg337ibfofmp9bcS8TpHlZFyzLteISMM97tGmpMbSprl3wkdaw2SECmfOucagbaBBLEF kR6EkZx59rDRH3Pwcj3pu+CCJmhWD52pilZRZdq5C12qbkEXTq1vuLvJjVpGMI+5kQl2CL yz7VQBFrozqJWK9/N1Kvvgc7KdXrd1rx5edPI4Qxbo254MCEq0xHz/ebouLWSw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=XWbbycf7; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.83 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=XWbbycf7; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 8F5E62BE93 X-Spam-Score: -1.83 X-Migadu-Scanner: scn0.migadu.com X-TUID: BsG4XwK6xB29 --000000000000c0d82005d25dd7c8 Content-Type: text/plain; charset="UTF-8" On Sat, Dec 4, 2021, 5:25 PM Tim Cross wrote: > > Given that Nicholas cannot remember the reason for the original function > and suspects it was meant to be an internal only function, I think this > patch is probably the best way forward and should be applied. > Thanks. Nicolas asked me to add tests for this patch. But I need to look into how to add tests for behavior of bindings. Need to add tests for M-j binding behavior when cursor is within a comment or outside. > --000000000000c0d82005d25dd7c8 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Sat, Dec 4, 2021, 5:25 PM Tim Cross <theophilusx@gmail.com> wrote:

Given that Nicholas cannot remember the reason for the original function and suspects it was meant to be an internal only function, I think this
patch is probably the best way forward and should be applied.

Thanks. Nicola= s asked me to add tests for this patch. But I need to look into how to add = tests for behavior of bindings. Need to add tests for M-j binding behavior = when cursor is within a comment or outside.=C2=A0
--000000000000c0d82005d25dd7c8--