From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kaushal Modi Subject: Re: Backward incompatible outline-invisible-p change in emacs master for Org Date: Thu, 15 Jun 2017 12:16:05 +0000 Message-ID: References: <87a85i2nji.fsf@nicolasgoaziou.fr> <87mv9ay02y.fsf@bzg.fr> <1497472089.767910.1009650952.07E5CDA4@webmail.messagingengine.com> <87a859n56z.fsf@bzg.fr> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="001a113c2f50b8c1ec0551fea298" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:34214) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dLThF-0005Q2-A2 for emacs-orgmode@gnu.org; Thu, 15 Jun 2017 08:16:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dLThE-00015X-Dd for emacs-orgmode@gnu.org; Thu, 15 Jun 2017 08:16:21 -0400 In-Reply-To: <87a859n56z.fsf@bzg.fr> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Bastien Guerry , Nicolas Goaziou Cc: Paul Rankin , emacs-org list --001a113c2f50b8c1ec0551fea298 Content-Type: text/plain; charset="UTF-8" On Thu, Jun 15, 2017, 2:19 AM Bastien Guerry wrote: > Kaushal, thanks for the fix, please go > ahead and commit it. > Before I commit this to master, I was thinking that this patch looks safe enough for the maint branch. If there are no objections, I can commit this to maint and merge to master. The patch adds a new function org-invisible-p whose definition is the same as outline-invisible-p from emacs 25.2 and refactors all instances of outline-invisible-p with org-invisible-p. So the change will be transparent for people using emacs stable releases. But as a plus, people using emacs master + org maint will get this bug fix too. > -- Kaushal Modi --001a113c2f50b8c1ec0551fea298 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Thu, Jun 15= , 2017, 2:19 AM Bastien Guerry <bzg@gnu.org> wrote:
Kaushal, thanks for the fix, please go
ahead and commit it.

Before I com= mit this to master, I was thinking that this patch looks safe enough for th= e maint branch. If there are no objections, I can commit this to maint and = merge to master.

The patch adds a new function org= -invisible-p whose definition is the same as outline-invisible-p from emacs= 25.2 and refactors all instances of outline-invisible-p with org-invisible= -p. So the change will be transparent for people using emacs stable release= s.

But as a plus, people using emacs master + org = maint will get this bug fix too.=C2=A0
--

Kaushal Modi

--001a113c2f50b8c1ec0551fea298--