From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kaushal Modi <kaushal.modi@gmail.com>
Subject: Re: [PATCH] org-capture: Add a custom to control save target file or
 not.
Date: Wed, 26 Sep 2018 13:11:11 -0400
Message-ID: <CAFyQvY2jqsn4JEkdwJhASrZM5rBqbRbz2dC_uqn8eRKDg_ZUTw@mail.gmail.com>
References: <19dc1211.1e75.162b770bd5c.Coremail.tumashu@163.com>
	<87po34y2ya.fsf@nicolasgoaziou.fr>
	<77a63bcf.32cc.162bcc4a5d0.Coremail.tumashu@163.com>
	<877epap70f.fsf@nicolasgoaziou.fr>
	<de3a784.4406.162c388d5ba.Coremail.tumashu@163.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52301)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kaushal.modi@gmail.com>) id 1g5DLr-0007bL-ND
	for emacs-orgmode@gnu.org; Wed, 26 Sep 2018 13:11:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kaushal.modi@gmail.com>) id 1g5DLq-0003CT-Ox
	for emacs-orgmode@gnu.org; Wed, 26 Sep 2018 13:11:51 -0400
Received: from mail-lj1-x241.google.com ([2a00:1450:4864:20::241]:43456)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <kaushal.modi@gmail.com>)
	id 1g5DLq-00037Q-Go
	for emacs-orgmode@gnu.org; Wed, 26 Sep 2018 13:11:50 -0400
Received: by mail-lj1-x241.google.com with SMTP id r8-v6so330882ljc.10
	for <emacs-orgmode@gnu.org>; Wed, 26 Sep 2018 10:11:50 -0700 (PDT)
In-Reply-To: <de3a784.4406.162c388d5ba.Coremail.tumashu@163.com>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: tumashu <tumashu@163.com>
Cc: emacs-org list <emacs-orgmode@gnu.org>, Nicolas Goaziou <mail@nicolasgoaziou.fr>

On Sat, Apr 14, 2018 at 5:43 AM tumashu <tumashu@163.com> wrote:
>
> At 2018-04-14 15:44:00, "Nicolas Goaziou" <mail@nicolasgoaziou.fr> wrote:
> >Hello,
> >
> >tumashu  <tumashu@163.com> writes:
> >
> >> I do not know why must save-buffer, may be for  information safe :-)
> >
> >If there is no objection, I suggest to simply remove this call to
> >`save-buffer' instead of introducing a new variable.
> >
>
> Agree this idea,  If user want to save-buffer when capture finish, they can
> add save-buffer to org-capture-after-finalize-hook  or just type C-x C-s

I just stumbled across this today; the relevant commit
https://code.orgmode.org/bzg/org-mode/commit/b4422add3745c26ec3b2e11b8da425844b2e9d3d

I had been wondering for quite some time (about since 5 months :P) why
my Org captures have stopped auto-saving.

Today I started looking into it, and found that commit.

I believe this 1-liner commit is a pretty serious change. Users used
to have they captures safely auto-saved might be in for a surprise. So
just wanted to write this email about it. This commit does not affect
the stable releases of Org so far (9.1). This change is present only
on master as of today.

I'll add a note about this to NEWS on master branch.