From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kaushal Modi <kaushal.modi@gmail.com>
Subject: Re: [PATCH] org-capture: Add a custom to control save target file or
 not.
Date: Thu, 13 Dec 2018 14:12:13 -0500
Message-ID: <CAFyQvY2TtByPtTmxeX9d+Jcdop56gKZFNuOrkdoT5+UKLdKF_Q@mail.gmail.com>
References: <19dc1211.1e75.162b770bd5c.Coremail.tumashu@163.com>
	<87po34y2ya.fsf@nicolasgoaziou.fr>
	<77a63bcf.32cc.162bcc4a5d0.Coremail.tumashu@163.com>
	<877epap70f.fsf@nicolasgoaziou.fr>
	<de3a784.4406.162c388d5ba.Coremail.tumashu@163.com>
	<CAFyQvY2jqsn4JEkdwJhASrZM5rBqbRbz2dC_uqn8eRKDg_ZUTw@mail.gmail.com>
	<875zyro5jz.fsf@gmail.com>
	<CAFyQvY2TKQWGVExB0o50CgcissD3Y3HOsO5L=MS=gYdZPbeY6w@mail.gmail.com>
	<CAFyQvY0ha85xX-v1MWGY9JO9a-B-SS-v=WzVvfEsUsA58jHSKg@mail.gmail.com>
	<87sh1t5ots.fsf@nicolasgoaziou.fr>
	<CAFyQvY1b8-VqkUH6uTnCyKC63E1UUaaePp5sDwmu+_dyz1uWgg@mail.gmail.com>
	<87o9cg6ci3.fsf@nicolasgoaziou.fr> <87sh1szjhf.fsf@gmail.com>
	<3C79C151-715A-4BF7-8CBF-63614A723721@scratch.space>
	<CAFyQvY3k6ozPk5TUyPBhyxCi7WmtiZuzT9wiDfQE60C_S2G9qg@mail.gmail.com>
	<CAFyQvY3Onmh=k7VDqZdZSjL8TDFCEDXGypwPuCF0k9WOeBZ_PA@mail.gmail.com>
	<87o99p4cna.fsf@nicolasgoaziou.fr>
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="000000000000d3396a057cec190e"
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35110)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kaushal.modi@gmail.com>) id 1gXWPn-0006AS-Jp
	for emacs-orgmode@gnu.org; Thu, 13 Dec 2018 14:12:56 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kaushal.modi@gmail.com>) id 1gXWPm-0001vh-Op
	for emacs-orgmode@gnu.org; Thu, 13 Dec 2018 14:12:55 -0500
In-Reply-To: <87o99p4cna.fsf@nicolasgoaziou.fr>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: van@scratch.space, Eric Abrahamsen <eric@ericabrahamsen.net>, emacs-org list <emacs-orgmode@gnu.org>, Bastien Guerry <bzg@gnu.org>

--000000000000d3396a057cec190e
Content-Type: text/plain; charset="UTF-8"

On Thu, Dec 13, 2018 at 11:25 AM Nicolas Goaziou <mail@nicolasgoaziou.fr>
wrote:

>
> > +    (unless (org-capture-get :no-save)
> > +      ;; Save the target file.
> > +      (save-buffer))
>
> The comment does not look terribly useful. I would put the whole
> `unless' in a single line.
>
> Barring that nitpicking of mine, LGTM!
>

Thanks. I have made the suggested change, and pushed to master, merged into
next.

--000000000000d3396a057cec190e
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_quote"><div dir=3D"ltr">On Thu, Dec 13=
, 2018 at 11:25 AM Nicolas Goaziou &lt;<a href=3D"mailto:mail@nicolasgoazio=
u.fr">mail@nicolasgoaziou.fr</a>&gt; wrote:<br></div><blockquote class=3D"g=
mail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204=
,204,204);padding-left:1ex"><br>
&gt; +=C2=A0 =C2=A0 (unless (org-capture-get :no-save)<br>
&gt; +=C2=A0 =C2=A0 =C2=A0 ;; Save the target file.<br>
&gt; +=C2=A0 =C2=A0 =C2=A0 (save-buffer))<br>
<br>
The comment does not look terribly useful. I would put the whole<br>
`unless&#39; in a single line.<br>
<br>
Barring that nitpicking of mine, LGTM!<br></blockquote><div><br></div><div>=
Thanks. I have made the suggested change, and pushed to master, merged into=
 next. <br></div></div></div>

--000000000000d3396a057cec190e--