From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kaushal Modi Subject: [PATCH] Fix the single quote printed in the message printed by org-table-edit-formulas Date: Wed, 9 Mar 2016 11:18:17 -0500 Message-ID: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a113d3b74049133052da00e51 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:40874) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adgp8-0005qT-S9 for emacs-orgmode@gnu.org; Wed, 09 Mar 2016 11:19:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1adgp7-0000Mf-K1 for emacs-orgmode@gnu.org; Wed, 09 Mar 2016 11:18:58 -0500 Received: from mail-oi0-x22a.google.com ([2607:f8b0:4003:c06::22a]:35354) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adgp7-0000MV-Cy for emacs-orgmode@gnu.org; Wed, 09 Mar 2016 11:18:57 -0500 Received: by mail-oi0-x22a.google.com with SMTP id c203so39202741oia.2 for ; Wed, 09 Mar 2016 08:18:57 -0800 (PST) List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-org list --001a113d3b74049133052da00e51 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi all, Can someone please review and commit this patch. It basically prints the "C-c '" binding correctly in the echo area, using straight quote instead of curly quote (matters in emacs 25.x). The details are in the commit log below. >From f4411b59d8dc4e5b3df79ccbcd87f6bfe5160776 Mon Sep 17 00:00:00 2001 From: Kaushal Modi Date: Wed, 9 Mar 2016 01:18:58 -0500 Subject: [PATCH] Fix the single quote printed in the message MIME-Version: 1.0 Content-Type: text/plain; charset=3DUTF-8 Content-Transfer-Encoding: 8bit Fix the quote style when in the "C-c '" key-binding that is printed in the echo via the substitute-command-keys function. In emacs 25.x, a straight quote is rendered as a right-curly quote by default. So below will render that single quote as curly. (message "C-c '") The fix is to print that quote verbatim using the "%s" modifier: (message "%s" "C-c '") Below is how this commit changes the message echoed in the org-table-edit-formulas function. Earlier: Edit formulas, finish with =E2=80=98C-c C-c=E2=80=99 or =E2=80=98C-c =E2= =80=99=E2=80=99. See menu for more commands. After fix: Edit formulas, finish with =E2=80=98C-c C-c=E2=80=99 or =E2=80=98C-c '=E2= =80=99. See menu for more commands. Note the difference in the single quote style in "C-c '". --- lisp/org-table.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/org-table.el b/lisp/org-table.el index 488c912..0a25772 100644 --- a/lisp/org-table.el +++ b/lisp/org-table.el @@ -3591,7 +3591,7 @@ Parameters get priority." (when (eq org-table-use-standard-references t) (org-table-fedit-toggle-ref-type)) (org-goto-line startline) - (message + (message "%s" (substitute-command-keys "\\\ Edit formulas, finish with `\\[org-ctrl-c-ctrl-c]' or `\\[org-edit-special]'. \ See menu for more commands."))))) -- Kaushal Modi --001a113d3b74049133052da00e51 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi a= ll,

Can someone please revi= ew and commit this patch.=C2=A0

It basically prints the "C-c '" binding correctly in the= echo area, using straight quote instead of curly quote (matters in emacs 2= 5.x).=C2=A0The details are in the commit l= og below.


=
From f4411b59d8dc4e5b= 3df79ccbcd87f6bfe5160776 Mon Sep 17 00:00:00 2001
From: Kaushal Modi <kaushal.modi@gmail.com>
Date: Wed, 9 Mar 2= 016 01:18:58 -0500
Subject: [PATCH] Fix the single quote printed in the message
MIME-Version: 1.0
Content-Type: text/plain;= charset=3DUTF-8
Content-Transfer-Encoding: 8bit

Fix the quote style when in the "C-c '" key-binding tha= t is printed in the echo via the substitute-command-keys function. In emacs= 25.x, a straight quote is rendered as a right-curly quote by default.

So below will render that singl= e quote as curly.

(message "C-c '")

The fix is to print that quote verbatim using the &= quot;%s" modifier:

(message "%s" "C-c '")

Below is how this commit chang= es the message echoed in the org-table-edit-formulas function.

Earlier:
=C2=A0 Edit formulas, finish with =E2=80=98C-c= C-c=E2=80=99 or =E2=80=98C-c =E2=80=99=E2=80=99.=C2=A0 See menu for more c= ommands.

After fix:
=C2=A0 Edit formulas, f= inish with =E2=80=98C-c C-c=E2=80=99 or =E2=80=98C-c '=E2=80=99.=C2=A0 = See menu for more commands.

Note the difference in the single quote style in "C-c '".
---
=C2=A0lisp/org-table.el | 2 +-=
=C2=A01 file ch= anged, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/org-table.el b/lisp/org-table.el
index 488c912..0a25772 100644=
--- a/lisp/org-= table.el
+++ b/l= isp/org-table.el
@@ -3591,7 +3591,7 @@ Parameters get priority."
=C2=A0 =C2=A0 =C2=A0 =C2=A0(when (eq = org-table-use-standard-references t)
=C2=A0 (o= rg-table-fedit-toggle-ref-type))
=C2=A0 =C2=A0 =C2=A0 =C2=A0(org-goto-line startline)
=
- =C2=A0 =C2=A0 =C2= =A0(message
+ = =C2=A0 =C2=A0 =C2=A0(message "%s"
=C2=A0 =C2=A0=C2=A0 =C2=A0 =C2=A0 (substitute-command-keys "\\<org-mod= e-map>\
=C2= =A0Edit formulas, finish with `\\[org-ctrl-c-ctrl-c]' or `\\[org-edit-s= pecial]'. =C2=A0\
=C2=A0See menu for more commands.")))))



--
Kaushal Modi
--001a113d3b74049133052da00e51--