emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Kaushal Modi <kaushal.modi@gmail.com>
To: emacs-org list <emacs-orgmode@gnu.org>
Subject: [PATCH] Fix the single quote printed in the message printed by org-table-edit-formulas
Date: Wed, 9 Mar 2016 11:18:17 -0500	[thread overview]
Message-ID: <CAFyQvY2GcivLbGTjhAA3JoMFPxfaE0==0t2TwFkxA40ULs+DZQ@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1925 bytes --]

Hi all,

Can someone please review and commit this patch.

It basically prints the "C-c '" binding correctly in the echo area, using
straight quote instead of curly quote (matters in emacs 25.x). The details
are in the commit log below.


From f4411b59d8dc4e5b3df79ccbcd87f6bfe5160776 Mon Sep 17 00:00:00 2001
From: Kaushal Modi <kaushal.modi@gmail.com>
Date: Wed, 9 Mar 2016 01:18:58 -0500
Subject: [PATCH] Fix the single quote printed in the message
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Fix the quote style when in the "C-c '" key-binding that is printed in the
echo via the substitute-command-keys function. In emacs 25.x, a straight
quote is rendered as a right-curly quote by default.

So below will render that single quote as curly.

(message "C-c '")

The fix is to print that quote verbatim using the "%s" modifier:

(message "%s" "C-c '")

Below is how this commit changes the message echoed in the
org-table-edit-formulas function.

Earlier:
  Edit formulas, finish with ‘C-c C-c’ or ‘C-c ’’.  See menu for more
commands.

After fix:
  Edit formulas, finish with ‘C-c C-c’ or ‘C-c '’.  See menu for more
commands.

Note the difference in the single quote style in "C-c '".
---
 lisp/org-table.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/org-table.el b/lisp/org-table.el
index 488c912..0a25772 100644
--- a/lisp/org-table.el
+++ b/lisp/org-table.el
@@ -3591,7 +3591,7 @@ Parameters get priority."
       (when (eq org-table-use-standard-references t)
  (org-table-fedit-toggle-ref-type))
       (org-goto-line startline)
-      (message
+      (message "%s"
         (substitute-command-keys "\\<org-mode-map>\
 Edit formulas, finish with `\\[org-ctrl-c-ctrl-c]' or
`\\[org-edit-special]'.  \
 See menu for more commands.")))))



--
Kaushal Modi

[-- Attachment #2: Type: text/html, Size: 5342 bytes --]

             reply	other threads:[~2016-03-09 16:19 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-09 16:18 Kaushal Modi [this message]
2016-03-10  9:25 ` [PATCH] Fix the single quote printed in the message printed by org-table-edit-formulas Nicolas Goaziou
2016-03-10 15:33   ` Kaushal Modi
2016-03-10 16:05     ` Paul Eggert
2016-03-10 16:00   ` Kyle Meyer
2016-03-10 16:38 ` Kyle Meyer
2016-03-10 16:41   ` Kaushal Modi
2016-03-10 17:47     ` Kaushal Modi
2016-03-10 18:24       ` Kaushal Modi
2016-03-11  1:39       ` Paul Eggert
2016-03-11  3:22         ` Kaushal Modi
2016-03-11  4:30           ` Kyle Meyer
2016-03-11  4:55             ` Kaushal Modi
2016-03-11  5:12               ` Kyle Meyer
2016-03-11 17:44                 ` Kaushal Modi
2016-03-11 18:47                   ` Kyle Meyer
2016-03-11 19:16                     ` Kyle Meyer
2016-03-12  4:01                     ` Kyle Meyer
2016-03-12  4:57                       ` Kaushal Modi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFyQvY2GcivLbGTjhAA3JoMFPxfaE0==0t2TwFkxA40ULs+DZQ@mail.gmail.com' \
    --to=kaushal.modi@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).