From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id oOqnJ+eEY190VwAA0tVLHw (envelope-from ) for ; Thu, 17 Sep 2020 15:46:47 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id 4OawI+eEY19RaQAA1q6Kng (envelope-from ) for ; Thu, 17 Sep 2020 15:46:47 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2CF129406BB for ; Thu, 17 Sep 2020 15:46:47 +0000 (UTC) Received: from localhost ([::1]:34570 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kIw7R-0002Im-I9 for larch@yhetil.org; Thu, 17 Sep 2020 11:46:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38826) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kIw3d-0000K6-66 for emacs-orgmode@gnu.org; Thu, 17 Sep 2020 11:42:49 -0400 Received: from mail-lf1-x135.google.com ([2a00:1450:4864:20::135]:33311) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kIw3X-0000jX-4R for emacs-orgmode@gnu.org; Thu, 17 Sep 2020 11:42:47 -0400 Received: by mail-lf1-x135.google.com with SMTP id x77so2714863lfa.0 for ; Thu, 17 Sep 2020 08:42:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XnS58DHf97zRA21eMm0j+jZmuMTY2mn8u77o+RCA2GM=; b=nKvv/IDYG6LlZAxUgzRYsCpWxHQ7rDtDE/EES2dSZRQwXxwpNa0x6pFg1hfNyotooN 51yvXbH4IkvqKKizqHdcDu23xrauAjqLIU+0KWqpY9FRwgC0kPg57zcgiRgq33iaT0Ee TCCwH2iDxSCsaGZjCQi6eveds5ciJlVv54QLVc+cQhR1FRsNFHw6YhyBStCX8EZKnBk/ OzMLTW6We6tAtfJxqdNikdButs8ASsF1q6Hfj7/dNv2AiH3zLpVWW+spMUt1Q3l/6ZT8 qzGXgm1fuSrDl67t6eZNnxc+HKd/o5AG/NimbzvKLcCZNeqk3+WDqLgQXCtq3Ewcurli 2+ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XnS58DHf97zRA21eMm0j+jZmuMTY2mn8u77o+RCA2GM=; b=B58YBmQCunzjprl6q1NWyfo8GXfGq+m49yhUxTb0gdw6uJ4195iytd1Z+Vi1/O1R89 UqdBi/iVp6U8gcLGaGHSqUIKCpELq6TZJruZ43WSobv7R4FZCElxg6jJNOOzimUq0ivI R+ZmI2gAOotpaxfDeCPUpSiuZ5Gkq0XKZu2uZBP5xkhq4CxnC+kE8gPhiDfDjX0LCqlo 0kUzYackKFbf4j7ZCefWcyk5CP450Ad2njwbNT+6zWcYm+StmhZ2fnfwwzRDopWODBm8 7/I+sx/i0Z/xYliSGbQ0LULI7lpifKFksScBXtCHUJFkvEjWjpcRKeft2ajxxkMWSo+l c0FA== X-Gm-Message-State: AOAM530k3EUr7i41Km18nZpM3A3wxoVVKidcPn+JuHcnB4Jkx1Sia3hY 3GKxNooKkRueg8rgWmu4jGGS3Yazx3j7IGF7xYP8ECcZVJs= X-Google-Smtp-Source: ABdhPJxmlwKpJYHxK0o/frTri6SlUaxRDKdSDzuwekwrQ3Q98vVdCEqkE3ojXlZ3rOLN4kzl0O5Xc60a9RVSXuvdqvM= X-Received: by 2002:ac2:54b4:: with SMTP id w20mr10772173lfk.13.1600357354525; Thu, 17 Sep 2020 08:42:34 -0700 (PDT) MIME-Version: 1.0 References: <87pn6n5u13.fsf@wi.uni-muenster.de> <877dsu75lo.fsf@kyleam.com> <87y2la9t4p.fsf@wi.uni-muenster.de> <87een188u5.fsf@kyleam.com> In-Reply-To: <87een188u5.fsf@kyleam.com> From: Kaushal Modi Date: Thu, 17 Sep 2020 11:42:05 -0400 Message-ID: Subject: Re: pcase failure with Emacs 24 (was Emacs version for Org 9.4?) To: Kyle Meyer Content-Type: multipart/alternative; boundary="000000000000a1576d05af843b74" Received-SPF: pass client-ip=2a00:1450:4864:20::135; envelope-from=kaushal.modi@gmail.com; helo=mail-lf1-x135.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jens Lechtenboerger , emacs-org list Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=nKvv/IDY; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -0.71 X-TUID: JrLDALANZztr --000000000000a1576d05af843b74 Content-Type: text/plain; charset="UTF-8" > On 2020-09-15, Kyle Meyer wrote: > > > >> It is pretty tricky to debug, but the failure starts with 4a27b67fd > >> (org-element: Fix property drawers parsing, 2020-04-22). As far as I > >> can see, the pattern introduced there is perfectly valid and should be > >> compatible with Emacs 24. I'd _guess_ this is a pcase bug in Emacs 24, > >> particularly the one fixed by 528872c5f8 (bug#18554, 2014-09-27), but I > >> didn't make an effort to try to understand that commit. > >> > >> Interestingly, the error goes away if I just swap the elements in the > >> pcase (and ...) pattern added by that commit. Dunno, but if that clears > >> up the failure on your end as well, I don't see any reason to not make > >> that change. > >> > >> > >> diff --git a/lisp/org-element.el b/lisp/org-element.el > >> [...] > > > > Yes, that fixes the problem over here. > > Thanks for confirming. Pushed (73c929e3b). > > I just stumbled on this as I was looking into why ox-hugo tests failed on emacs 24.x ( https://travis-ci.org/github/kaushalmodi/ox-hugo/builds/728059027 ). This should pass next week now. Thanks for your fix. --000000000000a1576d05af843b74 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
> On 2020-09-15, Kyle Meyer wrote:
>
>> It is pretty tricky to debug, but the failure starts with 4a27b67f= d
>> (org-element: Fix property drawers parsing, 2020-04-22).=C2=A0 As = far as I
>> can see, the pattern introduced there is perfectly valid and shoul= d be
>> compatible with Emacs 24.=C2=A0 I'd _guess_ this is a pcase bu= g in Emacs 24,
>> particularly the one fixed by 528872c5f8 (bug#18554, 2014-09-27), = but I
>> didn't make an effort to try to understand that commit.
>>
>> Interestingly, the error goes away if I just swap the elements in = the
>> pcase (and ...) pattern added by that commit.=C2=A0 Dunno, but if = that clears
>> up the failure on your end as well, I don't see any reason to = not make
>> that change.
>>
>>
>> diff --git a/lisp/org-element.el b/lisp/org-element.el
>> [...]
>
> Yes, that fixes the problem over here.

Thanks for confirming.=C2=A0 Pushed (73c929e3b).

=C2=A0
I just stumbled on this as I was loo= king into why ox-hugo tests failed on emacs 24.x ( https://travis-ci.org= /github/kaushalmodi/ox-hugo/builds/728059027 ). This should pass next w= eek now. Thanks for your fix.
--000000000000a1576d05af843b74--