From: Kaushal Modi <email@example.com>
To: Kyle Meyer <firstname.lastname@example.org>
Cc: Jens Lechtenboerger <email@example.com>,
emacs-org list <firstname.lastname@example.org>
Subject: Re: pcase failure with Emacs 24 (was Emacs version for Org 9.4?)
Date: Thu, 17 Sep 2020 11:42:05 -0400 [thread overview]
Message-ID: <CAFyQvY1_YT=1yHTaLvg-jk4BO+mMe7V8vCmr-C3V91HEZ7RRgA@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1120 bytes --]
> On 2020-09-15, Kyle Meyer wrote:
> >> It is pretty tricky to debug, but the failure starts with 4a27b67fd
> >> (org-element: Fix property drawers parsing, 2020-04-22). As far as I
> >> can see, the pattern introduced there is perfectly valid and should be
> >> compatible with Emacs 24. I'd _guess_ this is a pcase bug in Emacs 24,
> >> particularly the one fixed by 528872c5f8 (bug#18554, 2014-09-27), but I
> >> didn't make an effort to try to understand that commit.
> >> Interestingly, the error goes away if I just swap the elements in the
> >> pcase (and ...) pattern added by that commit. Dunno, but if that clears
> >> up the failure on your end as well, I don't see any reason to not make
> >> that change.
> >> diff --git a/lisp/org-element.el b/lisp/org-element.el
> >> [...]
> > Yes, that fixes the problem over here.
> Thanks for confirming. Pushed (73c929e3b).
I just stumbled on this as I was looking into why ox-hugo tests failed on
emacs 24.x (
https://travis-ci.org/github/kaushalmodi/ox-hugo/builds/728059027 ). This
should pass next week now. Thanks for your fix.
[-- Attachment #2: Type: text/html, Size: 1598 bytes --]
prev parent reply other threads:[~2020-09-17 15:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-15 8:22 Emacs version for Org 9.4? Jens Lechtenboerger
2020-09-15 9:46 ` Jeremie Juste
2020-09-15 10:57 ` Jens Lechtenboerger
2020-09-16 3:39 ` pcase failure with Emacs 24 (was Emacs version for Org 9.4?) Kyle Meyer
2020-09-16 5:40 ` Jens Lechtenboerger
2020-09-17 1:56 ` Kyle Meyer
2020-09-17 15:42 ` Kaushal Modi [this message]
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).