From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kaushal Modi Subject: Re: 6 failing tests on master branch Date: Fri, 09 Jun 2017 15:14:55 +0000 Message-ID: References: <87a85i2nji.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="001a114b2c302d4a380551886f1f" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:35532) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dJLcy-0008Sn-LR for emacs-orgmode@gnu.org; Fri, 09 Jun 2017 11:15:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dJLcx-0004Vu-R4 for emacs-orgmode@gnu.org; Fri, 09 Jun 2017 11:15:08 -0400 Received: from mail-lf0-x22f.google.com ([2a00:1450:4010:c07::22f]:35919) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dJLcx-0004TQ-JK for emacs-orgmode@gnu.org; Fri, 09 Jun 2017 11:15:07 -0400 Received: by mail-lf0-x22f.google.com with SMTP id o83so31014707lff.3 for ; Fri, 09 Jun 2017 08:15:07 -0700 (PDT) In-Reply-To: List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Nicolas Goaziou Cc: Michael Albinus , emacs-org list --001a114b2c302d4a380551886f1f Content-Type: text/plain; charset="UTF-8" On Fri, Jun 9, 2017 at 10:26 AM Kaushal Modi wrote: > This one should be easy to debug since >> >> (org-export-file-uri "/myself@some.where:papers/last.pdf") >> >> is easy to reproduce. Could you investigate where the spurious "/" comes >> from? >> > > Will do. > This seems to be related to a tramp file notation change on emacs master. I don't use tramp, but I heard about it on emacs-devel. Here is a test expression: (find-file-name-handler "/myself@some.where:papers/last.pdf" 'file-remote-p) On emacs 25.2, that returns tramp-file-name-handler. On emacs master, that returns nil. So, on emacs 25.2, in org-export-file-uri, the (org-file-remote-p filename) case evaluates to true. Whereas, on emacs master, the execution falls into the default (t ..) case. .. and thus the spurious "/". Copying the tramp dev Michael Albinus on this for help. @Michael How should the above find-file-name-handler arg change to support that test file path? Thanks. -- Kaushal Modi --001a114b2c302d4a380551886f1f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Fri, Jun 9,= 2017 at 10:26 AM Kaushal Modi <kaushal.modi@gmail.com> wrote:
This one should be easy to debug since

=C2=A0 (org-export-file-uri "/myself@some.where:papers/last.pdf")=

is easy to reproduce. Could you investigate where the spurious "/"= ; comes
from?

Will do.

This seems to be related to a tramp file notation change on emacs ma= ster. I don't use tramp, but I heard about it on emacs-devel.

Here is a test expression:

=C2=A0 = =C2=A0=C2=A0(find-file-name-handler "/myself@some.where:papers/last.pd= f" 'file-remote-p)

On emacs 25.2, that re= turns tramp-file-name-handler.
On emacs master, that returns nil.=

So, on emacs 25.2, in org-export-file-uri, the=C2= =A0(org-file-remote-p filename) case evaluates to true. Whereas, on emacs m= aster, the execution falls into the default (t ..) case.

.. and thus the spurious "/".

Cop= ying the tramp dev Michael Albinus on this for help.
@Michael How= should the above find-file-name-handler arg change to support that test fi= le path?

Thanks.
--

Kausha= l Modi

--001a114b2c302d4a380551886f1f--