From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kaushal Modi <kaushal.modi@gmail.com>
Subject: Avoid add-to-list on local variables
Date: Wed, 04 Jan 2017 13:52:54 +0000
Message-ID: <CAFyQvY1MsM+pJs_ixQ0mOBERapm0Jv6z5MtkuG4iNzXEkrsiyA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary=001a1142ed18a7b5440545451a9c
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56982)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kaushal.modi@gmail.com>) id 1cOm03-0007VC-W6
	for emacs-orgmode@gnu.org; Wed, 04 Jan 2017 08:53:09 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kaushal.modi@gmail.com>) id 1cOm03-000150-2d
	for emacs-orgmode@gnu.org; Wed, 04 Jan 2017 08:53:08 -0500
Received: from mail-vk0-x233.google.com ([2607:f8b0:400c:c05::233]:34600)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <kaushal.modi@gmail.com>)
	id 1cOm02-00014q-Rq
	for emacs-orgmode@gnu.org; Wed, 04 Jan 2017 08:53:06 -0500
Received: by mail-vk0-x233.google.com with SMTP id x186so287165836vkd.1
	for <emacs-orgmode@gnu.org>; Wed, 04 Jan 2017 05:53:06 -0800 (PST)
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: emacs-org list <emacs-orgmode@gnu.org>, Nicolas Goaziou <mail@nicolasgoaziou.fr>

--001a1142ed18a7b5440545451a9c
Content-Type: text/plain; charset=UTF-8

Hi all,

I just noticed this commit on emacs master branch:

http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=2ec41c415f39990561cc9da4c9bad0b69bfad489

The commit touches these parts of org:

Avoid add-to-list on local variables
* lisp/org/org-archive.el (org-all-archive-files): * lisp/org/org-agenda.el
(org-agenda-get-restriction-and-command): Avoid add-to-list on local
variables. * lisp/org/ox-publish.el (org-publish--run-functions): New
function. (org-publish-projects): Use it to avoid run-hooks on a local
variable. (org-publish-cache-file-needs-publishing): Avoid add-to-list on
local variables.

So I believe that these changes should be back-ported into the master
branch of org too?
-- 

Kaushal Modi

--001a1142ed18a7b5440545451a9c
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi all,<div><br></div><div>I just noticed this commit on e=
macs master branch:</div><div><br></div><div><a href=3D"http://git.savannah=
.gnu.org/cgit/emacs.git/commit/?id=3D2ec41c415f39990561cc9da4c9bad0b69bfad4=
89">http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=3D2ec41c415f39990=
561cc9da4c9bad0b69bfad489</a><br></div><div><br></div><div>The commit touch=
es these parts of org:</div><div><span style=3D"color:rgb(51,51,51);font-si=
ze:16.6667px;font-weight:bold"><br></span></div><div><span style=3D"color:r=
gb(51,51,51);font-size:16.6667px;font-weight:bold">Avoid add-to-list on loc=
al variables</span><br></div><div><div class=3D"inbox-inbox-commit-msg" sty=
le=3D"white-space:pre;font-family:monospace;color:rgb(51,51,51);font-size:1=
3.3333px">* lisp/org/org-archive.el (org-all-archive-files):
* lisp/org/org-agenda.el (org-agenda-get-restriction-and-command):
Avoid add-to-list on local variables.

* lisp/org/ox-publish.el (org-publish--run-functions): New function.
(org-publish-projects): Use it to avoid run-hooks on a local variable.
(org-publish-cache-file-needs-publishing): Avoid add-to-list on
local variables.
</div><br class=3D"inbox-inbox-Apple-interchange-newline"></div><div>So I b=
elieve that these changes should be back-ported into the master branch of o=
rg too?</div></div><div dir=3D"ltr">-- <br></div><div data-smartmail=3D"gma=
il_signature"><p dir=3D"ltr">Kaushal Modi</p>
</div>

--001a1142ed18a7b5440545451a9c--