From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kaushal Modi Subject: Re: [PATCH] Refactor org-set-tags arguments for clarity Date: Thu, 13 Jul 2017 12:39:11 +0000 Message-ID: References: <87pod4zs9i.fsf@nicolasgoaziou.fr> <87r2xkft0t.fsf@nicolasgoaziou.fr> <87iniwfrgg.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="94eb2c0c8d12d2336b055432385c" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:41716) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dVdOu-0006uX-Cd for emacs-orgmode@gnu.org; Thu, 13 Jul 2017 08:39:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dVdOt-0002U2-IZ for emacs-orgmode@gnu.org; Thu, 13 Jul 2017 08:39:24 -0400 Received: from mail-lf0-x22e.google.com ([2a00:1450:4010:c07::22e]:34997) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dVdOt-0002TZ-Az for emacs-orgmode@gnu.org; Thu, 13 Jul 2017 08:39:23 -0400 Received: by mail-lf0-x22e.google.com with SMTP id b207so35885796lfg.2 for ; Thu, 13 Jul 2017 05:39:23 -0700 (PDT) In-Reply-To: List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Nicolas Goaziou Cc: emacs-org list --94eb2c0c8d12d2336b055432385c Content-Type: text/plain; charset="UTF-8" On Thu, Jul 13, 2017 at 8:37 AM Kaushal Modi wrote: > (defun org-set-tags (&optional align-all align-current) >> "... >> ... >> ALIGN-CURRENT is obsolete and should not be used. When non-nil, >> set ALIGN-ALL to `current'." >> (let ((align-all (if (null align-current) align-all >> (warn "Deprecated call to `org-set-tags', which >> see") >> 'current))) >> ...)) >> > > That will work. Good idea! > > I'll first patch maint, and then this in master. > And then.. ALIGN-ALL can become JUST-ALIGN in master :P -- Kaushal Modi --94eb2c0c8d12d2336b055432385c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Thu, Jul 13= , 2017 at 8:37 AM Kaushal Modi <kaushal.modi@gmail.com> wrote:
=C2=A0 (defun org-set-tags (&optional align-all align-current)
=C2=A0 =C2=A0 "...
=C2=A0 ...
=C2=A0 ALIGN-CURRENT is obsolete and should not be used. When non-nil,
=C2=A0 set ALIGN-ALL to `current'."
=C2=A0 =C2=A0 (let ((align-all (if (null align-current) align-all
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0(warn "Deprecated call to `org-set-tags', which see"= ;)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0'current)))
=C2=A0 =C2=A0 =C2=A0...))

That will work. Good idea!
=

I'll first patch maint, and then this in master.=C2= =A0

And then.. ALIGN-ALL = can become JUST-ALIGN in master :P=C2=A0
= --

Kaushal Modi

--94eb2c0c8d12d2336b055432385c--