From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kaushal Modi Subject: Re: Add an optional HOLD argument to "n" Org macro Date: Thu, 15 Jun 2017 13:10:34 +0000 Message-ID: References: <2ee94a64a94b46259b0da6e7d34675c9@HE1PR01MB1898.eurprd01.prod.exchangelabs.com> <87y3u7o3dj.fsf@t3610> <87pofjtk4b.fsf@t3610> <2069df8c23bc43f3b04b6e203b96be9d@HE1PR01MB1898.eurprd01.prod.exchangelabs.com> <87r2zvpyst.fsf@delle7240> <8760guib5i.fsf@nicolasgoaziou.fr> <87fuftb4lg.fsf@nicolasgoaziou.fr> <8760fyic6n.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="001a1140213e8b838d0551ff658f" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:46600) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dLUXw-0000Jz-E3 for emacs-orgmode@gnu.org; Thu, 15 Jun 2017 09:10:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dLUXv-0001g7-AQ for emacs-orgmode@gnu.org; Thu, 15 Jun 2017 09:10:48 -0400 Received: from mail-lf0-x232.google.com ([2a00:1450:4010:c07::232]:35401) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dLUXu-0001g1-Ut for emacs-orgmode@gnu.org; Thu, 15 Jun 2017 09:10:47 -0400 Received: by mail-lf0-x232.google.com with SMTP id p189so9122061lfe.2 for ; Thu, 15 Jun 2017 06:10:46 -0700 (PDT) In-Reply-To: <8760fyic6n.fsf@nicolasgoaziou.fr> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Nicolas Goaziou Cc: emacs-orgmode@gnu.org --001a1140213e8b838d0551ff658f Content-Type: multipart/alternative; boundary="001a1140213e8b837e0551ff658d" --001a1140213e8b837e0551ff658d Content-Type: text/plain; charset="UTF-8" On Wed, Jun 14, 2017 at 3:47 PM Nicolas Goaziou wrote: > I think it is better since resetting, setting and holding are mutually > exclusive. Thanks. > With tests, please! :) > Of course :) The patch based off latest master is attached. Please review. -- Kaushal Modi --001a1140213e8b837e0551ff658d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Wed, Jun 14= , 2017 at 3:47 PM Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
I think it is better since resetting, setting and holding are mutua= lly
exclusive.

Thanks.
=C2=A0
<= blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px= #ccc solid;padding-left:1ex">With tests, please! :)
<= br>
Of course :)
=C2=A0
The patch based off l= atest master is attached. Please review.
= --

Kaushal= Modi

--001a1140213e8b837e0551ff658d-- --001a1140213e8b838d0551ff658f Content-Type: application/octet-stream; name="0001-Add-hold-action-to-the-n-macro.patch" Content-Disposition: attachment; filename="0001-Add-hold-action-to-the-n-macro.patch" Content-Transfer-Encoding: base64 Content-ID: <15cabe0295ae06dfada1> X-Attachment-Id: 15cabe0295ae06dfada1 RnJvbSA2ZTY0NjJmNmYwNzU2ZTFiMzQ5YWU0NTBkY2U0NzgzMjU1Mjg3Yzc3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBLYXVzaGFsIE1vZGkgPGthdXNoYWwubW9kaUBnbWFpbC5jb20+ CkRhdGU6IFdlZCwgMTQgSnVuIDIwMTcgMTQ6MzQ6NTMgLTA0MDAKU3ViamVjdDogW1BBVENIXSBB ZGQgaG9sZCAnYWN0aW9uJyB0byB0aGUgIm4iIG1hY3JvCgoqIGxpc3Avb3JnLW1hY3JvLmVsIChv cmctbWFjcm8tLWNvdW50ZXItaW5jcmVtZW50KTogUmVuYW1lIHRoZQpvcHRpb25hbCBhcmcgUkVT RVQgdG8gQUNUSU9OLCBhcyBub3cgdGhhdCBhY3Rpb24gY2FuIG1lYW4gc2V0dGluZywKcmVzZXR0 aW5nIG9yIGV2ZW4gaG9sZGluZyB0aGUgc3BlY2lmaWVkIGNvdW50ZXIuICBBQ1RJT04gc2V0IHRv CiJob2xkIiBvciAiLSIgd2lsbCBob2xkIHRoZSBwcmV2aW91cyB2YWx1ZSBvZiB0aGUgY291bnRl ci4KCiogZG9jL29yZy50ZXhpIChNYWNybyByZXBsYWNlbWVudCk6IERvY3VtZW50IHRoZSBuZXcg aG9sZCBhY3Rpb24uCgoqIHRlc3RpbmcvbGlzcC90ZXN0LW9yZy1tYWNyby5lbCAodGVzdC1vcmct bWFjcm8vbik6IEFkZCBuZXcgdGVzdCBmb3IKdGhlIGhvbGQgYWN0aW9uLgotLS0KIGRvYy9vcmcu dGV4aSAgICAgICAgICAgICAgICAgICB8IDEyICsrKysrKystLS0tLQogbGlzcC9vcmctbWFjcm8u ZWwgICAgICAgICAgICAgIHwgMjYgKysrKysrKysrKysrKysrKystLS0tLS0tLS0KIHRlc3Rpbmcv bGlzcC90ZXN0LW9yZy1tYWNyby5lbCB8IDE3ICsrKysrKysrKysrKysrKystCiAzIGZpbGVzIGNo YW5nZWQsIDQwIGluc2VydGlvbnMoKyksIDE1IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2Rv Yy9vcmcudGV4aSBiL2RvYy9vcmcudGV4aQppbmRleCA5NmFlZGUyYWExLi4zMmNjMTQzMWI0IDEw MDY0NAotLS0gYS9kb2Mvb3JnLnRleGkKKysrIGIvZG9jL29yZy50ZXhpCkBAIC0xMDg2NywxNSAr MTA4NjcsMTcgQEAgZW50cnksIHRoYXQgd2lsbCBiZSB1c2VkIGluc3RlYWQuCiAKIEBpdGVtIEB7 QHtAe25AfUB9QH0KIEBpdGVteCBAe0B7QHtuKEB2YXJ7TkFNRX0pQH1AfUB9Ci1AaXRlbXggQHtA e0B7bihAdmFye05BTUV9LEB2YXJ7UkVTRVR9KUB9QH1AfQorQGl0ZW14IEB7QHtAe24oQHZhcntO QU1FfSxAdmFye0FDVElPTn0pQH1AfUB9CiBAY2luZGV4IG4sIG1hY3JvCiBAY2luZGV4IGNvdW50 ZXIsIG1hY3JvCiBUaGlzIG1hY3JvIGltcGxlbWVudHMgY3VzdG9tIGNvdW50ZXJzIGJ5IHJldHVy bmluZyB0aGUgbnVtYmVyIG9mIHRpbWVzIHRoZQogbWFjcm8gaGFzIGJlZW4gZXhwYW5kZWQgc28g ZmFyIHdoaWxlIGV4cG9ydGluZyB0aGUgYnVmZmVyLiAgWW91IGNhbiBjcmVhdGUKLW1vcmUgdGhh biBvbmUgY291bnRlciB1c2luZyBkaWZmZXJlbnQgQHZhcntOQU1FfSB2YWx1ZXMuICBJZiBAdmFy e1JFU0VUfSBpcwotbm9uLWVtcHR5LCB0aGUgc3BlY2lmaWVkIGNvdW50ZXIgaXMgcmVzZXQgdG8g dGhlIHZhbHVlIHNwZWNpZmllZCBpZiBpdCBpcwotYSBudW1iZXIsIG9yIDEgb3RoZXJ3aXNlLiAg WW91IG1heSBsZWF2ZSBAdmFye05BTUV9IGVtcHR5IHRvIHJlc2V0IHRoZQotZGVmYXVsdCBjb3Vu dGVyLgorbW9yZSB0aGFuIG9uZSBjb3VudGVyIHVzaW5nIGRpZmZlcmVudCBAdmFye05BTUV9IHZh bHVlcy4gIElmIEB2YXJ7QUNUSU9OfSBpcworQGNvZGV7aG9sZH0gb3IgQGNvZGV7LX0sIHByZXZp b3VzIHZhbHVlIG9mIHRoZSBjb3VudGVyIGlzIGhlbGQsIGkuZS4gdGhlCitzcGVjaWZpZWQgY291 bnRlciBpcyBub3QgaW5jcmVtZW50ZWQuICBJZiB0aGUgdmFsdWUgaXMgYSBudW1iZXIsIHRoZQor c3BlY2lmaWVkIGNvdW50ZXIgaXMgc2V0IHRvIHRoYXQgdmFsdWUuICBJZiBpdCBpcyBhbnkgb3Ro ZXIgbm9uLWVtcHR5IHN0cmluZywKK3RoZSBzcGVjaWZpZWQgY291bnRlciBpcyByZXNldCB0byAx LiAgWW91IG1heSBsZWF2ZSBAdmFye05BTUV9IGVtcHR5IHRvIHJlc2V0Cit0aGUgZGVmYXVsdCBj b3VudGVyLgogQGVuZCB0YWJsZQogCiBUaGUgc3Vycm91bmRpbmcgYnJhY2tldHMgY2FuIGJlIG1h ZGUgaW52aXNpYmxlIGJ5IHNldHRpbmcKZGlmZiAtLWdpdCBhL2xpc3Avb3JnLW1hY3JvLmVsIGIv bGlzcC9vcmctbWFjcm8uZWwKaW5kZXggMzM4Yzk4ODExZC4uMWIzZWUyOGYyZCAxMDA2NDQKLS0t IGEvbGlzcC9vcmctbWFjcm8uZWwKKysrIGIvbGlzcC9vcmctbWFjcm8uZWwKQEAgLTQwLDcgKzQw LDcgQEAKIDs7ICAge3t7cHJvcGVydHkobm9kZS1wcm9wZXJ0eSl9fX0sCiA7OyAgIHt7e2lucHV0 LWZpbGV9fX0sCiA7OyAgIHt7e21vZGlmaWNhdGlvbi10aW1lKGZvcm1hdC1zdHJpbmcpfX19LAot OzsgICB7e3tuKGNvdW50ZXIscmVzZXR9fX0uCis7OyAgIHt7e24oY291bnRlcixhY3Rpb259fX0u CiAKIDs7IFVwb24gZXhwb3J0aW5nLCAib3guZWwiIHdpbGwgYWxzbyBwcm92aWRlIHt7e2F1dGhv cn19fSwge3t7ZGF0ZX19fSwKIDs7IHt7e2VtYWlsfX19IGFuZCB7e3t0aXRsZX19fSBtYWNyb3Mu CkBAIC0zMjcsMTcgKzMyNywyNSBAQCBSZXR1cm4gYSBsaXN0IG9mIGFyZ3VtZW50cywgYXMgc3Ry aW5ncy4gIFRoaXMgaXMgdGhlIG9wcG9zaXRlIG9mCiAgICJJbml0aWFsaXplIGBvcmctbWFjcm8t LWNvdW50ZXItdGFibGUnLiIKICAgKHNldHEgb3JnLW1hY3JvLS1jb3VudGVyLXRhYmxlIChtYWtl LWhhc2gtdGFibGUgOnRlc3QgIydlcXVhbCkpKQogCi0oZGVmdW4gb3JnLW1hY3JvLS1jb3VudGVy LWluY3JlbWVudCAobmFtZSAmb3B0aW9uYWwgcmVzZXQpCisoZGVmdW4gb3JnLW1hY3JvLS1jb3Vu dGVyLWluY3JlbWVudCAobmFtZSAmb3B0aW9uYWwgYWN0aW9uKQogICAiSW5jcmVtZW50IGNvdW50 ZXIgTkFNRS4KLU5BTUUgaXMgYSBzdHJpbmcgaWRlbnRpZnlpbmcgdGhlIGNvdW50ZXIuICBXaGVu IG5vbi1uaWwsIG9wdGlvbmFsCi1hcmd1bWVudCBSRVNFVCBpcyBhIHN0cmluZy4gIElmIGl0IHJl cHJlc2VudHMgYW4gaW50ZWdlciwgc2V0IHRoZQotY291bnRlciB0byB0aGlzIG51bWJlci4gIEFu eSBvdGhlciBub24tZW1wdHkgc3RyaW5nIHJlc2V0cyB0aGUKLWNvdW50ZXIgdG8gMS4iCitOQU1F IGlzIGEgc3RyaW5nIGlkZW50aWZ5aW5nIHRoZSBjb3VudGVyLgorCitXaGVuIG5vbi1uaWwsIG9w dGlvbmFsIGFyZ3VtZW50IEFDVElPTiBpcyBhIHN0cmluZy4KKworSWYgdGhlIHN0cmluZyBpcyBc ImhvbGRcIiBvciBcIi1cIiwga2VlcCB0aGUgTkFNRSBjb3VudGVyIGF0IGl0cworY3VycmVudCB2 YWx1ZSwgaS5lLiBkbyBub3QgaW5jcmVtZW50LgorCitJZiB0aGUgc3RyaW5nIHJlcHJlc2VudHMg YW4gaW50ZWdlciwgc2V0IHRoZSBjb3VudGVyIHRvIHRoaXMgbnVtYmVyLgorCitBbnkgb3RoZXIg bm9uLWVtcHR5IHN0cmluZyByZXNldHMgdGhlIGNvdW50ZXIgdG8gMS4iCiAgIChwdXRoYXNoIG5h bWUKLQkgICAoY29uZCAoKG5vdCAob3JnLXN0cmluZy1udy1wIHJlc2V0KSkKKwkgICAoY29uZCAo KG5vdCAob3JnLXN0cmluZy1udy1wIGFjdGlvbikpCiAJCSAgKDErIChnZXRoYXNoIG5hbWUgb3Jn LW1hY3JvLS1jb3VudGVyLXRhYmxlIDApKSkKLQkJICgoc3RyaW5nLW1hdGNoLXAgIlxcYFsgXHRd KlswLTldK1sgXHRdKlxcJyIgcmVzZXQpCi0JCSAgKHN0cmluZy10by1udW1iZXIgcmVzZXQpKQor CQkgKChzdHJpbmctbWF0Y2gtcCAiXFxgXFwoLVxcfGhvbGRcXClcXCciIGFjdGlvbikKKwkJICAo Z2V0aGFzaCBuYW1lIG9yZy1tYWNyby0tY291bnRlci10YWJsZSAxKSkKKwkJICgoc3RyaW5nLW1h dGNoLXAgIlxcYFsgXHRdKlswLTldK1sgXHRdKlxcJyIgYWN0aW9uKQorCQkgIChzdHJpbmctdG8t bnVtYmVyIGFjdGlvbikpCiAJCSAodCAxKSkKIAkgICBvcmctbWFjcm8tLWNvdW50ZXItdGFibGUp KQogCmRpZmYgLS1naXQgYS90ZXN0aW5nL2xpc3AvdGVzdC1vcmctbWFjcm8uZWwgYi90ZXN0aW5n L2xpc3AvdGVzdC1vcmctbWFjcm8uZWwKaW5kZXggNzM1NmU5OGY1Mi4uZWI5NjE0MDg5OSAxMDA2 NDQKLS0tIGEvdGVzdGluZy9saXNwL3Rlc3Qtb3JnLW1hY3JvLmVsCisrKyBiL3Rlc3RpbmcvbGlz cC90ZXN0LW9yZy1tYWNyby5lbApAQCAtMjEwLDcgKzIxMCwyMiBAQAogICAgICAgICAgICAgKG9y Zy1tYWNyby1pbml0aWFsaXplLXRlbXBsYXRlcykKICAgICAgICAgICAgIChvcmctbWFjcm8tcmVw bGFjZS1hbGwgb3JnLW1hY3JvLXRlbXBsYXRlcykKICAgICAgICAgICAgIChidWZmZXItc3Vic3Ry aW5nLW5vLXByb3BlcnRpZXMKLSAgICAgICAgICAgICAobGluZS1iZWdpbm5pbmctcG9zaXRpb24p IChsaW5lLWVuZC1wb3NpdGlvbikpKSkpKQorICAgICAgICAgICAgIChsaW5lLWJlZ2lubmluZy1w b3NpdGlvbikgKGxpbmUtZW5kLXBvc2l0aW9uKSkpKSkKKyAgOzsgU2Vjb25kIGFyZ3VtZW50IHNl dCB0byAiLSIgb3IgImhvbGQiIGhvbGRzIHRoZSBjb3VudGVyIHZhbHVlLgorICAoc2hvdWxkCisg ICAoZXF1YWwgIjEuMSAyLjIgOC4zIDguMSA4LjIgOS4yIDkuMiIKKyAgICAgICAgICAob3JnLXRl c3Qtd2l0aC10ZW1wLXRleHQKKwkgICAoY29uY2F0ICJ7e3tuKCwtKX19fS57e3tuKGMpfX19IiA7 SG9sZCBiZWZvcmUgZXZlbiBzdGFydGluZyB0aGUgY291bnRlcgorCQkgICAiIHt7e259fX0ue3t7 bihjKX19fSIgICAgO0luY3JlbWVudCBhZnRlciBob2xkCisJCSAgICIge3t7bigsOCl9fX0ue3t7 bihjKX19fSIKKwkJICAgIiB7e3tuKCxob2xkKX19fS57e3tuKGMscmVzZXQpfX19IiA7QWx0ZXJu YXRpdmUgaG9sZCBhcmcKKwkJICAgIiB7e3tuKCwtKX19fS57e3tuKGMpfX19IgorCQkgICAiIHt7 e259fX0ue3t7bihjLGhvbGQpfX19IiA7SG9sZCBvbiBhbm90aGVyIGNvdW50ZXIKKwkJICAgIiB7 e3tuKCxob2xkKX19fS57e3tuKGMsLSl9fX0iKSA7SG9sZCBvbiBib3RoIGNvdW50ZXJzCisgICAg ICAgICAgIChvcmctbWFjcm8taW5pdGlhbGl6ZS10ZW1wbGF0ZXMpCisgICAgICAgICAgIChvcmct bWFjcm8tcmVwbGFjZS1hbGwgb3JnLW1hY3JvLXRlbXBsYXRlcykKKyAgICAgICAgICAgKGJ1ZmZl ci1zdWJzdHJpbmctbm8tcHJvcGVydGllcworICAgICAgICAgICAgKGxpbmUtYmVnaW5uaW5nLXBv c2l0aW9uKSAobGluZS1lbmQtcG9zaXRpb24pKSkpKSkKIAogKGVydC1kZWZ0ZXN0IHRlc3Qtb3Jn LW1hY3JvL2VzY2FwZS1hcmd1bWVudHMgKCkKICAgIlRlc3QgYG9yZy1tYWNyby1lc2NhcGUtYXJn dW1lbnRzJyBzcGVjaWZpY2F0aW9ucy4iCi0tIAoyLjEzLjAKCg== --001a1140213e8b838d0551ff658f--