From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Tucker-Kellogg Subject: Re: PATCH -- ox-latex.el . sideways figure in latex export Date: Sun, 6 Apr 2014 18:19:32 +0800 Message-ID: References: <5CE478C5-C4A2-4BA7-B197-4807EAFE4B18@gmail.com> <8738hr7g52.fsf@gmail.com> <87ppku6e1x.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=089e0141a9a846c4ee04f65d165c Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:33742) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WWkAq-0002TJ-68 for emacs-orgmode@gnu.org; Sun, 06 Apr 2014 06:19:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WWkAp-0005Zg-2m for emacs-orgmode@gnu.org; Sun, 06 Apr 2014 06:19:36 -0400 Received: from mail-la0-x235.google.com ([2a00:1450:4010:c03::235]:33053) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WWkAo-0005ZV-L7 for emacs-orgmode@gnu.org; Sun, 06 Apr 2014 06:19:34 -0400 Received: by mail-la0-f53.google.com with SMTP id b8so3769946lan.40 for ; Sun, 06 Apr 2014 03:19:33 -0700 (PDT) In-Reply-To: <87ppku6e1x.fsf@gmail.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Nicolas Goaziou Cc: org-mode mailing list --089e0141a9a846c4ee04f65d165c Content-Type: multipart/alternative; boundary=089e0141a9a846c4eb04f65d165a --089e0141a9a846c4eb04f65d165a Content-Type: text/plain; charset=ISO-8859-1 Thanks for the guidance. I think this is it. Cheers, Greg On Sun, Apr 6, 2014 at 4:46 PM, Nicolas Goaziou wrote: > Hello, > > Greg Tucker-Kellogg writes: > > > I think this covers it. ":float sideways" now works for both tables and > > figures, but ":float sidewaystable" is kept for backwards compatibility. > I > > updated org.texi, and mentioned that the use of ":float sideways" will > make > > the ":placement" option irrelevant. > > > > Attached are the two patches; the one from yesterday and the one that > > updates as described above. > > Thank you. Here are a few comments. > > > +The @code{:float} specifies the float environment for the table. > Possible values are @code{sideways}, > > +(or equivalently @code{sidewaystable}), @code{multicolumn}, @code{t} > and @code{nil}. When unspecified, a table with > > +a caption will have a @code{table} environment. Moreover, the > @code{:placement} > > +attribute can specify the positioning of the float. Note: > @code{:placement} is > > +ignored for sidewaystable. > > In Texinfo, you need to add two spaces after a period. > > Also, providing backwards compatibility for "sidewaystable" in code is > fine, but I don't think we need to talk about it anymore as an > alternative option in the documentation. If you feel uncomfortable about > it, I think it's better to add a footnote: > > Possible values are @code{sideways}@footnote{Formerly, the value was > @code{sidewaystable}. This is deprecated since Org 8.3.}, > @code{multicolumn}... > > Also, could you provide a proper commit message, with "TINYCHANGE" at > its end. For more information, see > > http://orgmode.org/worg/org-contribute.html > > I think you can also merge both patches. But that's your call. > > > Regards, > > -- > Nicolas Goaziou > --089e0141a9a846c4eb04f65d165a Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
Thanks for the guidance. =A0I think this is it.

Cheers,

Greg



On Sun, Apr 6, = 2014 at 4:46 PM, Nicolas Goaziou <n.goaziou@gmail.com> wro= te:
Hello,

Greg Tucker-Kellogg <gtucker= kellogg@gmail.com> writes:

> I think this covers it. =A0":float sideways= " now works for both tables and
> figures, but ":float sidewaystable" is kept for backwards co= mpatibility. =A0I
> updated org.texi, and mentioned that the use of ":float sideways&= quot; will make
> the ":placement" option irrelevant.
>
> Attached are the two patches; the one from yesterday and the one that<= br> > updates as described above.

Thank you. Here are a few comments.

> +The @code{:float} specifies the float environment for the table. =A0P= ossible values are @code{sideways},
> +(or equivalently @code{sidewaystable}), @code{multicolumn}, @code{t} = and @code{nil}. =A0When unspecified, a table with
> +a caption will have a @code{table} environment. =A0Moreover, the @cod= e{:placement}
> +attribute can specify the positioning of the float. Note: @code{:plac= ement} is
> +ignored for sidewaystable.

In Texinfo, you need to add two spaces after a period.

Also, providing backwards compatibility for "sidewaystable" in co= de is
fine, but I don't think we need to talk about it anymore as an
alternative option in the documentation. If you feel uncomfortable about it, I think it's better to add a footnote:

=A0 Possible values are @code{sideways}@footnote{Formerly, the value was =A0 @code{sidewaystable}. =A0This is deprecated since Org 8.3.},
=A0 @code{multicolumn}...

Also, could you provide a proper commit message, with "TINYCHANGE"= ; at
its end. For more information, see

=A0 http://orgmode.org/worg/org-contribute.html

I think you can also merge both patches. But that's your call.


Regards,

--
Nicolas Goaziou

--089e0141a9a846c4eb04f65d165a-- --089e0141a9a846c4ee04f65d165c Content-Type: application/octet-stream; name="0001-ox-latex.el-support-sideways-float-options-for-table.patch" Content-Disposition: attachment; filename="0001-ox-latex.el-support-sideways-float-options-for-table.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hto6hh800 RnJvbSA2NjE2MzI4MjdlNmQ2OWQ2YTAxNjM0OTFhNjUxYmZlMWNjOTg1YWI0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHcmVnIFR1Y2tlci1LZWxsb2dnIDxndHVja2Vya2VsbG9nZ0Bn bWFpbC5jb20+CkRhdGU6IFN1biwgNiBBcHIgMjAxNCAxNzo1NTozOCArMDgwMApTdWJqZWN0OiBb UEFUQ0hdIG94LWxhdGV4LmVsOiBzdXBwb3J0IHNpZGV3YXlzIDpmbG9hdCBvcHRpb25zIGZvciB0 YWJsZXMgYW5kCiBmaWd1cmVzCgoqIGxpc3Avb3gtbGF0ZXguZWwgKG9yZy1sYXRleC0taW5saW5l LWltYWdlKTogc3VwcG9ydCBhICdzaWRld2F5cwpvcHRpb24gZm9yIHRoZSBmbG9hdCwgYW5kIGFk ZCBjYXNlIHRvIGhhbmRsZSBpdCB3aXRoIGEgXHNpZGVheXNmaWd1cmUKaW4gdGhlIGV4cG9ydC4K CihvcmctbGF0ZXgtLW9yZy10YWJsZSk6IHN1cHBvcnQgInNpZGV3YXlzIiBpbnN0ZWFkIG9mIGRl cHJlY2F0ZWQgInNpZGV3YXlzdGFibGUiCgoqIGRvYy9vcmcudGV4aSAoVGFibGVzIGluIExhVGVY IGV4cG9ydCk6IERvY3VtZW50IHVzZSBvZiA6ZmxvYXQgc2lkZXdheXMKCiAgICAgICAgICAgICAg IChJbWFnZXMgaW4gTGFUZVggZXhwb3J0KTogRG9jdW1lbnQgdXNlIG9mIDpmbG9hdCBzaWRld2F5 cwoKVGhpcyBwYXRjaCBwcm92aWRlcyBjb25zaXN0ZW50IDpmbG9hdCBzaWRld2F5cyBzdXBwb3J0 IGZvciBMYVRlWCBleHBvcnQgb2YgYm90aCBmaWd1cmVzIGFuZCB0YWJsZXMuCgpUSU5ZQ0hBTkdF Ci0tLQogZG9jL29yZy50ZXhpICAgICB8IDE0ICsrKysrKysrKysrLS0tCiBsaXNwL294LWxhdGV4 LmVsIHwgIDggKysrKysrKy0KIDIgZmlsZXMgY2hhbmdlZCwgMTggaW5zZXJ0aW9ucygrKSwgNCBk ZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9kb2Mvb3JnLnRleGkgYi9kb2Mvb3JnLnRleGkKaW5k ZXggOTIwNWFiYi4uMDViMTg4OCAxMDA2NDQKLS0tIGEvZG9jL29yZy50ZXhpCisrKyBiL2RvYy9v cmcudGV4aQpAQCAtMTE2OTYsMTAgKzExNjk2LDEzIEBAIHRhc2ssIHlvdSBjYW4gdXNlIEBjb2Rl ezpjYXB0aW9ufSBhdHRyaWJ1dGUgaW5zdGVhZC4gIEl0cyB2YWx1ZSBzaG91bGQgYmUgcmF3CiBA TGFUZVh7fSBjb2RlLiAgSXQgaGFzIHByZWNlZGVuY2Ugb3ZlciBAY29kZXsjK0NBUFRJT059Lgog QGl0ZW0gOmZsb2F0CiBAaXRlbXggOnBsYWNlbWVudAotRmxvYXQgZW52aXJvbm1lbnQgZm9yIHRo ZSB0YWJsZS4gIFBvc3NpYmxlIHZhbHVlcyBhcmUgQGNvZGV7c2lkZXdheXN0YWJsZX0sCitUaGUg QGNvZGV7OmZsb2F0fSBzcGVjaWZpZXMgdGhlIGZsb2F0IGVudmlyb25tZW50IGZvciB0aGUgdGFi bGUuICBQb3NzaWJsZQordmFsdWVzIGFyZSBAY29kZXtzaWRld2F5c31AZm9vdG5vdGV7Rm9ybWVy bHksIHRoZSB2YWx1ZSB3YXMKK0Bjb2Rle3NpZGV3YXlzdGFibGV9LiAgVGhpcyBpcyBkZXByZWNh dGVkIHNpbmNlIE9yZyA4LjMufSwKIEBjb2Rle211bHRpY29sdW1ufSwgQGNvZGV7dH0gYW5kIEBj b2Rle25pbH0uICBXaGVuIHVuc3BlY2lmaWVkLCBhIHRhYmxlIHdpdGgKLWEgY2FwdGlvbiB3aWxs IGhhdmUgYSBAY29kZXt0YWJsZX0gZW52aXJvbm1lbnQuICBNb3Jlb3ZlciwgQGNvZGV7OnBsYWNl bWVudH0KLWF0dHJpYnV0ZSBjYW4gc3BlY2lmeSB0aGUgcG9zaXRpb25pbmcgb2YgdGhlIGZsb2F0 LgorYSBjYXB0aW9uIHdpbGwgaGF2ZSBhIEBjb2Rle3RhYmxlfSBlbnZpcm9ubWVudC4gIE1vcmVv dmVyLCB0aGUKK0Bjb2RlezpwbGFjZW1lbnR9IGF0dHJpYnV0ZSBjYW4gc3BlY2lmeSB0aGUgcG9z aXRpb25pbmcgb2YgdGhlIGZsb2F0LiAgTm90ZToKK0Bjb2RlezpwbGFjZW1lbnR9IGlzIGlnbm9y ZWQgZm9yIEBjb2RlezpmbG9hdCBzaWRld2F5c30gdGFibGVzLgogQGl0ZW0gOmFsaWduCiBAaXRl bXggOmZvbnQKIEBpdGVteCA6d2lkdGgKQEAgLTExODAyLDYgKzExODA1LDExIEBAIGVudmlyb25t ZW50LgogQGNvZGV7d3JhcH06IGlmIHlvdSB3b3VsZCBsaWtlIHRvIGxldCB0ZXh0IGZsb3cgYXJv dW5kIHRoZSBpbWFnZS4gIEl0IHdpbGwKIG1ha2UgdGhlIGZpZ3VyZSBvY2N1cHkgdGhlIGxlZnQg aGFsZiBvZiB0aGUgcGFnZS4KIEBpdGVtCitAY29kZXtzaWRld2F5c306IGlmIHlvdSB3b3VsZCBs aWtlIHRoZSBpbWFnZSB0byBhcHBlYXIgYWxvbmUgb24gYSBzZXBhcmF0ZQorcGFnZSByb3RhdGVk IG5pbmV0eSBkZWdyZWVzIHVzaW5nIHRoZSBAY29kZXtzaWRld2F5c2ZpZ3VyZX0KK2Vudmlyb25t ZW50LiAgU2V0dGluZyB0aGlzIEBjb2RlezpmbG9hdH0gb3B0aW9uIHdpbGwgaWdub3JlIHRoZQor QGNvZGV7OnBsYWNlbWVudH0gc2V0dGluZy4KK0BpdGVtCiBAY29kZXtuaWx9OiBpZiB5b3UgbmVl ZCB0byBhdm9pZCBhbnkgZmxvYXRpbmcgZW52aXJvbm1lbnQsIGV2ZW4gd2hlbgogYSBjYXB0aW9u IGlzIHByb3ZpZGVkLgogQGVuZCBpdGVtaXplCmRpZmYgLS1naXQgYS9saXNwL294LWxhdGV4LmVs IGIvbGlzcC9veC1sYXRleC5lbAppbmRleCBkNjVjOTc1Li5lY2NmYTNkIDEwMDY0NAotLS0gYS9s aXNwL294LWxhdGV4LmVsCisrKyBiL2xpc3Avb3gtbGF0ZXguZWwKQEAgLTE4MDEsNiArMTgwMSw3 IEBAIHVzZWQgYXMgYSBjb21tdW5pY2F0aW9uIGNoYW5uZWwuIgogCSAoZmxvYXQgKGxldCAoKGZs b2F0IChwbGlzdC1nZXQgYXR0ciA6ZmxvYXQpKSkKIAkJICAoY29uZCAoKGFuZCAobm90IGZsb2F0 KSAocGxpc3QtbWVtYmVyIGF0dHIgOmZsb2F0KSkgbmlsKQogCQkJKChzdHJpbmc9IGZsb2F0ICJ3 cmFwIikgJ3dyYXApCisJCQkoKHN0cmluZz0gZmxvYXQgInNpZGV3YXlzIikgJ3NpZGV3YXlzKQog CQkJKChzdHJpbmc9IGZsb2F0ICJtdWx0aWNvbHVtbiIpICdtdWx0aWNvbHVtbikKIAkJCSgob3Ig ZmxvYXQKIAkJCSAgICAgKG9yZy1lbGVtZW50LXByb3BlcnR5IDpjYXB0aW9uIHBhcmVudCkKQEAg LTE4NzYsNiArMTg3NywxMCBAQCB1c2VkIGFzIGEgY29tbXVuaWNhdGlvbiBjaGFubmVsLiIKIFxc Y2VudGVyaW5nCiAlcyVzCiAlc1xcZW5ke3dyYXBmaWd1cmV9IiBwbGFjZW1lbnQgY29tbWVudC1p bmNsdWRlIGltYWdlLWNvZGUgY2FwdGlvbikpCisgICAgICAoc2lkZXdheXMgKGZvcm1hdCAiXFxi ZWdpbntzaWRld2F5c2ZpZ3VyZX0KK1xcY2VudGVyaW5nCislcyVzCislc1xcZW5ke3NpZGV3YXlz ZmlndXJlfSIgY29tbWVudC1pbmNsdWRlIGltYWdlLWNvZGUgY2FwdGlvbikpCiAgICAgICAobXVs dGljb2x1bW4gKGZvcm1hdCAiXFxiZWdpbntmaWd1cmUqfSVzCiBcXGNlbnRlcmluZwogJXMlcwpA QCAtMjU0Nyw3ICsyNTUyLDggQEAgVGhpcyBmdW5jdGlvbiBhc3N1bWVzIFRBQkxFIGhhcyBgb3Jn JyBhcyBpdHMgYDp0eXBlJyBwcm9wZXJ0eSBhbmQKIAkJICAgICAgKGxldCAoKGZsb2F0IChwbGlz dC1nZXQgYXR0ciA6ZmxvYXQpKSkKIAkJCShjb25kCiAJCQkgKChhbmQgKG5vdCBmbG9hdCkgKHBs aXN0LW1lbWJlciBhdHRyIDpmbG9hdCkpIG5pbCkKLQkJCSAoKHN0cmluZz0gZmxvYXQgInNpZGV3 YXlzdGFibGUiKSAic2lkZXdheXN0YWJsZSIpCisJCQkgKChvciAoc3RyaW5nPSBmbG9hdCAic2lk ZXdheXN0YWJsZSIpCisJCQkgICAgICAoc3RyaW5nPSBmbG9hdCAic2lkZXdheXMiKSkgInNpZGV3 YXlzdGFibGUiKQogCQkJICgoc3RyaW5nPSBmbG9hdCAibXVsdGljb2x1bW4iKSAidGFibGUqIikK IAkJCSAoKG9yIGZsb2F0CiAJCQkgICAgICAob3JnLWVsZW1lbnQtcHJvcGVydHkgOmNhcHRpb24g dGFibGUpCi0tIAoxLjguNC4zCgo= --089e0141a9a846c4ee04f65d165c--