From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Tucker-Kellogg Subject: Re: [PATCH] Making org-agenda filters orthogonal and refreshed Date: Sat, 19 Apr 2014 16:53:27 +0800 Message-ID: References: <87ppkdg8m5.fsf@bzg.ath.cx> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:42984) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WbR1e-0002zt-Pi for emacs-orgmode@gnu.org; Sat, 19 Apr 2014 04:53:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WbR1d-0001Ye-SM for emacs-orgmode@gnu.org; Sat, 19 Apr 2014 04:53:30 -0400 In-Reply-To: <87ppkdg8m5.fsf@bzg.ath.cx> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Bastien Cc: org-mode mailing list Hi Bastien, Org-mode version 8.2.5h (release_8.2.5h-883-g45e881 @ /Users/gtk/.emacs.d/org/lisp/) Sure, I'm happy to go with the FSF copyright agreement. I'll send the request today. Greg On Sat, Apr 19, 2014 at 2:02 PM, Bastien wrote: > Hi Greg, > > Greg Tucker-Kellogg writes: > >> This is org-mode version 8.2.5h, directly off the git. > > When mentioning the Org version for a patch you submit, please > include the whole version with C-u M-x org-version RET -- this > tells more than C-h v org-version. > >> emacs version 24.4.50.1 >> >> I have noticed that combining top headline filters and category >> filters didn't always work as documented. > > Thanks for looking into this. > > Before we go further enhancing the patch, are you willing to go with > the FSF copyright assignment? I see you already have tiny changes and > we cannot accept more. If you're not willing to sign, you'll drive > the debugging and I'll write the code. > > Let me know. > > Other than that, the diagnosis is good and the patch looks okay, > except for the use of defadvice. > > Thanks, > > -- > Bastien