From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Harkins Subject: Re: Bug: org-insert-heading-respect-content inserts at the wrong level if target heading is invisible [7.9.2 (release_7.9.2-883-g6fb36e.dirty @ /home/dlm/share/org-mode.git/lisp/)] Date: Tue, 12 Feb 2013 11:50:47 +0800 Message-ID: References: <874ni598fq.wl%jamshark70@dewdrop-world.net> <87k3qebvw4.fsf@bzg.ath.cx> Reply-To: jamshark70@dewdrop-world.net Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=e89a8fb201ac4df47204d57eee83 Return-path: Received: from eggs.gnu.org ([208.118.235.92]:58203) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U56tO-0007Or-Tq for emacs-orgmode@gnu.org; Mon, 11 Feb 2013 22:50:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U56tN-00015n-7C for emacs-orgmode@gnu.org; Mon, 11 Feb 2013 22:50:50 -0500 Received: from mail-oa0-f46.google.com ([209.85.219.46]:35796) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U56tN-00015d-2B for emacs-orgmode@gnu.org; Mon, 11 Feb 2013 22:50:49 -0500 Received: by mail-oa0-f46.google.com with SMTP id k1so7202600oag.33 for ; Mon, 11 Feb 2013 19:50:47 -0800 (PST) In-Reply-To: <87k3qebvw4.fsf@bzg.ath.cx> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Bastien Cc: emacs-orgmode@gnu.org --e89a8fb201ac4df47204d57eee83 Content-Type: text/plain; charset=ISO-8859-1 On Feb 12, 2013 1:31 AM, "Bastien" wrote: > > Hi James, > > James Harkins writes: > > > I'm resending the issue that I reported the other day, now with a > > MCE. > > Sorry for the delay on this -- and thanks for the detailed reports. > > I tried not to get lost in the details actually... so I ended up using > the attached fix. It works here, i.e. C-u C-RET inserts a new heading > at the right place, but I'm not using org-mobile.el so I'm not 100% > sure if it works for you. > > Can you test and confirm? I can, in about a week. I'm traveling, without my laptop (first time in years I've left it at home - phone and tablet only for this trip). I'm creating new entries in MobileOrg on the road. When I get home, I'll apply the patch and see what happens. One concern: When you tested with C-u C-RET, was the point on a hidden headline? The problem only occurs if the current heading is folded up underneath a parent heading. AFAIK cursor movement in org-mode ensures that the point is never on invisible text, which is why I wrote a short lisp function to demonstrate. It seems to me the issue reproduces only when calling org-insert-heading non-interactively, then, so I wanted to check if your test reproduces the problem without the patch. hjh --e89a8fb201ac4df47204d57eee83 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable

On Feb 12, 2013 1:31 AM, "Bastien" <bzg@altern.org> wrote:
>
> Hi James,
>
> James Harkins <jamshark70@g= mail.com> writes:
>
> > I'm resending the issue that I reported the other day, now wi= th a
> > MCE.
>
> Sorry for the delay on this -- and thanks for the detailed reports. >
> I tried not to get lost in the details actually... so I ended up using=
> the attached fix. =A0It works here, i.e. C-u C-RET inserts a new headi= ng
> at the right place, but I'm not using org-mobile.el so I'm not= 100%
> sure if it works for you.
>
> Can you test and confirm?

I can, in about a week. I'm traveling, without my laptop (first time= in years I've left it at home - phone and tablet only for this trip).<= /p>

I'm creating new entries in MobileOrg on the road. When I get home, = I'll apply the patch and see what happens.

One concern: When you tested with C-u C-RET, was the point on a hidden h= eadline? The problem only occurs if the current heading is folded up undern= eath a parent heading. AFAIK cursor movement in org-mode ensures that the p= oint is never on invisible text, which is why I wrote a short lisp function= to demonstrate. It seems to me the issue reproduces only when calling org-= insert-heading non-interactively, then, so I wanted to check if your test r= eproduces the problem without the patch.

hjh

--e89a8fb201ac4df47204d57eee83--