From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fabrice Popineau Subject: Re: Bug: wsl org-open-at-point [9.1.14 (9.1.14-9-g131531-elpa @ /home/boss5/.emacs.d/elpa/org-20181112/)] Date: Fri, 27 Dec 2019 18:25:52 +0100 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000001fed8f059ab2cab9" Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:44066) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iktNV-0002bj-MX for emacs-orgmode@gnu.org; Fri, 27 Dec 2019 12:26:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iktNR-0003NA-Ud for emacs-orgmode@gnu.org; Fri, 27 Dec 2019 12:26:20 -0500 Received: from smtp2.supelec.fr ([160.228.120.31]:55872) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iktNR-0003JM-HC for emacs-orgmode@gnu.org; Fri, 27 Dec 2019 12:26:17 -0500 Received: from localhost (localhost [127.0.0.1]) by smtp2.supelec.fr (Postfix) with ESMTP id B3D22802B7 for ; Fri, 27 Dec 2019 18:26:11 +0100 (CET) Received: from smtp2.supelec.fr ([127.0.0.1]) by localhost (smtp2.supelec.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id o6Ct8g-CptZM for ; Fri, 27 Dec 2019 18:26:10 +0100 (CET) Received: from mail-qv1-f52.google.com (mail-qv1-f52.google.com [209.85.219.52]) by smtp2.supelec.fr (Postfix) with ESMTPSA id 51B9D802AF for ; Fri, 27 Dec 2019 18:26:10 +0100 (CET) Received: by mail-qv1-f52.google.com with SMTP id x1so10254199qvr.8 for ; Fri, 27 Dec 2019 09:26:10 -0800 (PST) In-Reply-To: List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Steve Miano Cc: emacs-orgmode --0000000000001fed8f059ab2cab9 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, I had to solve this problem too. I used these functions: (defun w32-shell-execute (operation document &optional parameters show-flag) (if (and operation (not (string=3D "open" operation))) (error "Don't know how to %s %s" operation document) (call-process "/mnt/c/Windows/System32/cmd.exe" nil nil t "/c" "start" "\"\"" (concat "" (replace-regexp-in-string "^/mnt/c/" "c:/" (replace-regexp-in-string "^\\(/mnt/c\\)?/home/Fabrice/" "c:/home/" document)) "")))) (defun wsl-open-url (url &rest args) (w32-shell-execute "open" url)) (setq browse-url-browser-function #'wsl-open-url) (setq browse-url-mailto-function #'wsl-open-url) Regards, Fabrice Le ven. 27 d=C3=A9c. 2019 =C3=A0 18:10, Steve Miano = a =C3=A9crit : > On WSL, using emacs 25.1, in org-mode there is a bug/design issue. > > It the issue is: > When opening a link in org-mode using C-c C-o, org-open-at-point doesn't > work. It does find the browser, if you have set > > (setq browse-url-firefox-program "/mnt/c/PROGRA~1/MOZILL~1/firefox.exe") > > and does run the process, but it doesn't bring up a browser. You can > see the process in list-processes and if you run that command in the > console it works, but in org-mode the console never show and the > process remains. > > The function browse-url-default-browse finds and runs the correct > browser. However, it runs the browser using the wrong command > depending on the case. If you are on WSL, without the graphical > interface, you need to run the shell-command to use the windows > browser. This is how it is done when it detects cygwin using > system-type. However, System-type cannot be used to detect WSL because > it doesn't find that you are on windows. The uname command detects it. > > Obviously this isn't straight forward as in different situations you > want to do different things, graphical vs non-graphical. Perhaps > modify the function which sets system-type to return wsl then detect > graphical environment and use the non shell-command approach? > > I humbly bring this to your attention. Thanks in advance. > > > Emacs : GNU Emacs 25.1.1 (x86_64-pc-linux-gnu, GTK+ Version 3.22.11) > of 2017-09-15, modified by Debian > Package: Org mode version 9.1.14 (9.1.14-9-g131531-elpa @ > /home/XXXX/.emacs.d/elpa/org-20181112/) > > current state: > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > (setq > org-src-lang-modes '(("python" . python) ("plantuml" . fundamental) > ("ocaml" . tuareg) ("elisp" . emacs-lisp) ("ditaa" . artist) > ("asymptote" . asy) > ("dot" . fundamental) ("sqlite" . sql) ("calc" . > fundamental) ("C" . c) ("cpp" . c++) ("C++" . c++) ("screen" . > shell-script) > ("shell" . sh) ("bash" . sh)) > org-tab-first-hook '(org-babel-hide-result-toggle-maybe > org-babel-header-arg-expand) > org-babel-results-keyword "results" > org-speed-command-hook '(org-speed-command-activate > org-babel-speed-command-activate) > org-occur-hook '(org-first-headline-recenter) > org-metaup-hook '(org-babel-load-in-session-maybe) > org-log-done t > org-confirm-shell-link-function 'yes-or-no-p > org-link-search-must-match-exact-headline nil > org-default-notes-file "~/org/notes.org" > org-after-todo-state-change-hook '(org-clock-out-if-current) > org-from-is-user-regexp "\\" > org-src-mode-hook '(org-src-babel-configure-edit-buffer > org-src-mode-configure-edit-buffer) > org-agenda-before-write-hook '(org-agenda-add-entry-text) > org-babel-pre-tangle-hook '(save-buffer) > org-table-use-standard-references t > org-font-lock-set-keywor > > > --=20 Fabrice Popineau ----------------------------- CentraleSupelec D=C3=A9partement Informatique 3, rue Joliot Curie 91192 Gif/Yvette Cedex Tel direct : +33 (0) 169851950 Standard : +33 (0) 169851212 ------------------------------ --0000000000001fed8f059ab2cab9 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,

I had to solve this problem too.

I used these functions:

=C2= =A0 (defun w32-shell-execute (operation document &optional parameters s= how-flag)
=C2=A0 =C2=A0 (if (and operation (not (string=3D "open&qu= ot; operation)))
=C2=A0 =C2=A0 =C2=A0 =C2=A0 (error "Don't know= how to %s %s" operation document)
=C2=A0 =C2=A0 =C2=A0 (call-proce= ss "/mnt/c/Windows/System32/cmd.exe" nil nil t "/c" &qu= ot;start" "\"\""
=C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (concat ""
=C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 (replace-regexp-in-string "^/mnt/c/" "c:/&= quot;
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (replace-regexp-in-string = "^\\(/mnt/c\\)?/home/Fabrice/" "c:/home/" document))=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 ""))))
=C2=A0 (defun wsl-open-url (ur= l &rest args)
=C2=A0 =C2=A0 (w32-shell-execute "open" url)= )

=C2=A0 =C2=A0 (setq browse-url-browser-funct= ion #'wsl-open-url)
=C2=A0 =C2=A0 (setq browse-url-mailto-function #= 'wsl-open-url)

Regards,

Fabrice

Le=C2=A0ven. 27 d=C3=A9c. 2019 =C3=A0=C2=A018:10, Steve= Miano <stevem995@comcast.net> a =C3=A9crit=C2=A0:
On WSL, using emacs 25.1, in org-mode there is a bug/design issu= e.

It the issue is:
When opening a link in org-mode using C-c C-o, org-open-at-point doesn'= t
work. It does find the browser, if you have set

(setq browse-url-firefox-program "/mnt/c/PROGRA~1/MOZILL~1/firefox.exe= ")

and does run the process, but it doesn't bring up a browser. You can see the process in list-processes and if you run that command in the
console it works, but in org-mode the console never show and the
process remains.

The function browse-url-default-browse finds and runs the correct
browser. However, it runs the browser using the wrong command
depending on the case. If you are on WSL, without the graphical
interface, you need to run the shell-command to use the windows
browser. This is how it is done when it detects cygwin using
system-type. However, System-type cannot be used to detect WSL because
it doesn't find that you are on windows. The uname command detects it.<= br>
Obviously this isn't straight forward as in different situations you want to do different things, graphical vs non-graphical. Perhaps
modify the function which sets system-type to return wsl then detect
graphical environment and use the non shell-command approach?

I humbly bring this to your attention. Thanks in advance.


Emacs=C2=A0 : GNU Emacs 25.1.1 (x86_64-pc-linux-gnu, GTK+ Version 3.22.11)<= br> =C2=A0=C2=A0of 2017-09-15, modified by Debian
Package: Org mode version 9.1.14 (9.1.14-9-g131531-elpa @
/home/XXXX/.emacs.d/elpa/org-20181112/)

current state:
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
(setq
=C2=A0=C2=A0org-src-lang-modes '(("python" . python) ("p= lantuml" . fundamental)
("ocaml" . tuareg) ("elisp" . emacs-lisp) ("ditaa&= quot; . artist)
("asymptote" . asy)
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ("dot" = . fundamental) ("sqlite" . sql) ("calc" .
fundamental) ("C" . c) ("cpp" . c++) ("C++" .= c++) ("screen" . shell-script)
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ("shell"= ; . sh) ("bash" . sh))
=C2=A0=C2=A0org-tab-first-hook '(org-babel-hide-result-toggle-maybe org-babel-header-arg-expand)
=C2=A0=C2=A0org-babel-results-keyword "results"
=C2=A0=C2=A0org-speed-command-hook '(org-speed-command-activate
org-babel-speed-command-activate)
=C2=A0=C2=A0org-occur-hook '(org-first-headline-recenter)
=C2=A0=C2=A0org-metaup-hook '(org-babel-load-in-session-maybe)
=C2=A0=C2=A0org-log-done t
=C2=A0=C2=A0org-confirm-shell-link-function 'yes-or-no-p
=C2=A0=C2=A0org-link-search-must-match-exact-headline nil
=C2=A0=C2=A0org-default-notes-file "~/org/notes.org"
=C2=A0=C2=A0org-after-todo-state-change-hook '(org-clock-out-if-current= )
=C2=A0=C2=A0org-from-is-user-regexp "\\<XXXXXX-XXXXXX\\>" =C2=A0=C2=A0org-src-mode-hook '(org-src-babel-configure-edit-buffer org-src-mode-configure-edit-buffer)
=C2=A0=C2=A0org-agenda-before-write-hook '(org-agenda-add-entry-text) =C2=A0=C2=A0org-babel-pre-tangle-hook '(save-buffer)
=C2=A0=C2=A0org-table-use-standard-references t
=C2=A0=C2=A0org-font-lock-set-keywor




--
Fabrice Popineau
------------------= -----------
CentraleSupelec
D=C3=A9partement Informatique
3, rue Joliot Curie
91192 Gif/Yvette Cedex
Tel direct : += 33 (0) 169851950
Standard : +33 (0) 16= 9851212
------------------------------=

--0000000000001fed8f059ab2cab9--