From mboxrd@z Thu Jan 1 00:00:00 1970 From: Aaron Ecay Subject: Re: [PATCH] * lisp/ob-core.el (org-babel-execute-src-block): insert hash for silent results Date: Fri, 8 Mar 2013 16:25:20 -0500 Message-ID: References: <1362542863-25992-1-git-send-email-aaronecay@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from eggs.gnu.org ([208.118.235.92]:37273) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UE4n8-0005dK-SD for emacs-orgmode@gnu.org; Fri, 08 Mar 2013 16:25:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UE4n4-0001hN-4o for emacs-orgmode@gnu.org; Fri, 08 Mar 2013 16:25:26 -0500 Received: from mail-qc0-x231.google.com ([2607:f8b0:400d:c01::231]:61600) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UE4n3-0001hE-S8 for emacs-orgmode@gnu.org; Fri, 08 Mar 2013 16:25:22 -0500 Received: by mail-qc0-f177.google.com with SMTP id u28so738813qcs.36 for ; Fri, 08 Mar 2013 13:25:21 -0800 (PST) In-Reply-To: <1362542863-25992-1-git-send-email-aaronecay@gmail.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org On Tue, Mar 5, 2013 at 11:07 PM, Aaron Ecay wrote: > In order for the cache feature to work, the hash of a finished > computation must be inserted. But, this is not currently done for src > blocks which have the option :results none. Thus, we should insert a > dummy empty result for these blocks, which will hold the hash. > --- > lisp/ob-core.el | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/lisp/ob-core.el b/lisp/ob-core.el > index 3b7c463..eabfc05 100644 > --- a/lisp/ob-core.el > +++ b/lisp/ob-core.el > @@ -576,7 +576,10 @@ block." > (if (member "none" result-params) > (progn > (funcall cmd body params) > - (message "result silenced")) > + (message "result silenced") > + (when cachep The above should be cache-p (with hyphen). > + (org-babel-insert-result > + "" result-params info new-hash indent lang))) > (setq result > ((lambda (result) > (if (and (eq (cdr (assoc :result-type params)) 'value) > -- > 1.8.1.5 >