emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* org-store-link calls external link type store functions twice?
@ 2013-05-07 19:51 Robert Adesam
  2013-05-14  8:41 ` Bastien
  0 siblings, 1 reply; 3+ messages in thread
From: Robert Adesam @ 2013-05-07 19:51 UTC (permalink / raw)
  To: emacs-orgmode


[-- Attachment #1.1: Type: text/plain, Size: 1188 bytes --]

Hi fellow orgmoders,

I am not sure this is a bug but in version 8.x storing a link using an
external link type, org-store-link seems to call the external link type's
store function twice... I noticed this as I use an external link type that
asynchronous updates an external filedatabase and started to get random
file lock errors -- the org-store-link second call to the external link
type's store function sometimes came too quickly after the first one. :-)
Also, I do not have this problem in version 7.x of orgmode.

Instead of reverting back to a previous version of orgmode I started to
investigate -- attaching a patch that seems to help me anyway. It's not
that well tested and maybe, as I am not that familiar with everything going
on when storing a link using an external link type, it will break other
things...

yours,
/robert

PS. I will not file a formal bug report as it might not be a bug, just me
getting upset of a probable superfluous funcall...

M-x version:
GNU Emacs 24.3.1 (x86_64-pc-linux-gnu, GTK+ Version 3.6.4) of 2013-04-14 on
marid, modified by Debian
M-x org-version:
Org-mode version 8.0.2 (8.0.2-10-g3e1d83-elpa @
/home/robert/.emacs.d/elpa/org-20130506/)

[-- Attachment #1.2: Type: text/html, Size: 1294 bytes --]

[-- Attachment #2: org.el.patch --]
[-- Type: application/octet-stream, Size: 492 bytes --]

--- org.el	2013-05-07 21:04:42.230265766 +0200
+++ org.new.el	2013-05-07 21:04:11.374459978 +0200
@@ -9389,10 +9389,9 @@
 				 (completing-read
 				  "Which function for creating the link? "
 				  sfunsn t (car sfunsn)))))
-		  (funcall (caar sfuns)))
 	      (setq link (plist-get org-store-link-plist :link)
 		    desc (or (plist-get org-store-link-plist
-					:description) link))))
+					:description) link)))))
 
 	;; Store a link from a source code buffer
 	((org-src-edit-buffer-p)

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-05-14 13:05 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-07 19:51 org-store-link calls external link type store functions twice? Robert Adesam
2013-05-14  8:41 ` Bastien
2013-05-14 13:04   ` Robert Adesam

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).